fix the flame loaders match

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>

launcher/modplatform/ModIndex.cpp

@@ -31,6 +31,19 @@ static const QMap<QString, IndexedVersionType::VersionType> s_indexed_version_ty
     { "alpha", IndexedVersionType::VersionType::Alpha }
 };
 
+static const QList<ModLoaderType> loaderList = { NeoForge, Forge, Cauldron, LiteLoader, Quilt, Fabric };
+
+QList<ModLoaderType> modLoaderTypesToList(ModLoaderTypes flags)
+{
+    QList<ModLoaderType> flagList;
+    for (auto flag : loaderList) {
+        if (flags.testFlag(flag)) {
+            flagList.append(flag);
+        }
+    }
+    return flagList;
+}
+
 IndexedVersionType::IndexedVersionType(const QString& type) : IndexedVersionType(enumFromString(type)) {}
 
 IndexedVersionType::IndexedVersionType(const IndexedVersionType::VersionType& type)

launcher/modplatform/ModIndex.h

@@ -32,6 +32,7 @@ namespace ModPlatform {
 
 enum ModLoaderType { NeoForge = 1 << 0, Forge = 1 << 1, Cauldron = 1 << 2, LiteLoader = 1 << 3, Fabric = 1 << 4, Quilt = 1 << 5 };
 Q_DECLARE_FLAGS(ModLoaderTypes, ModLoaderType)
+QList<ModLoaderType> modLoaderTypesToList(ModLoaderTypes flags);
 
 enum class ResourceProvider { MODRINTH, FLAME };
 

launcher/modplatform/flame/FlameAPI.cpp

@@ -270,21 +270,35 @@ std::optional<ModPlatform::IndexedVersion> FlameAPI::getLatestVersion(QList<ModP
                                                                       QList<ModPlatform::ModLoaderType> instanceLoaders,
                                                                       ModPlatform::ModLoaderTypes modLoaders)
 {
-    // edge case: mod has installed for forge but the instance is fabric => fabric version will be prioritizated on update
+    QHash<ModPlatform::ModLoaderType, ModPlatform::IndexedVersion> bestMatch;
-    auto bestVersion = [&versions](ModPlatform::ModLoaderTypes loader) {
+    auto checkVersion = [&bestMatch](const ModPlatform::IndexedVersion& version, const ModPlatform::ModLoaderType& loader) {
-        std::optional<ModPlatform::IndexedVersion> ver;
+        if (bestMatch.contains(loader)) {
-        for (auto file_tmp : versions) {
+            auto best = bestMatch.value(loader);
-            if (file_tmp.loaders & loader && (!ver.has_value() || file_tmp.date > ver->date)) {
+            if (version.date > best.date) {
-                ver = file_tmp;
+                bestMatch[loader] = version;
+            }
+        } else {
+            bestMatch[loader] = version;
+        }
+    };
+    for (auto file_tmp : versions) {
+        auto loaders = ModPlatform::modLoaderTypesToList(file_tmp.loaders);
+        if (loaders.isEmpty()) {
+            checkVersion(file_tmp, ModPlatform::ModLoaderType(0));
+        } else {
+            for (auto loader : loaders) {
+                checkVersion(file_tmp, loader);
             }
         }
-        return ver;
+    }
-    };
+    // edge case: mod has installed for forge but the instance is fabric => fabric version will be prioritizated on update
-    for (auto l : instanceLoaders) {
+    auto currentLoaders = instanceLoaders + ModPlatform::modLoaderTypesToList(modLoaders);
-        auto ver = bestVersion(l);
+    currentLoaders.append(ModPlatform::ModLoaderType(0));  // add a fallback in case the versions do not define a loader
-        if (ver.has_value()) {
+
-            return ver;
+    for (auto loader : currentLoaders) {
+        if (bestMatch.contains(loader)) {
+            return bestMatch.value(loader);
         }
     }
-    return bestVersion(modLoaders);
+    return {};
 }

launcher/modplatform/modrinth/ModrinthCheckUpdate.cpp

@@ -8,6 +8,7 @@
 #include "QObjectPtr.h"
 #include "ResourceDownloadTask.h"
 
+#include "modplatform/ModIndex.h"
 #include "modplatform/helpers/HashUtils.h"
 
 #include "tasks/ConcurrentTask.h"
@@ -97,13 +98,9 @@ void ModrinthCheckUpdate::checkVersionsResponse(std::shared_ptr<QByteArray> resp
             // Sometimes a version may have multiple files, one with "forge" and one with "fabric",
             // so we may want to filter it
             QString loader_filter;
-            static auto flags = { ModPlatform::ModLoaderType::NeoForge, ModPlatform::ModLoaderType::Forge,
+            for (auto flag : ModPlatform::modLoaderTypesToList(loader)) {
-                                  ModPlatform::ModLoaderType::Quilt, ModPlatform::ModLoaderType::Fabric };
+                loader_filter = ModPlatform::getModLoaderAsString(flag);
-            for (auto flag : flags) {
+                break;
-                if (loader.testFlag(flag)) {
-                    loader_filter = ModPlatform::getModLoaderAsString(flag);
-                    break;
-                }
             }
 
             // Currently, we rely on a couple heuristics to determine whether an update is actually available or not:

launcher/modplatform/packwiz/Packwiz.cpp

@@ -186,11 +186,8 @@ void V1::updateModIndex(QDir& index_dir, Mod& mod)
     }
 
     toml::array loaders;
-    for (auto loader : { ModPlatform::NeoForge, ModPlatform::Forge, ModPlatform::Cauldron, ModPlatform::LiteLoader, ModPlatform::Fabric,
+    for (auto loader : ModPlatform::modLoaderTypesToList(mod.loaders)) {
-                         ModPlatform::Quilt }) {
+        loaders.push_back(getModLoaderAsString(loader).toStdString());
-        if (mod.loaders & loader) {
-            loaders.push_back(getModLoaderAsString(loader).toStdString());
-        }
     }
     toml::array mcVersions;
     for (auto version : mod.mcVersions) {