diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index f3896550f..999029bd2 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -54,14 +54,17 @@ jobs:
include:
- os: ubuntu-20.04
qt_ver: 5
+ qt_host: linux
+ qt_arch: ""
+ qt_version: "5.12.8"
+ qt_modules: "qtnetworkauth"
- os: ubuntu-20.04
qt_ver: 6
qt_host: linux
qt_arch: ""
qt_version: "6.2.4"
- qt_modules: "qt5compat qtimageformats"
- qt_tools: ""
+ qt_modules: "qt5compat qtimageformats qtnetworkauth"
- os: windows-2022
name: "Windows-MinGW-w64"
@@ -75,10 +78,9 @@ jobs:
vcvars_arch: "amd64"
qt_ver: 6
qt_host: windows
- qt_arch: ''
- qt_version: '6.7.0'
- qt_modules: 'qt5compat qtimageformats'
- qt_tools: ''
+ qt_arch: ""
+ qt_version: "6.7.0"
+ qt_modules: "qt5compat qtimageformats qtnetworkauth"
- os: windows-2022
name: "Windows-MSVC-arm64"
@@ -87,20 +89,18 @@ jobs:
vcvars_arch: "amd64_arm64"
qt_ver: 6
qt_host: windows
- qt_arch: 'win64_msvc2019_arm64'
- qt_version: '6.7.0'
- qt_modules: 'qt5compat qtimageformats'
- qt_tools: ''
+ qt_arch: "win64_msvc2019_arm64"
+ qt_version: "6.7.0"
+ qt_modules: "qt5compat qtimageformats qtnetworkauth"
- os: macos-12
name: macOS
macosx_deployment_target: 11.0
qt_ver: 6
qt_host: mac
- qt_arch: ''
- qt_version: '6.7.0'
- qt_modules: 'qt5compat qtimageformats'
- qt_tools: ''
+ qt_arch: ""
+ qt_version: "6.7.0"
+ qt_modules: "qt5compat qtimageformats qtnetworkauth"
- os: macos-12
name: macOS-Legacy
@@ -108,8 +108,7 @@ jobs:
qt_ver: 5
qt_host: mac
qt_version: "5.15.2"
- qt_modules: ""
- qt_tools: ""
+ qt_modules: "qtnetworkauth"
runs-on: ${{ matrix.os }}
@@ -151,6 +150,7 @@ jobs:
quazip-qt6:p
ccache:p
qt6-5compat:p
+ qt6-networkauth:p
cmark:p
- name: Force newer ccache
@@ -160,7 +160,7 @@ jobs:
- name: Setup ccache
if: (runner.os != 'Windows' || matrix.msystem == '') && inputs.build_type == 'Debug'
- uses: hendrikmuhs/ccache-action@v1.2.12
+ uses: hendrikmuhs/ccache-action@v1.2.13
with:
key: ${{ matrix.os }}-qt${{ matrix.qt_ver }}-${{ matrix.architecture }}
@@ -207,11 +207,6 @@ jobs:
brew update
brew install ninja extra-cmake-modules
- - name: Install Qt (Linux)
- if: runner.os == 'Linux' && matrix.qt_ver != 6
- run: |
- sudo apt-get -y install qtbase5-dev qtchooser qt5-qmake qtbase5-dev-tools libqt5core5a libqt5network5 libqt5gui5
-
- name: Install host Qt (Windows MSVC arm64)
if: runner.os == 'Windows' && matrix.architecture == 'arm64'
uses: jurplel/install-qt-action@v3
@@ -223,20 +218,18 @@ jobs:
target: "desktop"
arch: ""
modules: ${{ matrix.qt_modules }}
- tools: ${{ matrix.qt_tools }}
cache: ${{ inputs.is_qt_cached }}
cache-key-prefix: host-qt-arm64-windows
dir: ${{ github.workspace }}\HostQt
set-env: false
- - name: Install Qt (macOS, Linux, Qt 6 & Windows MSVC)
- if: runner.os == 'Linux' && matrix.qt_ver == 6 || runner.os == 'macOS' || (runner.os == 'Windows' && matrix.msystem == '')
+ - name: Install Qt (macOS, Linux & Windows MSVC)
+ if: matrix.msystem == ''
uses: jurplel/install-qt-action@v3
with:
aqtversion: "==3.1.*"
py7zrversion: ">=0.20.2"
version: ${{ matrix.qt_version }}
- host: ${{ matrix.qt_host }}
target: "desktop"
arch: ${{ matrix.qt_arch }}
modules: ${{ matrix.qt_modules }}
@@ -432,12 +425,6 @@ jobs:
run: |
cmake --install ${{ env.BUILD_DIR }} --config ${{ inputs.build_type }}
- cd ${{ env.INSTALL_DIR }}
- if ("${{ matrix.qt_ver }}" -eq "5")
- {
- Copy-Item ${{ runner.workspace }}/Qt/Tools/OpenSSL/Win_x86/bin/libcrypto-1_1.dll -Destination libcrypto-1_1.dll
- Copy-Item ${{ runner.workspace }}/Qt/Tools/OpenSSL/Win_x86/bin/libssl-1_1.dll -Destination libssl-1_1.dll
- }
cd ${{ github.workspace }}
Get-ChildItem ${{ env.INSTALL_DIR }} -Recurse | ForEach FullName | Resolve-Path -Relative | %{ $_.TrimStart('.\') } | %{ $_.TrimStart('${{ env.INSTALL_DIR }}') } | %{ $_.TrimStart('\') } | Out-File -FilePath ${{ env.INSTALL_DIR }}/manifest.txt
@@ -490,28 +477,6 @@ jobs:
":warning: Skipped code signing for Windows, as certificate was not present." >> $env:GITHUB_STEP_SUMMARY
}
- - name: Package (Linux)
- if: runner.os == 'Linux'
- run: |
- cmake --install ${{ env.BUILD_DIR }} --prefix ${{ env.INSTALL_DIR }}
- for l in $(find ${{ env.INSTALL_DIR }} -type f); do l=${l#$(pwd)/}; l=${l#${{ env.INSTALL_DIR }}/}; l=${l#./}; echo $l; done > ${{ env.INSTALL_DIR }}/manifest.txt
- cd ${{ env.INSTALL_DIR }}
- tar --owner root --group root -czf ../PrismLauncher.tar.gz *
-
- - name: Package (Linux, portable)
- if: runner.os == 'Linux'
- run: |
- cmake --install ${{ env.BUILD_DIR }} --prefix ${{ env.INSTALL_PORTABLE_DIR }}
- cmake --install ${{ env.BUILD_DIR }} --prefix ${{ env.INSTALL_PORTABLE_DIR }} --component portable
-
- # workaround to make portable installs to work on fedora
- mkdir ${{ env.INSTALL_PORTABLE_DIR }}/lib
- cp /lib/x86_64-linux-gnu/libbz2.so.1.0 ${{ env.INSTALL_PORTABLE_DIR }}/lib
-
- for l in $(find ${{ env.INSTALL_PORTABLE_DIR }} -type f); do l=${l#$(pwd)/}; l=${l#${{ env.INSTALL_PORTABLE_DIR }}/}; l=${l#./}; echo $l; done > ${{ env.INSTALL_PORTABLE_DIR }}/manifest.txt
- cd ${{ env.INSTALL_PORTABLE_DIR }}
- tar -czf ../PrismLauncher-portable.tar.gz *
-
- name: Package AppImage (Linux)
if: runner.os == 'Linux' && matrix.qt_ver != 5
shell: bash
@@ -558,6 +523,25 @@ jobs:
mv "PrismLauncher-Linux-x86_64.AppImage" "PrismLauncher-Linux-${{ env.VERSION }}-${{ inputs.build_type }}-x86_64.AppImage"
+ - name: Package (Linux, portable)
+ if: runner.os == 'Linux'
+ run: |
+ cmake -S . -B ${{ env.BUILD_DIR }} -DCMAKE_INSTALL_PREFIX=${{ env.INSTALL_PORTABLE_DIR }} -DCMAKE_BUILD_TYPE=${{ inputs.build_type }} -DENABLE_LTO=ON -DLauncher_BUILD_PLATFORM=official -DCMAKE_C_COMPILER_LAUNCHER=${{ env.CCACHE_VAR }} -DCMAKE_CXX_COMPILER_LAUNCHER=${{ env.CCACHE_VAR }} -DLauncher_QT_VERSION_MAJOR=${{ matrix.qt_ver }} -DLauncher_BUILD_ARTIFACT=Linux-Qt${{ matrix.qt_ver }} -DINSTALL_BUNDLE=full -G Ninja
+ cmake --install ${{ env.BUILD_DIR }}
+ cmake --install ${{ env.BUILD_DIR }} --component portable
+
+ mkdir ${{ env.INSTALL_PORTABLE_DIR }}/lib
+ cp /lib/x86_64-linux-gnu/libbz2.so.1.0 ${{ env.INSTALL_PORTABLE_DIR }}/lib
+ cp /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0 ${{ env.INSTALL_PORTABLE_DIR }}/lib
+ cp /usr/lib/x86_64-linux-gnu/libcrypto.so.1.1 ${{ env.INSTALL_PORTABLE_DIR }}/lib
+ cp /usr/lib/x86_64-linux-gnu/libssl.so.1.1 ${{ env.INSTALL_PORTABLE_DIR }}/lib
+ cp /usr/lib/x86_64-linux-gnu/libffi.so.7 ${{ env.INSTALL_PORTABLE_DIR }}/lib
+ mv ${{ env.INSTALL_PORTABLE_DIR }}/bin/*.so* ${{ env.INSTALL_PORTABLE_DIR }}/lib
+
+ for l in $(find ${{ env.INSTALL_PORTABLE_DIR }} -type f); do l=${l#$(pwd)/}; l=${l#${{ env.INSTALL_PORTABLE_DIR }}/}; l=${l#./}; echo $l; done > ${{ env.INSTALL_PORTABLE_DIR }}/manifest.txt
+ cd ${{ env.INSTALL_PORTABLE_DIR }}
+ tar -czf ../PrismLauncher-portable.tar.gz *
+
##
# UPLOAD BUILDS
##
@@ -590,13 +574,6 @@ jobs:
name: PrismLauncher-${{ matrix.name }}-Setup-${{ env.VERSION }}-${{ inputs.build_type }}
path: PrismLauncher-Setup.exe
- - name: Upload binary tarball (Linux, Qt 5)
- if: runner.os == 'Linux' && matrix.qt_ver != 6
- uses: actions/upload-artifact@v4
- with:
- name: PrismLauncher-${{ runner.os }}-Qt5-${{ env.VERSION }}-${{ inputs.build_type }}
- path: PrismLauncher.tar.gz
-
- name: Upload binary tarball (Linux, portable, Qt 5)
if: runner.os == 'Linux' && matrix.qt_ver != 6
uses: actions/upload-artifact@v4
@@ -604,13 +581,6 @@ jobs:
name: PrismLauncher-${{ runner.os }}-Qt5-Portable-${{ env.VERSION }}-${{ inputs.build_type }}
path: PrismLauncher-portable.tar.gz
- - name: Upload binary tarball (Linux, Qt 6)
- if: runner.os == 'Linux' && matrix.qt_ver !=5
- uses: actions/upload-artifact@v4
- with:
- name: PrismLauncher-${{ runner.os }}-Qt6-${{ env.VERSION }}-${{ inputs.build_type }}
- path: PrismLauncher.tar.gz
-
- name: Upload binary tarball (Linux, portable, Qt 6)
if: runner.os == 'Linux' && matrix.qt_ver != 5
uses: actions/upload-artifact@v4
diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
index d40d7eb68..5255f865b 100644
--- a/.github/workflows/codeql.yml
+++ b/.github/workflows/codeql.yml
@@ -23,7 +23,7 @@ jobs:
run:
sudo apt-get -y update
- sudo apt-get -y install ninja-build extra-cmake-modules scdoc qtbase5-dev qtchooser qt5-qmake qtbase5-dev-tools libqt5core5a libqt5network5 libqt5gui5
+ sudo apt-get -y install ninja-build extra-cmake-modules scdoc qtbase5-dev qtchooser qt5-qmake qtbase5-dev-tools libqt5core5a libqt5network5 libqt5gui5 libqt5networkauth5 libqt5networkauth5-dev
- name: Configure and Build
run: |
diff --git a/.github/workflows/trigger_release.yml b/.github/workflows/trigger_release.yml
index fa22c96d5..134281b2c 100644
--- a/.github/workflows/trigger_release.yml
+++ b/.github/workflows/trigger_release.yml
@@ -46,9 +46,7 @@ jobs:
run: |
mv ${{ github.workspace }}/PrismLauncher-source PrismLauncher-${{ env.VERSION }}
mv PrismLauncher-Linux-Qt6-Portable*/PrismLauncher-portable.tar.gz PrismLauncher-Linux-Qt6-Portable-${{ env.VERSION }}.tar.gz
- mv PrismLauncher-Linux-Qt6*/PrismLauncher.tar.gz PrismLauncher-Linux-Qt6-${{ env.VERSION }}.tar.gz
mv PrismLauncher-Linux-Qt5-Portable*/PrismLauncher-portable.tar.gz PrismLauncher-Linux-Qt5-Portable-${{ env.VERSION }}.tar.gz
- mv PrismLauncher-Linux-Qt5*/PrismLauncher.tar.gz PrismLauncher-Linux-Qt5-${{ env.VERSION }}.tar.gz
mv PrismLauncher-*.AppImage/PrismLauncher-*.AppImage PrismLauncher-Linux-x86_64.AppImage
mv PrismLauncher-*.AppImage.zsync/PrismLauncher-*.AppImage.zsync PrismLauncher-Linux-x86_64.AppImage.zsync
mv PrismLauncher-macOS-Legacy*/PrismLauncher.zip PrismLauncher-macOS-Legacy-${{ env.VERSION }}.zip
@@ -92,11 +90,9 @@ jobs:
draft: true
prerelease: false
files: |
- PrismLauncher-Linux-Qt5-${{ env.VERSION }}.tar.gz
PrismLauncher-Linux-Qt5-Portable-${{ env.VERSION }}.tar.gz
PrismLauncher-Linux-x86_64.AppImage
PrismLauncher-Linux-x86_64.AppImage.zsync
- PrismLauncher-Linux-Qt6-${{ env.VERSION }}.tar.gz
PrismLauncher-Linux-Qt6-Portable-${{ env.VERSION }}.tar.gz
PrismLauncher-Windows-MinGW-w64-${{ env.VERSION }}.zip
PrismLauncher-Windows-MinGW-w64-Portable-${{ env.VERSION }}.zip
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2e46bb605..5c3987406 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -282,7 +282,7 @@ endif()
include(QtVersionlessBackport)
if(Launcher_QT_VERSION_MAJOR EQUAL 5)
set(QT_VERSION_MAJOR 5)
- find_package(Qt5 REQUIRED COMPONENTS Core Widgets Concurrent Network Test Xml)
+ find_package(Qt5 REQUIRED COMPONENTS Core Widgets Concurrent Network Test Xml NetworkAuth)
if(NOT Launcher_FORCE_BUNDLED_LIBS)
find_package(QuaZip-Qt5 1.3 QUIET)
@@ -296,7 +296,7 @@ if(Launcher_QT_VERSION_MAJOR EQUAL 5)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DUNICODE -D_UNICODE")
elseif(Launcher_QT_VERSION_MAJOR EQUAL 6)
set(QT_VERSION_MAJOR 6)
- find_package(Qt6 REQUIRED COMPONENTS Core CoreTools Widgets Concurrent Network Test Xml Core5Compat)
+ find_package(Qt6 REQUIRED COMPONENTS Core CoreTools Widgets Concurrent Network Test Xml Core5Compat NetworkAuth)
list(APPEND Launcher_QT_LIBS Qt6::Core5Compat)
if(NOT Launcher_FORCE_BUNDLED_LIBS)
@@ -417,7 +417,19 @@ elseif(UNIX)
install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/${Launcher_mrpack_MIMEInfo} DESTINATION ${KDE_INSTALL_MIMEDIR})
install(FILES "${CMAKE_CURRENT_SOURCE_DIR}/launcher/qtlogging.ini" DESTINATION "share/${Launcher_Name}")
+
+ if (INSTALL_BUNDLE STREQUAL full)
+ set(PLUGIN_DEST_DIR "plugins")
+ set(BUNDLE_DEST_DIR ".")
+ set(RESOURCES_DEST_DIR ".")
+ # Apps to bundle
+ set(APPS "\${CMAKE_INSTALL_PREFIX}/bin/${Launcher_APP_BINARY_NAME}")
+
+ # directories to look for dependencies
+ set(DIRS ${QT_LIBS_DIR} ${QT_LIBEXECS_DIR} ${CMAKE_LIBRARY_OUTPUT_DIRECTORY} ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})
+ endif()
+
if(Launcher_ManPage)
install(FILES ${CMAKE_CURRENT_BINARY_DIR}/${Launcher_ManPage} DESTINATION "${KDE_INSTALL_MANDIR}/man6")
endif()
@@ -511,7 +523,6 @@ if(NOT cmark_FOUND)
else()
message(STATUS "Using system cmark")
endif()
-add_subdirectory(libraries/katabasis) # An OAuth2 library that tried to do too much
add_subdirectory(libraries/gamemode)
add_subdirectory(libraries/murmur2) # Hash for usage with the CurseForge API
if (NOT ghc_filesystem_FOUND)
diff --git a/COPYING.md b/COPYING.md
index f14e2958e..111587060 100644
--- a/COPYING.md
+++ b/COPYING.md
@@ -333,32 +333,6 @@
COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-## O2 (Katabasis fork)
-
- Copyright (c) 2012, Akos Polster
- All rights reserved.
-
- Redistribution and use in source and binary forms, with or without
- modification, are permitted provided that the following conditions are met:
-
- * Redistributions of source code must retain the above copyright notice, this
- list of conditions and the following disclaimer.
-
- * Redistributions in binary form must reproduce the above copyright notice,
- this list of conditions and the following disclaimer in the documentation
- and/or other materials provided with the distribution.
-
- THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
- AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
- FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
- DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
- SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
- CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
- OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
## Gamemode
Copyright (c) 2017-2022, Feral Interactive
diff --git a/cmake/MacOSXBundleInfo.plist.in b/cmake/MacOSXBundleInfo.plist.in
index d36ac3e8f..c439efe25 100644
--- a/cmake/MacOSXBundleInfo.plist.in
+++ b/cmake/MacOSXBundleInfo.plist.in
@@ -6,6 +6,8 @@
A Minecraft mod wants to access your camera.
NSMicrophoneUsageDescription
A Minecraft mod wants to access your microphone.
+ NSDownloadsFolderUsageDescription
+ Prism uses access to your Downloads folder to help you more quickly add mods that can't be automatically downloaded to your instance. You can change where Prism scans for downloaded mods in Settings or the prompt that appears.
NSPrincipalClass
NSApplication
NSHighResolutionCapable
diff --git a/flake.lock b/flake.lock
index 0fbfca9cc..740d5c43e 100644
--- a/flake.lock
+++ b/flake.lock
@@ -23,11 +23,11 @@
]
},
"locked": {
- "lastModified": 1712014858,
- "narHash": "sha256-sB4SWl2lX95bExY2gMFG5HIzvva5AVMJd4Igm+GpZNw=",
+ "lastModified": 1714641030,
+ "narHash": "sha256-yzcRNDoyVP7+SCNX0wmuDju1NUCt8Dz9+lyUXEI0dbI=",
"owner": "hercules-ci",
"repo": "flake-parts",
- "rev": "9126214d0a59633752a136528f5f3b9aa8565b7d",
+ "rev": "e5d10a24b66c3ea8f150e47dfdb0416ab7c3390e",
"type": "github"
},
"original": {
@@ -93,11 +93,11 @@
},
"nixpkgs": {
"locked": {
- "lastModified": 1713596654,
- "narHash": "sha256-LJbHQQ5aX1LVth2ST+Kkse/DRzgxlVhTL1rxthvyhZc=",
+ "lastModified": 1715413075,
+ "narHash": "sha256-FCi3R1MeS5bVp0M0xTheveP6hhcCYfW/aghSTPebYL4=",
"owner": "nixos",
"repo": "nixpkgs",
- "rev": "fd16bb6d3bcca96039b11aa52038fafeb6e4f4be",
+ "rev": "e4e7a43a9db7e22613accfeb1005cca1b2b1ee0d",
"type": "github"
},
"original": {
@@ -122,11 +122,11 @@
]
},
"locked": {
- "lastModified": 1712897695,
- "narHash": "sha256-nMirxrGteNAl9sWiOhoN5tIHyjBbVi5e2tgZUgZlK3Y=",
+ "lastModified": 1714478972,
+ "narHash": "sha256-q//cgb52vv81uOuwz1LaXElp3XAe1TqrABXODAEF6Sk=",
"owner": "cachix",
"repo": "pre-commit-hooks.nix",
- "rev": "40e6053ecb65fcbf12863338a6dcefb3f55f1bf8",
+ "rev": "2849da033884f54822af194400f8dff435ada242",
"type": "github"
},
"original": {
diff --git a/launcher/Application.cpp b/launcher/Application.cpp
index bb8751ccc..96a50f2ba 100644
--- a/launcher/Application.cpp
+++ b/launcher/Application.cpp
@@ -48,6 +48,7 @@
#include "pathmatcher/MultiMatcher.h"
#include "pathmatcher/SimplePrefixMatcher.h"
#include "settings/INIFile.h"
+#include "tools/GenericProfiler.h"
#include "ui/InstanceWindow.h"
#include "ui/MainWindow.h"
@@ -879,6 +880,7 @@ Application::Application(int& argc, char** argv) : QApplication(argc, argv)
// FIXME: what to do with these?
m_profilers.insert("jprofiler", std::shared_ptr(new JProfilerFactory()));
m_profilers.insert("jvisualvm", std::shared_ptr(new JVisualVMFactory()));
+ m_profilers.insert("generic", std::shared_ptr(new GenericProfilerFactory()));
for (auto profiler : m_profilers.values()) {
profiler->registerSettings(m_settings);
}
diff --git a/launcher/CMakeLists.txt b/launcher/CMakeLists.txt
index db84b4333..b7fb1f754 100644
--- a/launcher/CMakeLists.txt
+++ b/launcher/CMakeLists.txt
@@ -126,7 +126,6 @@ set(NET_SOURCES
net/MetaCacheSink.h
net/Logging.h
net/Logging.cpp
- net/NetAction.h
net/NetJob.cpp
net/NetJob.h
net/NetUtils.h
@@ -210,28 +209,17 @@ set(MINECRAFT_SOURCES
minecraft/auth/AccountData.h
minecraft/auth/AccountList.cpp
minecraft/auth/AccountList.h
- minecraft/auth/AccountTask.cpp
- minecraft/auth/AccountTask.h
- minecraft/auth/AuthRequest.cpp
- minecraft/auth/AuthRequest.h
minecraft/auth/AuthSession.cpp
minecraft/auth/AuthSession.h
- minecraft/auth/AuthStep.cpp
minecraft/auth/AuthStep.h
minecraft/auth/MinecraftAccount.cpp
minecraft/auth/MinecraftAccount.h
minecraft/auth/Parsers.cpp
minecraft/auth/Parsers.h
- minecraft/auth/flows/AuthFlow.cpp
- minecraft/auth/flows/AuthFlow.h
- minecraft/auth/flows/MSA.cpp
- minecraft/auth/flows/MSA.h
- minecraft/auth/flows/Offline.cpp
- minecraft/auth/flows/Offline.h
+ minecraft/auth/AuthFlow.cpp
+ minecraft/auth/AuthFlow.h
- minecraft/auth/steps/OfflineStep.cpp
- minecraft/auth/steps/OfflineStep.h
minecraft/auth/steps/EntitlementsStep.cpp
minecraft/auth/steps/EntitlementsStep.h
minecraft/auth/steps/GetSkinStep.cpp
@@ -240,6 +228,8 @@ set(MINECRAFT_SOURCES
minecraft/auth/steps/LauncherLoginStep.h
minecraft/auth/steps/MinecraftProfileStep.cpp
minecraft/auth/steps/MinecraftProfileStep.h
+ minecraft/auth/steps/MSADeviceCodeStep.cpp
+ minecraft/auth/steps/MSADeviceCodeStep.h
minecraft/auth/steps/MSAStep.cpp
minecraft/auth/steps/MSAStep.h
minecraft/auth/steps/XboxAuthorizationStep.cpp
@@ -453,6 +443,8 @@ set(TOOLS_SOURCES
tools/JVisualVM.h
tools/MCEditTool.cpp
tools/MCEditTool.h
+ tools/GenericProfiler.cpp
+ tools/GenericProfiler.h
)
set(META_SOURCES
@@ -624,7 +616,6 @@ set(PRISMUPDATER_SOURCES
net/HttpMetaCache.h
net/Logging.h
net/Logging.cpp
- net/NetAction.h
net/NetRequest.cpp
net/NetRequest.h
net/NetJob.cpp
@@ -827,6 +818,8 @@ SET(LAUNCHER_SOURCES
ui/themes/DarkTheme.h
ui/themes/ITheme.cpp
ui/themes/ITheme.h
+ ui/themes/HintOverrideProxyStyle.cpp
+ ui/themes/HintOverrideProxyStyle.h
ui/themes/SystemTheme.cpp
ui/themes/SystemTheme.h
ui/themes/IconTheme.cpp
@@ -1241,7 +1234,6 @@ target_link_libraries(Launcher_logic
tomlplusplus::tomlplusplus
qdcss
BuildConfig
- Katabasis
Qt${QT_VERSION_MAJOR}::Widgets
ghcFilesystem::ghc_filesystem
)
@@ -1259,6 +1251,7 @@ target_link_libraries(Launcher_logic
Qt${QT_VERSION_MAJOR}::Concurrent
Qt${QT_VERSION_MAJOR}::Gui
Qt${QT_VERSION_MAJOR}::Widgets
+ Qt${QT_VERSION_MAJOR}::NetworkAuth
${Launcher_QT_LIBS}
)
target_link_libraries(Launcher_logic
@@ -1329,7 +1322,6 @@ if(Launcher_BUILD_UPDATER)
Qt${QT_VERSION_MAJOR}::Network
${Launcher_QT_LIBS}
cmark::cmark
- Katabasis
)
add_executable("${Launcher_Name}_updater" WIN32 updater/prismupdater/updater_main.cpp)
@@ -1494,7 +1486,6 @@ if(INSTALL_BUNDLE STREQUAL "full")
CONFIGURATIONS Debug RelWithDebInfo ""
DESTINATION ${PLUGIN_DEST_DIR}
COMPONENT Runtime
- PATTERN "*qopensslbackend*" EXCLUDE
PATTERN "*qcertonlybackend*" EXCLUDE
)
install(
@@ -1505,10 +1496,78 @@ if(INSTALL_BUNDLE STREQUAL "full")
REGEX "dd\\." EXCLUDE
REGEX "_debug\\." EXCLUDE
REGEX "\\.dSYM" EXCLUDE
- PATTERN "*qopensslbackend*" EXCLUDE
PATTERN "*qcertonlybackend*" EXCLUDE
)
endif()
+ # Wayland support
+ if(EXISTS "${QT_PLUGINS_DIR}/wayland-graphics-integration-client")
+ install(
+ DIRECTORY "${QT_PLUGINS_DIR}/wayland-graphics-integration-client"
+ CONFIGURATIONS Debug RelWithDebInfo ""
+ DESTINATION ${PLUGIN_DEST_DIR}
+ COMPONENT Runtime
+ )
+ install(
+ DIRECTORY "${QT_PLUGINS_DIR}/wayland-graphics-integration-client"
+ CONFIGURATIONS Release MinSizeRel
+ DESTINATION ${PLUGIN_DEST_DIR}
+ COMPONENT Runtime
+ REGEX "dd\\." EXCLUDE
+ REGEX "_debug\\." EXCLUDE
+ REGEX "\\.dSYM" EXCLUDE
+ )
+ endif()
+ if(EXISTS "${QT_PLUGINS_DIR}/wayland-graphics-integration-server")
+ install(
+ DIRECTORY "${QT_PLUGINS_DIR}/wayland-graphics-integration-server"
+ CONFIGURATIONS Debug RelWithDebInfo ""
+ DESTINATION ${PLUGIN_DEST_DIR}
+ COMPONENT Runtime
+ )
+ install(
+ DIRECTORY "${QT_PLUGINS_DIR}/wayland-graphics-integration-server"
+ CONFIGURATIONS Release MinSizeRel
+ DESTINATION ${PLUGIN_DEST_DIR}
+ COMPONENT Runtime
+ REGEX "dd\\." EXCLUDE
+ REGEX "_debug\\." EXCLUDE
+ REGEX "\\.dSYM" EXCLUDE
+ )
+ endif()
+ if(EXISTS "${QT_PLUGINS_DIR}/wayland-decoration-client")
+ install(
+ DIRECTORY "${QT_PLUGINS_DIR}/wayland-decoration-client"
+ CONFIGURATIONS Debug RelWithDebInfo ""
+ DESTINATION ${PLUGIN_DEST_DIR}
+ COMPONENT Runtime
+ )
+ install(
+ DIRECTORY "${QT_PLUGINS_DIR}/wayland-decoration-client"
+ CONFIGURATIONS Release MinSizeRel
+ DESTINATION ${PLUGIN_DEST_DIR}
+ COMPONENT Runtime
+ REGEX "dd\\." EXCLUDE
+ REGEX "_debug\\." EXCLUDE
+ REGEX "\\.dSYM" EXCLUDE
+ )
+ endif()
+ if(EXISTS "${QT_PLUGINS_DIR}/wayland-shell-integration")
+ install(
+ DIRECTORY "${QT_PLUGINS_DIR}/wayland-shell-integration"
+ CONFIGURATIONS Debug RelWithDebInfo ""
+ DESTINATION ${PLUGIN_DEST_DIR}
+ COMPONENT Runtime
+ )
+ install(
+ DIRECTORY "${QT_PLUGINS_DIR}/wayland-shell-integration"
+ CONFIGURATIONS Release MinSizeRel
+ DESTINATION ${PLUGIN_DEST_DIR}
+ COMPONENT Runtime
+ REGEX "dd\\." EXCLUDE
+ REGEX "_debug\\." EXCLUDE
+ REGEX "\\.dSYM" EXCLUDE
+ )
+ endif()
configure_file(
"${CMAKE_CURRENT_SOURCE_DIR}/install_prereqs.cmake.in"
"${CMAKE_CURRENT_BINARY_DIR}/install_prereqs.cmake"
diff --git a/launcher/InstanceCreationTask.cpp b/launcher/InstanceCreationTask.cpp
index 73dc17891..1499199ae 100644
--- a/launcher/InstanceCreationTask.cpp
+++ b/launcher/InstanceCreationTask.cpp
@@ -3,8 +3,6 @@
#include
#include
-InstanceCreationTask::InstanceCreationTask() = default;
-
void InstanceCreationTask::executeTask()
{
setAbortable(true);
diff --git a/launcher/InstanceCreationTask.h b/launcher/InstanceCreationTask.h
index 380fdf8a4..84fb2a145 100644
--- a/launcher/InstanceCreationTask.h
+++ b/launcher/InstanceCreationTask.h
@@ -6,7 +6,7 @@
class InstanceCreationTask : public InstanceTask {
Q_OBJECT
public:
- InstanceCreationTask();
+ InstanceCreationTask() = default;
virtual ~InstanceCreationTask() = default;
protected:
diff --git a/launcher/LaunchController.cpp b/launcher/LaunchController.cpp
index a30f99439..cf8d0a794 100644
--- a/launcher/LaunchController.cpp
+++ b/launcher/LaunchController.cpp
@@ -57,7 +57,6 @@
#include "BuildConfig.h"
#include "JavaCommon.h"
#include "launch/steps/TextPrint.h"
-#include "minecraft/auth/AccountTask.h"
#include "tasks/Task.h"
LaunchController::LaunchController(QObject* parent) : Task(parent) {}
diff --git a/launcher/MMCZip.h b/launcher/MMCZip.h
index 43b4ab933..b28eb195c 100644
--- a/launcher/MMCZip.h
+++ b/launcher/MMCZip.h
@@ -154,7 +154,12 @@ bool collectFileListRecursively(const QString& rootDir, const QString& subDir, Q
#if defined(LAUNCHER_APPLICATION)
class ExportToZipTask : public Task {
public:
- ExportToZipTask(QString outputPath, QDir dir, QFileInfoList files, QString destinationPrefix = "", bool followSymlinks = false)
+ ExportToZipTask(QString outputPath,
+ QDir dir,
+ QFileInfoList files,
+ QString destinationPrefix = "",
+ bool followSymlinks = false,
+ bool utf8Enabled = false)
: m_output_path(outputPath)
, m_output(outputPath)
, m_dir(dir)
@@ -163,10 +168,15 @@ class ExportToZipTask : public Task {
, m_follow_symlinks(followSymlinks)
{
setAbortable(true);
- m_output.setUtf8Enabled(true);
+ m_output.setUtf8Enabled(utf8Enabled);
};
- ExportToZipTask(QString outputPath, QString dir, QFileInfoList files, QString destinationPrefix = "", bool followSymlinks = false)
- : ExportToZipTask(outputPath, QDir(dir), files, destinationPrefix, followSymlinks){};
+ ExportToZipTask(QString outputPath,
+ QString dir,
+ QFileInfoList files,
+ QString destinationPrefix = "",
+ bool followSymlinks = false,
+ bool utf8Enabled = false)
+ : ExportToZipTask(outputPath, QDir(dir), files, destinationPrefix, followSymlinks, utf8Enabled){};
virtual ~ExportToZipTask() = default;
diff --git a/launcher/install_prereqs.cmake.in b/launcher/install_prereqs.cmake.in
index e4408d161..acbce9650 100644
--- a/launcher/install_prereqs.cmake.in
+++ b/launcher/install_prereqs.cmake.in
@@ -1,5 +1,4 @@
set(CMAKE_MODULE_PATH "@CMAKE_MODULE_PATH@")
-
file(GLOB_RECURSE QTPLUGINS "${CMAKE_INSTALL_PREFIX}/@PLUGIN_DEST_DIR@/*@CMAKE_SHARED_LIBRARY_SUFFIX@")
function(gp_resolved_file_type_override resolved_file type_var)
if(resolved_file MATCHES "^/(usr/)?lib/libQt")
diff --git a/launcher/java/JavaUtils.cpp b/launcher/java/JavaUtils.cpp
index 3627cec39..e767eff89 100644
--- a/launcher/java/JavaUtils.cpp
+++ b/launcher/java/JavaUtils.cpp
@@ -362,6 +362,12 @@ QList JavaUtils::FindJavaPaths()
javas.append(systemLibraryJVMDir.absolutePath() + "/" + java + "/Contents/Home/bin/java");
javas.append(systemLibraryJVMDir.absolutePath() + "/" + java + "/Contents/Commands/java");
}
+
+ auto home = qEnvironmentVariable("HOME");
+
+ // javas downloaded by sdkman
+ javas.append(FS::PathCombine(home, ".sdkman/candidates/java"));
+
javas.append(getMinecraftJavaBundle());
javas = addJavasFromEnv(javas);
javas.removeDuplicates();
diff --git a/launcher/minecraft/AssetsUtils.cpp b/launcher/minecraft/AssetsUtils.cpp
index 48e150d16..6bbe0bb2c 100644
--- a/launcher/minecraft/AssetsUtils.cpp
+++ b/launcher/minecraft/AssetsUtils.cpp
@@ -51,6 +51,7 @@
#include "net/Download.h"
#include "Application.h"
+#include "net/NetRequest.h"
namespace {
QSet collectPathsFromDir(QString dirPath)
@@ -276,7 +277,7 @@ bool reconstructAssets(QString assetsId, QString resourcesFolder)
} // namespace AssetsUtils
-NetAction::Ptr AssetObject::getDownloadAction()
+Net::NetRequest::Ptr AssetObject::getDownloadAction()
{
QFileInfo objectFile(getLocalPath());
if ((!objectFile.isFile()) || (objectFile.size() != size)) {
diff --git a/launcher/minecraft/AssetsUtils.h b/launcher/minecraft/AssetsUtils.h
index 87956e57a..ea3613bd0 100644
--- a/launcher/minecraft/AssetsUtils.h
+++ b/launcher/minecraft/AssetsUtils.h
@@ -17,14 +17,14 @@
#include
#include
-#include "net/NetAction.h"
#include "net/NetJob.h"
+#include "net/NetRequest.h"
struct AssetObject {
QString getRelPath();
QUrl getUrl();
QString getLocalPath();
- NetAction::Ptr getDownloadAction();
+ Net::NetRequest::Ptr getDownloadAction();
QString hash;
qint64 size;
diff --git a/launcher/minecraft/Library.cpp b/launcher/minecraft/Library.cpp
index 0e8ddf03d..2c3f2035f 100644
--- a/launcher/minecraft/Library.cpp
+++ b/launcher/minecraft/Library.cpp
@@ -35,6 +35,7 @@
#include "Library.h"
#include "MinecraftInstance.h"
+#include "net/NetRequest.h"
#include
#include
@@ -74,12 +75,12 @@ void Library::getApplicableFiles(const RuntimeContext& runtimeContext,
}
}
-QList Library::getDownloads(const RuntimeContext& runtimeContext,
- class HttpMetaCache* cache,
- QStringList& failedLocalFiles,
- const QString& overridePath) const
+QList Library::getDownloads(const RuntimeContext& runtimeContext,
+ class HttpMetaCache* cache,
+ QStringList& failedLocalFiles,
+ const QString& overridePath) const
{
- QList out;
+ QList out;
bool stale = isAlwaysStale();
bool local = isLocal();
diff --git a/launcher/minecraft/Library.h b/launcher/minecraft/Library.h
index adb89c4c6..d3019e814 100644
--- a/launcher/minecraft/Library.h
+++ b/launcher/minecraft/Library.h
@@ -34,7 +34,6 @@
*/
#pragma once
-#include
#include
#include
#include
@@ -48,6 +47,7 @@
#include "MojangDownloadInfo.h"
#include "Rule.h"
#include "RuntimeContext.h"
+#include "net/NetRequest.h"
class Library;
class MinecraftInstance;
@@ -144,10 +144,10 @@ class Library {
bool isForge() const;
// Get a list of downloads for this library
- QList getDownloads(const RuntimeContext& runtimeContext,
- class HttpMetaCache* cache,
- QStringList& failedLocalFiles,
- const QString& overridePath) const;
+ QList getDownloads(const RuntimeContext& runtimeContext,
+ class HttpMetaCache* cache,
+ QStringList& failedLocalFiles,
+ const QString& overridePath) const;
QString getCompatibleNative(const RuntimeContext& runtimeContext) const;
diff --git a/launcher/minecraft/auth/AccountData.cpp b/launcher/minecraft/auth/AccountData.cpp
index e1f1e9b1e..fd2082035 100644
--- a/launcher/minecraft/auth/AccountData.cpp
+++ b/launcher/minecraft/auth/AccountData.cpp
@@ -42,7 +42,7 @@
#include
namespace {
-void tokenToJSONV3(QJsonObject& parent, Katabasis::Token t, const char* tokenName)
+void tokenToJSONV3(QJsonObject& parent, Token t, const char* tokenName)
{
if (!t.persistent) {
return;
@@ -74,9 +74,9 @@ void tokenToJSONV3(QJsonObject& parent, Katabasis::Token t, const char* tokenNam
}
}
-Katabasis::Token tokenFromJSONV3(const QJsonObject& parent, const char* tokenName)
+Token tokenFromJSONV3(const QJsonObject& parent, const char* tokenName)
{
- Katabasis::Token out;
+ Token out;
auto tokenObject = parent.value(tokenName).toObject();
if (tokenObject.isEmpty()) {
return out;
@@ -94,7 +94,7 @@ Katabasis::Token tokenFromJSONV3(const QJsonObject& parent, const char* tokenNam
auto token = tokenObject.value("token");
if (token.isString()) {
out.token = token.toString();
- out.validity = Katabasis::Validity::Assumed;
+ out.validity = Validity::Assumed;
}
auto refresh_token = tokenObject.value("refresh_token");
@@ -241,13 +241,13 @@ MinecraftProfile profileFromJSONV3(const QJsonObject& parent, const char* tokenN
}
}
}
- out.validity = Katabasis::Validity::Assumed;
+ out.validity = Validity::Assumed;
return out;
}
void entitlementToJSONV3(QJsonObject& parent, MinecraftEntitlement p)
{
- if (p.validity == Katabasis::Validity::None) {
+ if (p.validity == Validity::None) {
return;
}
QJsonObject out;
@@ -271,7 +271,7 @@ bool entitlementFromJSONV3(const QJsonObject& parent, MinecraftEntitlement& out)
}
out.canPlayMinecraft = canPlayMinecraftV.toBool(false);
out.ownsMinecraft = ownsMinecraftV.toBool(false);
- out.validity = Katabasis::Validity::Assumed;
+ out.validity = Validity::Assumed;
}
return true;
}
@@ -313,10 +313,10 @@ bool AccountData::resumeStateFromV3(QJsonObject data)
minecraftProfile = profileFromJSONV3(data, "profile");
if (!entitlementFromJSONV3(data, minecraftEntitlement)) {
- if (minecraftProfile.validity != Katabasis::Validity::None) {
+ if (minecraftProfile.validity != Validity::None) {
minecraftEntitlement.canPlayMinecraft = true;
minecraftEntitlement.ownsMinecraft = true;
- minecraftEntitlement.validity = Katabasis::Validity::Assumed;
+ minecraftEntitlement.validity = Validity::Assumed;
}
}
diff --git a/launcher/minecraft/auth/AccountData.h b/launcher/minecraft/auth/AccountData.h
index bac77e17f..1ada4e38a 100644
--- a/launcher/minecraft/auth/AccountData.h
+++ b/launcher/minecraft/auth/AccountData.h
@@ -34,12 +34,29 @@
*/
#pragma once
-#include
#include
#include
#include
#include
+#include
+#include
+#include
+#include
+
+enum class Validity { None, Assumed, Certain };
+
+struct Token {
+ QDateTime issueInstant;
+ QDateTime notAfter;
+ QString token;
+ QString refresh_token;
+ QVariantMap extra;
+
+ Validity validity = Validity::None;
+ bool persistent = true;
+};
+
struct Skin {
QString id;
QString url;
@@ -59,7 +76,7 @@ struct Cape {
struct MinecraftEntitlement {
bool ownsMinecraft = false;
bool canPlayMinecraft = false;
- Katabasis::Validity validity = Katabasis::Validity::None;
+ Validity validity = Validity::None;
};
struct MinecraftProfile {
@@ -68,7 +85,7 @@ struct MinecraftProfile {
Skin skin;
QString currentCape;
QMap capes;
- Katabasis::Validity validity = Katabasis::Validity::None;
+ Validity validity = Validity::None;
};
enum class AccountType { MSA, Offline };
@@ -93,15 +110,15 @@ struct AccountData {
AccountType type = AccountType::MSA;
QString msaClientID;
- Katabasis::Token msaToken;
- Katabasis::Token userToken;
- Katabasis::Token xboxApiToken;
- Katabasis::Token mojangservicesToken;
+ Token msaToken;
+ Token userToken;
+ Token xboxApiToken;
+ Token mojangservicesToken;
- Katabasis::Token yggdrasilToken;
+ Token yggdrasilToken;
MinecraftProfile minecraftProfile;
MinecraftEntitlement minecraftEntitlement;
- Katabasis::Validity validity_ = Katabasis::Validity::None;
+ Validity validity_ = Validity::None;
// runtime only information (not saved with the account)
QString internalId;
diff --git a/launcher/minecraft/auth/AccountList.cpp b/launcher/minecraft/auth/AccountList.cpp
index 68ebe3626..d276d4c41 100644
--- a/launcher/minecraft/auth/AccountList.cpp
+++ b/launcher/minecraft/auth/AccountList.cpp
@@ -35,7 +35,7 @@
#include "AccountList.h"
#include "AccountData.h"
-#include "AccountTask.h"
+#include "tasks/Task.h"
#include
#include
@@ -639,8 +639,8 @@ void AccountList::tryNext()
if (account->internalId() == accountId) {
m_currentTask = account->refresh();
if (m_currentTask) {
- connect(m_currentTask.get(), &AccountTask::succeeded, this, &AccountList::authSucceeded);
- connect(m_currentTask.get(), &AccountTask::failed, this, &AccountList::authFailed);
+ connect(m_currentTask.get(), &Task::succeeded, this, &AccountList::authSucceeded);
+ connect(m_currentTask.get(), &Task::failed, this, &AccountList::authFailed);
m_currentTask->start();
qDebug() << "RefreshSchedule: Processing account " << account->accountDisplayString() << " with internal ID "
<< accountId;
diff --git a/launcher/minecraft/auth/AccountList.h b/launcher/minecraft/auth/AccountList.h
index 039730739..d3be6740e 100644
--- a/launcher/minecraft/auth/AccountList.h
+++ b/launcher/minecraft/auth/AccountList.h
@@ -36,6 +36,7 @@
#pragma once
#include "MinecraftAccount.h"
+#include "minecraft/auth/AuthFlow.h"
#include
#include
@@ -144,7 +145,7 @@ class AccountList : public QAbstractListModel {
QList m_refreshQueue;
QTimer* m_refreshTimer;
QTimer* m_nextTimer;
- shared_qobject_ptr m_currentTask;
+ shared_qobject_ptr m_currentTask;
/*!
* Called whenever the list changes.
diff --git a/launcher/minecraft/auth/AccountTask.cpp b/launcher/minecraft/auth/AccountTask.cpp
deleted file mode 100644
index 4c3d6ee19..000000000
--- a/launcher/minecraft/auth/AccountTask.cpp
+++ /dev/null
@@ -1,134 +0,0 @@
-// SPDX-License-Identifier: GPL-3.0-only
-/*
- * Prism Launcher - Minecraft Launcher
- * Copyright (C) 2022 Sefa Eyeoglu
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, version 3.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program. If not, see .
- *
- * This file incorporates work covered by the following copyright and
- * permission notice:
- *
- * Copyright 2013-2021 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include "AccountTask.h"
-#include "MinecraftAccount.h"
-
-#include
-#include
-#include
-#include
-#include
-#include
-
-#include
-
-AccountTask::AccountTask(AccountData* data, QObject* parent) : Task(parent), m_data(data)
-{
- changeState(AccountTaskState::STATE_CREATED);
-}
-
-QString AccountTask::getStateMessage() const
-{
- switch (m_taskState) {
- case AccountTaskState::STATE_CREATED:
- return "Waiting...";
- case AccountTaskState::STATE_WORKING:
- return tr("Sending request to auth servers...");
- case AccountTaskState::STATE_SUCCEEDED:
- return tr("Authentication task succeeded.");
- case AccountTaskState::STATE_OFFLINE:
- return tr("Failed to contact the authentication server.");
- case AccountTaskState::STATE_DISABLED:
- return tr("Client ID has changed. New session needs to be created.");
- case AccountTaskState::STATE_FAILED_SOFT:
- return tr("Encountered an error during authentication.");
- case AccountTaskState::STATE_FAILED_HARD:
- return tr("Failed to authenticate. The session has expired.");
- case AccountTaskState::STATE_FAILED_GONE:
- return tr("Failed to authenticate. The account no longer exists.");
- default:
- return tr("...");
- }
-}
-
-bool AccountTask::changeState(AccountTaskState newState, QString reason)
-{
- m_taskState = newState;
- // FIXME: virtual method invoked in constructor.
- // We want that behavior, but maybe make it less weird?
- setStatus(getStateMessage());
- switch (newState) {
- case AccountTaskState::STATE_CREATED: {
- m_data->errorString.clear();
- return true;
- }
- case AccountTaskState::STATE_WORKING: {
- m_data->accountState = AccountState::Working;
- return true;
- }
- case AccountTaskState::STATE_SUCCEEDED: {
- m_data->accountState = AccountState::Online;
- emitSucceeded();
- return false;
- }
- case AccountTaskState::STATE_OFFLINE: {
- m_data->errorString = reason;
- m_data->accountState = AccountState::Offline;
- emitFailed(reason);
- return false;
- }
- case AccountTaskState::STATE_DISABLED: {
- m_data->errorString = reason;
- m_data->accountState = AccountState::Disabled;
- emitFailed(reason);
- return false;
- }
- case AccountTaskState::STATE_FAILED_SOFT: {
- m_data->errorString = reason;
- m_data->accountState = AccountState::Errored;
- emitFailed(reason);
- return false;
- }
- case AccountTaskState::STATE_FAILED_HARD: {
- m_data->errorString = reason;
- m_data->accountState = AccountState::Expired;
- emitFailed(reason);
- return false;
- }
- case AccountTaskState::STATE_FAILED_GONE: {
- m_data->errorString = reason;
- m_data->accountState = AccountState::Gone;
- emitFailed(reason);
- return false;
- }
- default: {
- QString error = tr("Unknown account task state: %1").arg(int(newState));
- m_data->accountState = AccountState::Errored;
- emitFailed(error);
- return false;
- }
- }
-}
diff --git a/launcher/minecraft/auth/AccountTask.h b/launcher/minecraft/auth/AccountTask.h
deleted file mode 100644
index 82332c0b9..000000000
--- a/launcher/minecraft/auth/AccountTask.h
+++ /dev/null
@@ -1,92 +0,0 @@
-// SPDX-License-Identifier: GPL-3.0-only
-/*
- * Prism Launcher - Minecraft Launcher
- * Copyright (C) 2022 Sefa Eyeoglu
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, version 3.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program. If not, see .
- *
- * This file incorporates work covered by the following copyright and
- * permission notice:
- *
- * Copyright 2013-2021 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#pragma once
-
-#include
-
-#include
-#include
-#include
-#include
-
-#include "MinecraftAccount.h"
-
-class QNetworkReply;
-
-/**
- * Enum for describing the state of the current task.
- * Used by the getStateMessage function to determine what the status message should be.
- */
-enum class AccountTaskState {
- STATE_CREATED,
- STATE_WORKING,
- STATE_SUCCEEDED,
- STATE_DISABLED, //!< MSA Client ID has changed. Tell user to reloginn
- STATE_FAILED_SOFT, //!< soft failure. authentication went through partially
- STATE_FAILED_HARD, //!< hard failure. main tokens are invalid
- STATE_FAILED_GONE, //!< hard failure. main tokens are invalid, and the account no longer exists
- STATE_OFFLINE //!< soft failure. authentication failed in the first step in a 'soft' way
-};
-
-class AccountTask : public Task {
- Q_OBJECT
- public:
- explicit AccountTask(AccountData* data, QObject* parent = 0);
- virtual ~AccountTask(){};
-
- AccountTaskState m_taskState = AccountTaskState::STATE_CREATED;
-
- AccountTaskState taskState() { return m_taskState; }
-
- signals:
- void showVerificationUriAndCode(const QUrl& uri, const QString& code, int expiresIn);
- void hideVerificationUriAndCode();
-
- protected:
- /**
- * Returns the state message for the given state.
- * Used to set the status message for the task.
- * Should be overridden by subclasses that want to change messages for a given state.
- */
- virtual QString getStateMessage() const;
-
- protected slots:
- // NOTE: true -> non-terminal state, false -> terminal state
- bool changeState(AccountTaskState newState, QString reason = QString());
-
- protected:
- AccountData* m_data = nullptr;
-};
diff --git a/launcher/minecraft/auth/AuthFlow.cpp b/launcher/minecraft/auth/AuthFlow.cpp
new file mode 100644
index 000000000..5648fe9f6
--- /dev/null
+++ b/launcher/minecraft/auth/AuthFlow.cpp
@@ -0,0 +1,146 @@
+#include
+#include
+#include
+#include
+
+#include "minecraft/auth/AccountData.h"
+#include "minecraft/auth/steps/EntitlementsStep.h"
+#include "minecraft/auth/steps/GetSkinStep.h"
+#include "minecraft/auth/steps/LauncherLoginStep.h"
+#include "minecraft/auth/steps/MSADeviceCodeStep.h"
+#include "minecraft/auth/steps/MSAStep.h"
+#include "minecraft/auth/steps/MinecraftProfileStep.h"
+#include "minecraft/auth/steps/XboxAuthorizationStep.h"
+#include "minecraft/auth/steps/XboxProfileStep.h"
+#include "minecraft/auth/steps/XboxUserStep.h"
+#include "tasks/Task.h"
+
+#include "AuthFlow.h"
+
+#include
+
+AuthFlow::AuthFlow(AccountData* data, Action action, QObject* parent) : Task(parent), m_data(data)
+{
+ if (data->type == AccountType::MSA) {
+ if (action == Action::DeviceCode) {
+ auto oauthStep = makeShared(m_data);
+ connect(oauthStep.get(), &MSADeviceCodeStep::authorizeWithBrowser, this, &AuthFlow::authorizeWithBrowserWithExtra);
+ connect(this, &Task::aborted, oauthStep.get(), &MSADeviceCodeStep::abort);
+ m_steps.append(oauthStep);
+ } else {
+ auto oauthStep = makeShared(m_data, action == Action::Refresh);
+ connect(oauthStep.get(), &MSAStep::authorizeWithBrowser, this, &AuthFlow::authorizeWithBrowser);
+ m_steps.append(oauthStep);
+ }
+ m_steps.append(makeShared(m_data));
+ m_steps.append(makeShared(m_data, &m_data->xboxApiToken, "http://xboxlive.com", "Xbox"));
+ m_steps.append(
+ makeShared(m_data, &m_data->mojangservicesToken, "rp://api.minecraftservices.com/", "Mojang"));
+ m_steps.append(makeShared(m_data));
+ m_steps.append(makeShared(m_data));
+ m_steps.append(makeShared(m_data));
+ m_steps.append(makeShared(m_data));
+ m_steps.append(makeShared(m_data));
+ }
+ changeState(AccountTaskState::STATE_CREATED);
+}
+
+void AuthFlow::succeed()
+{
+ m_data->validity_ = Validity::Certain;
+ changeState(AccountTaskState::STATE_SUCCEEDED, tr("Finished all authentication steps"));
+}
+
+void AuthFlow::executeTask()
+{
+ changeState(AccountTaskState::STATE_WORKING, tr("Initializing"));
+ nextStep();
+}
+
+void AuthFlow::nextStep()
+{
+ if (m_steps.size() == 0) {
+ // we got to the end without an incident... assume this is all.
+ m_currentStep.reset();
+ succeed();
+ return;
+ }
+ m_currentStep = m_steps.front();
+ qDebug() << "AuthFlow:" << m_currentStep->describe();
+ m_steps.pop_front();
+ connect(m_currentStep.get(), &AuthStep::finished, this, &AuthFlow::stepFinished);
+
+ m_currentStep->perform();
+}
+
+void AuthFlow::stepFinished(AccountTaskState resultingState, QString message)
+{
+ if (changeState(resultingState, message))
+ nextStep();
+}
+
+bool AuthFlow::changeState(AccountTaskState newState, QString reason)
+{
+ m_taskState = newState;
+ setDetails(reason);
+ switch (newState) {
+ case AccountTaskState::STATE_CREATED: {
+ setStatus(tr("Waiting..."));
+ m_data->errorString.clear();
+ return true;
+ }
+ case AccountTaskState::STATE_WORKING: {
+ setStatus(m_currentStep ? m_currentStep->describe() : tr("Working..."));
+ m_data->accountState = AccountState::Working;
+ return true;
+ }
+ case AccountTaskState::STATE_SUCCEEDED: {
+ setStatus(tr("Authentication task succeeded."));
+ m_data->accountState = AccountState::Online;
+ emitSucceeded();
+ return false;
+ }
+ case AccountTaskState::STATE_OFFLINE: {
+ setStatus(tr("Failed to contact the authentication server."));
+ m_data->errorString = reason;
+ m_data->accountState = AccountState::Offline;
+ emitFailed(reason);
+ return false;
+ }
+ case AccountTaskState::STATE_DISABLED: {
+ setStatus(tr("Client ID has changed. New session needs to be created."));
+ m_data->errorString = reason;
+ m_data->accountState = AccountState::Disabled;
+ emitFailed(reason);
+ return false;
+ }
+ case AccountTaskState::STATE_FAILED_SOFT: {
+ setStatus(tr("Encountered an error during authentication."));
+ m_data->errorString = reason;
+ m_data->accountState = AccountState::Errored;
+ emitFailed(reason);
+ return false;
+ }
+ case AccountTaskState::STATE_FAILED_HARD: {
+ setStatus(tr("Failed to authenticate. The session has expired."));
+ m_data->errorString = reason;
+ m_data->accountState = AccountState::Expired;
+ emitFailed(reason);
+ return false;
+ }
+ case AccountTaskState::STATE_FAILED_GONE: {
+ setStatus(tr("Failed to authenticate. The account no longer exists."));
+ m_data->errorString = reason;
+ m_data->accountState = AccountState::Gone;
+ emitFailed(reason);
+ return false;
+ }
+ default: {
+ setStatus(tr("..."));
+ QString error = tr("Unknown account task state: %1").arg(int(newState));
+ m_data->accountState = AccountState::Errored;
+ emitFailed(error);
+ return false;
+ }
+ }
+}
\ No newline at end of file
diff --git a/launcher/minecraft/auth/AuthFlow.h b/launcher/minecraft/auth/AuthFlow.h
new file mode 100644
index 000000000..d99deec3c
--- /dev/null
+++ b/launcher/minecraft/auth/AuthFlow.h
@@ -0,0 +1,45 @@
+#pragma once
+
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "minecraft/auth/AccountData.h"
+#include "minecraft/auth/AuthStep.h"
+#include "tasks/Task.h"
+
+class AuthFlow : public Task {
+ Q_OBJECT
+
+ public:
+ enum class Action { Refresh, Login, DeviceCode };
+
+ explicit AuthFlow(AccountData* data, Action action = Action::Refresh, QObject* parent = 0);
+ virtual ~AuthFlow() = default;
+
+ void executeTask() override;
+
+ AccountTaskState taskState() { return m_taskState; }
+
+ signals:
+ void authorizeWithBrowser(const QUrl& url);
+ void authorizeWithBrowserWithExtra(QString url, QString code, int expiresIn);
+
+ protected:
+ void succeed();
+ void nextStep();
+
+ private slots:
+ // NOTE: true -> non-terminal state, false -> terminal state
+ bool changeState(AccountTaskState newState, QString reason = QString());
+ void stepFinished(AccountTaskState resultingState, QString message);
+
+ private:
+ AccountTaskState m_taskState = AccountTaskState::STATE_CREATED;
+ QList m_steps;
+ AuthStep::Ptr m_currentStep;
+ AccountData* m_data = nullptr;
+};
diff --git a/launcher/minecraft/auth/AuthRequest.cpp b/launcher/minecraft/auth/AuthRequest.cpp
deleted file mode 100644
index 189978cc0..000000000
--- a/launcher/minecraft/auth/AuthRequest.cpp
+++ /dev/null
@@ -1,175 +0,0 @@
-// SPDX-License-Identifier: GPL-3.0-only
-/*
- * Prism Launcher - Minecraft Launcher
- * Copyright (C) 2022 Sefa Eyeoglu
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, version 3.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program. If not, see .
- *
- * This file incorporates work covered by the following copyright and
- * permission notice:
- *
- * Copyright 2013-2021 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#include
-
-#include
-#include
-#include
-#include
-
-#include "Application.h"
-#include "AuthRequest.h"
-#include "katabasis/Globals.h"
-
-AuthRequest::AuthRequest(QObject* parent) : QObject(parent) {}
-
-AuthRequest::~AuthRequest() {}
-
-void AuthRequest::get(const QNetworkRequest& req, int timeout /* = 60*1000*/)
-{
- setup(req, QNetworkAccessManager::GetOperation);
- reply_ = APPLICATION->network()->get(request_);
- status_ = Requesting;
- timedReplies_.add(new Katabasis::Reply(reply_, timeout));
-#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0) // QNetworkReply::errorOccurred added in 5.15
- connect(reply_, &QNetworkReply::errorOccurred, this, &AuthRequest::onRequestError);
-#else // &QNetworkReply::error SIGNAL depricated
- connect(reply_, QOverload::of(&QNetworkReply::error), this, &AuthRequest::onRequestError);
-#endif
- connect(reply_, &QNetworkReply::finished, this, &AuthRequest::onRequestFinished);
- connect(reply_, &QNetworkReply::sslErrors, this, &AuthRequest::onSslErrors);
-}
-
-void AuthRequest::post(const QNetworkRequest& req, const QByteArray& data, int timeout /* = 60*1000*/)
-{
- setup(req, QNetworkAccessManager::PostOperation);
- data_ = data;
- status_ = Requesting;
- reply_ = APPLICATION->network()->post(request_, data_);
- timedReplies_.add(new Katabasis::Reply(reply_, timeout));
-#if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0) // QNetworkReply::errorOccurred added in 5.15
- connect(reply_, &QNetworkReply::errorOccurred, this, &AuthRequest::onRequestError);
-#else // &QNetworkReply::error SIGNAL depricated
- connect(reply_, QOverload::of(&QNetworkReply::error), this, &AuthRequest::onRequestError);
-#endif
- connect(reply_, &QNetworkReply::finished, this, &AuthRequest::onRequestFinished);
- connect(reply_, &QNetworkReply::sslErrors, this, &AuthRequest::onSslErrors);
- connect(reply_, &QNetworkReply::uploadProgress, this, &AuthRequest::onUploadProgress);
-}
-
-void AuthRequest::onRequestFinished()
-{
- if (status_ == Idle) {
- return;
- }
- if (reply_ != qobject_cast(sender())) {
- return;
- }
- httpStatus_ = reply_->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt();
- finish();
-}
-
-void AuthRequest::onRequestError(QNetworkReply::NetworkError error)
-{
- qWarning() << "AuthRequest::onRequestError: Error" << (int)error;
- if (status_ == Idle) {
- return;
- }
- if (reply_ != qobject_cast(sender())) {
- return;
- }
- errorString_ = reply_->errorString();
- httpStatus_ = reply_->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt();
- error_ = error;
- qWarning() << "AuthRequest::onRequestError: Error string: " << errorString_;
- qWarning() << "AuthRequest::onRequestError: HTTP status" << httpStatus_
- << reply_->attribute(QNetworkRequest::HttpReasonPhraseAttribute).toString();
-
- // QTimer::singleShot(10, this, SLOT(finish()));
-}
-
-void AuthRequest::onSslErrors(QList errors)
-{
- int i = 1;
- for (auto error : errors) {
- qCritical() << "LOGIN SSL Error #" << i << " : " << error.errorString();
- auto cert = error.certificate();
- qCritical() << "Certificate in question:\n" << cert.toText();
- i++;
- }
-}
-
-void AuthRequest::onUploadProgress(qint64 uploaded, qint64 total)
-{
- if (status_ == Idle) {
- qWarning() << "AuthRequest::onUploadProgress: No pending request";
- return;
- }
- if (reply_ != qobject_cast(sender())) {
- return;
- }
- // Restart timeout because request in progress
- Katabasis::Reply* o2Reply = timedReplies_.find(reply_);
- if (o2Reply) {
- o2Reply->start();
- }
- emit uploadProgress(uploaded, total);
-}
-
-void AuthRequest::setup(const QNetworkRequest& req, QNetworkAccessManager::Operation operation, const QByteArray& verb)
-{
- request_ = req;
- operation_ = operation;
- url_ = req.url();
-
- QUrl url = url_;
- request_.setUrl(url);
-
- if (!verb.isEmpty()) {
- request_.setRawHeader(Katabasis::HTTP_HTTP_HEADER, verb);
- }
-
- status_ = Requesting;
- error_ = QNetworkReply::NoError;
- errorString_.clear();
- httpStatus_ = 0;
-}
-
-void AuthRequest::finish()
-{
- QByteArray data;
- if (status_ == Idle) {
- qWarning() << "AuthRequest::finish: No pending request";
- return;
- }
- data = reply_->readAll();
- status_ = Idle;
- timedReplies_.remove(reply_);
- reply_->disconnect(this);
- reply_->deleteLater();
- QList headers = reply_->rawHeaderPairs();
- emit finished(error_, data, headers);
-}
diff --git a/launcher/minecraft/auth/AuthRequest.h b/launcher/minecraft/auth/AuthRequest.h
deleted file mode 100644
index 84d2a7d68..000000000
--- a/launcher/minecraft/auth/AuthRequest.h
+++ /dev/null
@@ -1,67 +0,0 @@
-#pragma once
-#include
-#include
-#include
-#include
-#include
-#include
-
-#include "katabasis/Reply.h"
-
-/// Makes authentication requests.
-class AuthRequest : public QObject {
- Q_OBJECT
-
- public:
- explicit AuthRequest(QObject* parent = 0);
- ~AuthRequest();
-
- public slots:
- void get(const QNetworkRequest& req, int timeout = 60 * 1000);
- void post(const QNetworkRequest& req, const QByteArray& data, int timeout = 60 * 1000);
-
- signals:
-
- /// Emitted when a request has been completed or failed.
- void finished(QNetworkReply::NetworkError error, QByteArray data, QList headers);
-
- /// Emitted when an upload has progressed.
- void uploadProgress(qint64 bytesSent, qint64 bytesTotal);
-
- protected slots:
-
- /// Handle request finished.
- void onRequestFinished();
-
- /// Handle request error.
- void onRequestError(QNetworkReply::NetworkError error);
-
- /// Handle ssl errors.
- void onSslErrors(QList errors);
-
- /// Finish the request, emit finished() signal.
- void finish();
-
- /// Handle upload progress.
- void onUploadProgress(qint64 uploaded, qint64 total);
-
- public:
- QNetworkReply::NetworkError error_;
- int httpStatus_ = 0;
- QString errorString_;
-
- protected:
- void setup(const QNetworkRequest& request, QNetworkAccessManager::Operation operation, const QByteArray& verb = QByteArray());
-
- enum Status { Idle, Requesting, ReRequesting };
-
- QNetworkRequest request_;
- QByteArray data_;
- QNetworkReply* reply_;
- Status status_;
- QNetworkAccessManager::Operation operation_;
- QUrl url_;
- Katabasis::ReplyList timedReplies_;
-
- QTimer* timer_;
-};
diff --git a/launcher/minecraft/auth/AuthStep.cpp b/launcher/minecraft/auth/AuthStep.cpp
deleted file mode 100644
index 6240cc549..000000000
--- a/launcher/minecraft/auth/AuthStep.cpp
+++ /dev/null
@@ -1,5 +0,0 @@
-#include "AuthStep.h"
-
-AuthStep::AuthStep(AccountData* data) : QObject(nullptr), m_data(data) {}
-
-AuthStep::~AuthStep() noexcept = default;
diff --git a/launcher/minecraft/auth/AuthStep.h b/launcher/minecraft/auth/AuthStep.h
index becd9b0c5..4d2cf69c1 100644
--- a/launcher/minecraft/auth/AuthStep.h
+++ b/launcher/minecraft/auth/AuthStep.h
@@ -3,30 +3,40 @@
#include
#include
-#include "AccountTask.h"
#include "QObjectPtr.h"
#include "minecraft/auth/AccountData.h"
+/**
+ * Enum for describing the state of the current task.
+ * Used by the getStateMessage function to determine what the status message should be.
+ */
+enum class AccountTaskState {
+ STATE_CREATED,
+ STATE_WORKING,
+ STATE_SUCCEEDED,
+ STATE_DISABLED, //!< MSA Client ID has changed. Tell user to reloginn
+ STATE_FAILED_SOFT, //!< soft failure. authentication went through partially
+ STATE_FAILED_HARD, //!< hard failure. main tokens are invalid
+ STATE_FAILED_GONE, //!< hard failure. main tokens are invalid, and the account no longer exists
+ STATE_OFFLINE //!< soft failure. authentication failed in the first step in a 'soft' way
+};
+
class AuthStep : public QObject {
Q_OBJECT
public:
using Ptr = shared_qobject_ptr;
- public:
- explicit AuthStep(AccountData* data);
- virtual ~AuthStep() noexcept;
+ explicit AuthStep(AccountData* data) : QObject(nullptr), m_data(data){};
+ virtual ~AuthStep() noexcept = default;
virtual QString describe() = 0;
public slots:
virtual void perform() = 0;
- virtual void rehydrate() = 0;
signals:
void finished(AccountTaskState resultingState, QString message);
- void showVerificationUriAndCode(const QUrl& uri, const QString& code, int expiresIn);
- void hideVerificationUriAndCode();
protected:
AccountData* m_data;
diff --git a/launcher/minecraft/auth/MinecraftAccount.cpp b/launcher/minecraft/auth/MinecraftAccount.cpp
index ecee93d98..3c7129d5f 100644
--- a/launcher/minecraft/auth/MinecraftAccount.cpp
+++ b/launcher/minecraft/auth/MinecraftAccount.cpp
@@ -50,9 +50,8 @@
#include
-#include "flows/MSA.h"
-#include "flows/Offline.h"
#include "minecraft/auth/AccountData.h"
+#include "minecraft/auth/AuthFlow.h"
MinecraftAccount::MinecraftAccount(QObject* parent) : QObject(parent)
{
@@ -80,7 +79,7 @@ MinecraftAccountPtr MinecraftAccount::createOffline(const QString& username)
auto account = makeShared();
account->data.type = AccountType::Offline;
account->data.yggdrasilToken.token = "0";
- account->data.yggdrasilToken.validity = Katabasis::Validity::Certain;
+ account->data.yggdrasilToken.validity = Validity::Certain;
account->data.yggdrasilToken.issueInstant = QDateTime::currentDateTimeUtc();
account->data.yggdrasilToken.extra["userName"] = username;
account->data.yggdrasilToken.extra["clientToken"] = QUuid::createUuid().toString().remove(QRegularExpression("[{}-]"));
@@ -88,7 +87,7 @@ MinecraftAccountPtr MinecraftAccount::createOffline(const QString& username)
account->data.minecraftEntitlement.canPlayMinecraft = true;
account->data.minecraftProfile.id = uuidFromUsername(username).toString().remove(QRegularExpression("[{}-]"));
account->data.minecraftProfile.name = username;
- account->data.minecraftProfile.validity = Katabasis::Validity::Certain;
+ account->data.minecraftProfile.validity = Validity::Certain;
return account;
}
@@ -120,11 +119,11 @@ QPixmap MinecraftAccount::getFace() const
return skin.scaled(64, 64, Qt::KeepAspectRatio);
}
-shared_qobject_ptr MinecraftAccount::loginMSA()
+shared_qobject_ptr MinecraftAccount::login(bool useDeviceCode)
{
Q_ASSERT(m_currentTask.get() == nullptr);
- m_currentTask.reset(new MSAInteractive(&data));
+ m_currentTask.reset(new AuthFlow(&data, useDeviceCode ? AuthFlow::Action::DeviceCode : AuthFlow::Action::Login, this));
connect(m_currentTask.get(), &Task::succeeded, this, &MinecraftAccount::authSucceeded);
connect(m_currentTask.get(), &Task::failed, this, &MinecraftAccount::authFailed);
connect(m_currentTask.get(), &Task::aborted, this, [this] { authFailed(tr("Aborted")); });
@@ -132,29 +131,13 @@ shared_qobject_ptr MinecraftAccount::loginMSA()
return m_currentTask;
}
-shared_qobject_ptr MinecraftAccount::loginOffline()
-{
- Q_ASSERT(m_currentTask.get() == nullptr);
-
- m_currentTask.reset(new OfflineLogin(&data));
- connect(m_currentTask.get(), &Task::succeeded, this, &MinecraftAccount::authSucceeded);
- connect(m_currentTask.get(), &Task::failed, this, &MinecraftAccount::authFailed);
- connect(m_currentTask.get(), &Task::aborted, this, [this] { authFailed(tr("Aborted")); });
- emit activityChanged(true);
- return m_currentTask;
-}
-
-shared_qobject_ptr MinecraftAccount::refresh()
+shared_qobject_ptr MinecraftAccount::refresh()
{
if (m_currentTask) {
return m_currentTask;
}
- if (data.type == AccountType::MSA) {
- m_currentTask.reset(new MSASilent(&data));
- } else {
- m_currentTask.reset(new OfflineRefresh(&data));
- }
+ m_currentTask.reset(new AuthFlow(&data, AuthFlow::Action::Refresh, this));
connect(m_currentTask.get(), &Task::succeeded, this, &MinecraftAccount::authSucceeded);
connect(m_currentTask.get(), &Task::failed, this, &MinecraftAccount::authFailed);
@@ -163,7 +146,7 @@ shared_qobject_ptr MinecraftAccount::refresh()
return m_currentTask;
}
-shared_qobject_ptr MinecraftAccount::currentTask()
+shared_qobject_ptr MinecraftAccount::currentTask()
{
return m_currentTask;
}
@@ -189,17 +172,17 @@ void MinecraftAccount::authFailed(QString reason)
if (accountType() == AccountType::MSA) {
data.msaToken.token = QString();
data.msaToken.refresh_token = QString();
- data.msaToken.validity = Katabasis::Validity::None;
- data.validity_ = Katabasis::Validity::None;
+ data.msaToken.validity = Validity::None;
+ data.validity_ = Validity::None;
} else {
data.yggdrasilToken.token = QString();
- data.yggdrasilToken.validity = Katabasis::Validity::None;
- data.validity_ = Katabasis::Validity::None;
+ data.yggdrasilToken.validity = Validity::None;
+ data.validity_ = Validity::None;
}
emit changed();
} break;
case AccountTaskState::STATE_FAILED_GONE: {
- data.validity_ = Katabasis::Validity::None;
+ data.validity_ = Validity::None;
emit changed();
} break;
case AccountTaskState::STATE_CREATED:
@@ -229,13 +212,13 @@ bool MinecraftAccount::shouldRefresh() const
return false;
}
switch (data.validity_) {
- case Katabasis::Validity::Certain: {
+ case Validity::Certain: {
break;
}
- case Katabasis::Validity::None: {
+ case Validity::None: {
return false;
}
- case Katabasis::Validity::Assumed: {
+ case Validity::Assumed: {
return true;
}
}
diff --git a/launcher/minecraft/auth/MinecraftAccount.h b/launcher/minecraft/auth/MinecraftAccount.h
index f773b3bc9..b5c623a26 100644
--- a/launcher/minecraft/auth/MinecraftAccount.h
+++ b/launcher/minecraft/auth/MinecraftAccount.h
@@ -43,15 +43,13 @@
#include
#include
-#include
-
#include "AccountData.h"
#include "AuthSession.h"
#include "QObjectPtr.h"
#include "Usable.h"
+#include "minecraft/auth/AuthFlow.h"
class Task;
-class AccountTask;
class MinecraftAccount;
using MinecraftAccountPtr = shared_qobject_ptr;
@@ -97,13 +95,11 @@ class MinecraftAccount : public QObject, public Usable {
QJsonObject saveToJson() const;
public: /* manipulation */
- shared_qobject_ptr loginMSA();
+ shared_qobject_ptr login(bool useDeviceCode = false);
- shared_qobject_ptr loginOffline();
+ shared_qobject_ptr refresh();
- shared_qobject_ptr refresh();
-
- shared_qobject_ptr currentTask();
+ shared_qobject_ptr currentTask();
public: /* queries */
QString internalId() const { return data.internalId; }
@@ -166,7 +162,7 @@ class MinecraftAccount : public QObject, public Usable {
AccountData data;
// current task we are executing here
- shared_qobject_ptr m_currentTask;
+ shared_qobject_ptr m_currentTask;
protected: /* methods */
void incrementUses() override;
diff --git a/launcher/minecraft/auth/Parsers.cpp b/launcher/minecraft/auth/Parsers.cpp
index f6179a93e..a2b97e278 100644
--- a/launcher/minecraft/auth/Parsers.cpp
+++ b/launcher/minecraft/auth/Parsers.cpp
@@ -79,7 +79,7 @@ bool getBool(QJsonValue value, bool& out)
// 2148916238 = child account not linked to a family
*/
-bool parseXTokenResponse(QByteArray& data, Katabasis::Token& output, QString name)
+bool parseXTokenResponse(QByteArray& data, Token& output, QString name)
{
qDebug() << "Parsing" << name << ":";
qCDebug(authCredentials()) << data;
@@ -135,7 +135,7 @@ bool parseXTokenResponse(QByteArray& data, Katabasis::Token& output, QString nam
qWarning() << "Missing uhs";
return false;
}
- output.validity = Katabasis::Validity::Certain;
+ output.validity = Validity::Certain;
qDebug() << name << "is valid.";
return true;
}
@@ -213,7 +213,7 @@ bool parseMinecraftProfile(QByteArray& data, MinecraftProfile& output)
output.capes[capeOut.id] = capeOut;
}
output.currentCape = currentCape;
- output.validity = Katabasis::Validity::Certain;
+ output.validity = Validity::Certain;
return true;
}
@@ -388,7 +388,7 @@ bool parseMinecraftProfileMojang(QByteArray& data, MinecraftProfile& output)
output.currentCape = capeOut.alias;
}
- output.validity = Katabasis::Validity::Certain;
+ output.validity = Validity::Certain;
return true;
}
@@ -422,7 +422,7 @@ bool parseMinecraftEntitlements(QByteArray& data, MinecraftEntitlement& output)
output.ownsMinecraft = true;
}
}
- output.validity = Katabasis::Validity::Certain;
+ output.validity = Validity::Certain;
return true;
}
@@ -456,7 +456,7 @@ bool parseRolloutResponse(QByteArray& data, bool& result)
return true;
}
-bool parseMojangResponse(QByteArray& data, Katabasis::Token& output)
+bool parseMojangResponse(QByteArray& data, Token& output)
{
QJsonParseError jsonError;
qDebug() << "Parsing Mojang response...";
@@ -488,7 +488,7 @@ bool parseMojangResponse(QByteArray& data, Katabasis::Token& output)
qWarning() << "access_token is not valid";
return false;
}
- output.validity = Katabasis::Validity::Certain;
+ output.validity = Validity::Certain;
qDebug() << "Mojang response is valid.";
return true;
}
diff --git a/launcher/minecraft/auth/Parsers.h b/launcher/minecraft/auth/Parsers.h
index d073f9994..4a235e4c2 100644
--- a/launcher/minecraft/auth/Parsers.h
+++ b/launcher/minecraft/auth/Parsers.h
@@ -9,8 +9,8 @@ bool getNumber(QJsonValue value, double& out);
bool getNumber(QJsonValue value, int64_t& out);
bool getBool(QJsonValue value, bool& out);
-bool parseXTokenResponse(QByteArray& data, Katabasis::Token& output, QString name);
-bool parseMojangResponse(QByteArray& data, Katabasis::Token& output);
+bool parseXTokenResponse(QByteArray& data, Token& output, QString name);
+bool parseMojangResponse(QByteArray& data, Token& output);
bool parseMinecraftProfile(QByteArray& data, MinecraftProfile& output);
bool parseMinecraftProfileMojang(QByteArray& data, MinecraftProfile& output);
diff --git a/launcher/minecraft/auth/flows/AuthFlow.cpp b/launcher/minecraft/auth/flows/AuthFlow.cpp
deleted file mode 100644
index c51839a8c..000000000
--- a/launcher/minecraft/auth/flows/AuthFlow.cpp
+++ /dev/null
@@ -1,67 +0,0 @@
-#include
-#include
-#include
-#include
-
-#include "AuthFlow.h"
-#include "katabasis/Globals.h"
-
-#include
-
-AuthFlow::AuthFlow(AccountData* data, QObject* parent) : AccountTask(data, parent) {}
-
-void AuthFlow::succeed()
-{
- m_data->validity_ = Katabasis::Validity::Certain;
- changeState(AccountTaskState::STATE_SUCCEEDED, tr("Finished all authentication steps"));
-}
-
-void AuthFlow::executeTask()
-{
- if (m_currentStep) {
- return;
- }
- changeState(AccountTaskState::STATE_WORKING, tr("Initializing"));
- nextStep();
-}
-
-void AuthFlow::nextStep()
-{
- if (m_steps.size() == 0) {
- // we got to the end without an incident... assume this is all.
- m_currentStep.reset();
- succeed();
- return;
- }
- m_currentStep = m_steps.front();
- qDebug() << "AuthFlow:" << m_currentStep->describe();
- m_steps.pop_front();
- connect(m_currentStep.get(), &AuthStep::finished, this, &AuthFlow::stepFinished);
- connect(m_currentStep.get(), &AuthStep::showVerificationUriAndCode, this, &AuthFlow::showVerificationUriAndCode);
- connect(m_currentStep.get(), &AuthStep::hideVerificationUriAndCode, this, &AuthFlow::hideVerificationUriAndCode);
-
- m_currentStep->perform();
-}
-
-QString AuthFlow::getStateMessage() const
-{
- switch (m_taskState) {
- case AccountTaskState::STATE_WORKING: {
- if (m_currentStep) {
- return m_currentStep->describe();
- } else {
- return tr("Working...");
- }
- }
- default: {
- return AccountTask::getStateMessage();
- }
- }
-}
-
-void AuthFlow::stepFinished(AccountTaskState resultingState, QString message)
-{
- if (changeState(resultingState, message)) {
- nextStep();
- }
-}
diff --git a/launcher/minecraft/auth/flows/AuthFlow.h b/launcher/minecraft/auth/flows/AuthFlow.h
deleted file mode 100644
index e39e926dd..000000000
--- a/launcher/minecraft/auth/flows/AuthFlow.h
+++ /dev/null
@@ -1,41 +0,0 @@
-#pragma once
-
-#include
-#include
-#include
-#include
-#include
-#include
-
-#include
-
-#include "minecraft/auth/AccountData.h"
-#include "minecraft/auth/AccountTask.h"
-#include "minecraft/auth/AuthStep.h"
-
-class AuthFlow : public AccountTask {
- Q_OBJECT
-
- public:
- explicit AuthFlow(AccountData* data, QObject* parent = 0);
-
- Katabasis::Validity validity() { return m_data->validity_; };
-
- QString getStateMessage() const override;
-
- void executeTask() override;
-
- signals:
- void activityChanged(Katabasis::Activity activity);
-
- private slots:
- void stepFinished(AccountTaskState resultingState, QString message);
-
- protected:
- void succeed();
- void nextStep();
-
- protected:
- QList m_steps;
- AuthStep::Ptr m_currentStep;
-};
diff --git a/launcher/minecraft/auth/flows/MSA.cpp b/launcher/minecraft/auth/flows/MSA.cpp
deleted file mode 100644
index f0399342e..000000000
--- a/launcher/minecraft/auth/flows/MSA.cpp
+++ /dev/null
@@ -1,36 +0,0 @@
-#include "MSA.h"
-
-#include "minecraft/auth/steps/EntitlementsStep.h"
-#include "minecraft/auth/steps/GetSkinStep.h"
-#include "minecraft/auth/steps/LauncherLoginStep.h"
-#include "minecraft/auth/steps/MSAStep.h"
-#include "minecraft/auth/steps/MinecraftProfileStep.h"
-#include "minecraft/auth/steps/XboxAuthorizationStep.h"
-#include "minecraft/auth/steps/XboxProfileStep.h"
-#include "minecraft/auth/steps/XboxUserStep.h"
-
-MSASilent::MSASilent(AccountData* data, QObject* parent) : AuthFlow(data, parent)
-{
- m_steps.append(makeShared(m_data, MSAStep::Action::Refresh));
- m_steps.append(makeShared(m_data));
- m_steps.append(makeShared(m_data, &m_data->xboxApiToken, "http://xboxlive.com", "Xbox"));
- m_steps.append(makeShared(m_data, &m_data->mojangservicesToken, "rp://api.minecraftservices.com/", "Mojang"));
- m_steps.append(makeShared(m_data));
- m_steps.append(makeShared(m_data));
- m_steps.append(makeShared(m_data));
- m_steps.append(makeShared(m_data));
- m_steps.append(makeShared(m_data));
-}
-
-MSAInteractive::MSAInteractive(AccountData* data, QObject* parent) : AuthFlow(data, parent)
-{
- m_steps.append(makeShared(m_data, MSAStep::Action::Login));
- m_steps.append(makeShared(m_data));
- m_steps.append(makeShared(m_data, &m_data->xboxApiToken, "http://xboxlive.com", "Xbox"));
- m_steps.append(makeShared(m_data, &m_data->mojangservicesToken, "rp://api.minecraftservices.com/", "Mojang"));
- m_steps.append(makeShared(m_data));
- m_steps.append(makeShared(m_data));
- m_steps.append(makeShared(m_data));
- m_steps.append(makeShared(m_data));
- m_steps.append(makeShared(m_data));
-}
diff --git a/launcher/minecraft/auth/flows/MSA.h b/launcher/minecraft/auth/flows/MSA.h
deleted file mode 100644
index e403d530f..000000000
--- a/launcher/minecraft/auth/flows/MSA.h
+++ /dev/null
@@ -1,14 +0,0 @@
-#pragma once
-#include "AuthFlow.h"
-
-class MSAInteractive : public AuthFlow {
- Q_OBJECT
- public:
- explicit MSAInteractive(AccountData* data, QObject* parent = 0);
-};
-
-class MSASilent : public AuthFlow {
- Q_OBJECT
- public:
- explicit MSASilent(AccountData* data, QObject* parent = 0);
-};
diff --git a/launcher/minecraft/auth/flows/Offline.cpp b/launcher/minecraft/auth/flows/Offline.cpp
deleted file mode 100644
index 3770b869a..000000000
--- a/launcher/minecraft/auth/flows/Offline.cpp
+++ /dev/null
@@ -1,13 +0,0 @@
-#include "Offline.h"
-
-#include "minecraft/auth/steps/OfflineStep.h"
-
-OfflineRefresh::OfflineRefresh(AccountData* data, QObject* parent) : AuthFlow(data, parent)
-{
- m_steps.append(makeShared(m_data));
-}
-
-OfflineLogin::OfflineLogin(AccountData* data, QObject* parent) : AuthFlow(data, parent)
-{
- m_steps.append(makeShared(m_data));
-}
diff --git a/launcher/minecraft/auth/flows/Offline.h b/launcher/minecraft/auth/flows/Offline.h
deleted file mode 100644
index 2bc9c7612..000000000
--- a/launcher/minecraft/auth/flows/Offline.h
+++ /dev/null
@@ -1,14 +0,0 @@
-#pragma once
-#include "AuthFlow.h"
-
-class OfflineRefresh : public AuthFlow {
- Q_OBJECT
- public:
- explicit OfflineRefresh(AccountData* data, QObject* parent = 0);
-};
-
-class OfflineLogin : public AuthFlow {
- Q_OBJECT
- public:
- explicit OfflineLogin(AccountData* data, QObject* parent = 0);
-};
diff --git a/launcher/minecraft/auth/steps/EntitlementsStep.cpp b/launcher/minecraft/auth/steps/EntitlementsStep.cpp
index 0573dcb6e..19cbe6898 100644
--- a/launcher/minecraft/auth/steps/EntitlementsStep.cpp
+++ b/launcher/minecraft/auth/steps/EntitlementsStep.cpp
@@ -1,16 +1,20 @@
#include "EntitlementsStep.h"
+#include
#include
+#include
#include
+#include
+#include "Application.h"
#include "Logging.h"
-#include "minecraft/auth/AuthRequest.h"
#include "minecraft/auth/Parsers.h"
+#include "net/Download.h"
+#include "net/StaticHeaderProxy.h"
+#include "tasks/Task.h"
EntitlementsStep::EntitlementsStep(AccountData* data) : AuthStep(data) {}
-EntitlementsStep::~EntitlementsStep() noexcept = default;
-
QString EntitlementsStep::describe()
{
return tr("Determining game ownership.");
@@ -19,35 +23,31 @@ QString EntitlementsStep::describe()
void EntitlementsStep::perform()
{
auto uuid = QUuid::createUuid();
- m_entitlementsRequestId = uuid.toString().remove('{').remove('}');
- auto url = "https://api.minecraftservices.com/entitlements/license?requestId=" + m_entitlementsRequestId;
- QNetworkRequest request = QNetworkRequest(url);
- request.setHeader(QNetworkRequest::ContentTypeHeader, "application/json");
- request.setRawHeader("Accept", "application/json");
- request.setRawHeader("Authorization", QString("Bearer %1").arg(m_data->yggdrasilToken.token).toUtf8());
- AuthRequest* requestor = new AuthRequest(this);
- connect(requestor, &AuthRequest::finished, this, &EntitlementsStep::onRequestDone);
- requestor->get(request);
+ m_entitlements_request_id = uuid.toString().remove('{').remove('}');
+
+ QUrl url("https://api.minecraftservices.com/entitlements/license?requestId=" + m_entitlements_request_id);
+ auto headers = QList{ { "Content-Type", "application/json" },
+ { "Accept", "application/json" },
+ { "Authorization", QString("Bearer %1").arg(m_data->yggdrasilToken.token).toUtf8() } };
+
+ m_response.reset(new QByteArray());
+ m_task = Net::Download::makeByteArray(url, m_response);
+ m_task->addHeaderProxy(new Net::StaticHeaderProxy(headers));
+
+ connect(m_task.get(), &Task::finished, this, &EntitlementsStep::onRequestDone);
+
+ m_task->setNetwork(APPLICATION->network());
+ m_task->start();
qDebug() << "Getting entitlements...";
}
-void EntitlementsStep::rehydrate()
+void EntitlementsStep::onRequestDone()
{
- // NOOP, for now. We only save bools and there's nothing to check.
-}
-
-void EntitlementsStep::onRequestDone([[maybe_unused]] QNetworkReply::NetworkError error,
- QByteArray data,
- [[maybe_unused]] QList headers)
-{
- auto requestor = qobject_cast(QObject::sender());
- requestor->deleteLater();
-
- qCDebug(authCredentials()) << data;
+ qCDebug(authCredentials()) << *m_response;
// TODO: check presence of same entitlementsRequestId?
// TODO: validate JWTs?
- Parsers::parseMinecraftEntitlements(data, m_data->minecraftEntitlement);
+ Parsers::parseMinecraftEntitlements(*m_response, m_data->minecraftEntitlement);
emit finished(AccountTaskState::STATE_WORKING, tr("Got entitlements"));
}
diff --git a/launcher/minecraft/auth/steps/EntitlementsStep.h b/launcher/minecraft/auth/steps/EntitlementsStep.h
index be16bda13..dd8ec7aaa 100644
--- a/launcher/minecraft/auth/steps/EntitlementsStep.h
+++ b/launcher/minecraft/auth/steps/EntitlementsStep.h
@@ -1,24 +1,26 @@
#pragma once
#include
+#include
-#include "QObjectPtr.h"
#include "minecraft/auth/AuthStep.h"
+#include "net/Download.h"
class EntitlementsStep : public AuthStep {
Q_OBJECT
public:
explicit EntitlementsStep(AccountData* data);
- virtual ~EntitlementsStep() noexcept;
+ virtual ~EntitlementsStep() noexcept = default;
void perform() override;
- void rehydrate() override;
QString describe() override;
private slots:
- void onRequestDone(QNetworkReply::NetworkError, QByteArray, QList);
+ void onRequestDone();
private:
- QString m_entitlementsRequestId;
+ QString m_entitlements_request_id;
+ std::shared_ptr m_response;
+ Net::Download::Ptr m_task;
};
diff --git a/launcher/minecraft/auth/steps/GetSkinStep.cpp b/launcher/minecraft/auth/steps/GetSkinStep.cpp
index 520877020..d9785b16a 100644
--- a/launcher/minecraft/auth/steps/GetSkinStep.cpp
+++ b/launcher/minecraft/auth/steps/GetSkinStep.cpp
@@ -3,13 +3,10 @@
#include
-#include "minecraft/auth/AuthRequest.h"
-#include "minecraft/auth/Parsers.h"
+#include "Application.h"
GetSkinStep::GetSkinStep(AccountData* data) : AuthStep(data) {}
-GetSkinStep::~GetSkinStep() noexcept = default;
-
QString GetSkinStep::describe()
{
return tr("Getting skin.");
@@ -17,25 +14,20 @@ QString GetSkinStep::describe()
void GetSkinStep::perform()
{
- auto url = QUrl(m_data->minecraftProfile.skin.url);
- QNetworkRequest request = QNetworkRequest(url);
- AuthRequest* requestor = new AuthRequest(this);
- connect(requestor, &AuthRequest::finished, this, &GetSkinStep::onRequestDone);
- requestor->get(request);
+ QUrl url(m_data->minecraftProfile.skin.url);
+
+ m_response.reset(new QByteArray());
+ m_task = Net::Download::makeByteArray(url, m_response);
+
+ connect(m_task.get(), &Task::finished, this, &GetSkinStep::onRequestDone);
+
+ m_task->setNetwork(APPLICATION->network());
+ m_task->start();
}
-void GetSkinStep::rehydrate()
+void GetSkinStep::onRequestDone()
{
- // NOOP, for now.
-}
-
-void GetSkinStep::onRequestDone(QNetworkReply::NetworkError error, QByteArray data, QList headers)
-{
- auto requestor = qobject_cast(QObject::sender());
- requestor->deleteLater();
-
- if (error == QNetworkReply::NoError) {
- m_data->minecraftProfile.skin.data = data;
- }
+ if (m_task->error() == QNetworkReply::NoError)
+ m_data->minecraftProfile.skin.data = *m_response;
emit finished(AccountTaskState::STATE_SUCCEEDED, tr("Got skin"));
}
diff --git a/launcher/minecraft/auth/steps/GetSkinStep.h b/launcher/minecraft/auth/steps/GetSkinStep.h
index 105e497d1..fffd8be03 100644
--- a/launcher/minecraft/auth/steps/GetSkinStep.h
+++ b/launcher/minecraft/auth/steps/GetSkinStep.h
@@ -1,21 +1,25 @@
#pragma once
#include
+#include
-#include "QObjectPtr.h"
#include "minecraft/auth/AuthStep.h"
+#include "net/Download.h"
class GetSkinStep : public AuthStep {
Q_OBJECT
public:
explicit GetSkinStep(AccountData* data);
- virtual ~GetSkinStep() noexcept;
+ virtual ~GetSkinStep() noexcept = default;
void perform() override;
- void rehydrate() override;
QString describe() override;
private slots:
- void onRequestDone(QNetworkReply::NetworkError, QByteArray, QList);
+ void onRequestDone();
+
+ private:
+ std::shared_ptr m_response;
+ Net::Download::Ptr m_task;
};
diff --git a/launcher/minecraft/auth/steps/LauncherLoginStep.cpp b/launcher/minecraft/auth/steps/LauncherLoginStep.cpp
index c57f51113..d72346c74 100644
--- a/launcher/minecraft/auth/steps/LauncherLoginStep.cpp
+++ b/launcher/minecraft/auth/steps/LauncherLoginStep.cpp
@@ -1,17 +1,17 @@
#include "LauncherLoginStep.h"
#include
+#include
+#include "Application.h"
#include "Logging.h"
-#include "minecraft/auth/AccountTask.h"
-#include "minecraft/auth/AuthRequest.h"
#include "minecraft/auth/Parsers.h"
#include "net/NetUtils.h"
+#include "net/StaticHeaderProxy.h"
+#include "net/Upload.h"
LauncherLoginStep::LauncherLoginStep(AccountData* data) : AuthStep(data) {}
-LauncherLoginStep::~LauncherLoginStep() noexcept = default;
-
QString LauncherLoginStep::describe()
{
return tr("Accessing Mojang services.");
@@ -19,7 +19,7 @@ QString LauncherLoginStep::describe()
void LauncherLoginStep::perform()
{
- auto requestURL = "https://api.minecraftservices.com/launcher/login";
+ QUrl url("https://api.minecraftservices.com/launcher/login");
auto uhs = m_data->mojangservicesToken.extra["uhs"].toString();
auto xToken = m_data->mojangservicesToken.token;
@@ -31,40 +31,37 @@ void LauncherLoginStep::perform()
)XXX";
auto requestBody = mc_auth_template.arg(uhs, xToken);
- QNetworkRequest request = QNetworkRequest(QUrl(requestURL));
- request.setHeader(QNetworkRequest::ContentTypeHeader, "application/json");
- request.setRawHeader("Accept", "application/json");
- AuthRequest* requestor = new AuthRequest(this);
- connect(requestor, &AuthRequest::finished, this, &LauncherLoginStep::onRequestDone);
- requestor->post(request, requestBody.toUtf8());
+ auto headers = QList{
+ { "Content-Type", "application/json" },
+ { "Accept", "application/json" },
+ };
+
+ m_response.reset(new QByteArray());
+ m_task = Net::Upload::makeByteArray(url, m_response, requestBody.toUtf8());
+ m_task->addHeaderProxy(new Net::StaticHeaderProxy(headers));
+
+ connect(m_task.get(), &Task::finished, this, &LauncherLoginStep::onRequestDone);
+
+ m_task->setNetwork(APPLICATION->network());
+ m_task->start();
qDebug() << "Getting Minecraft access token...";
}
-void LauncherLoginStep::rehydrate()
+void LauncherLoginStep::onRequestDone()
{
- // TODO: check the token validity
-}
-
-void LauncherLoginStep::onRequestDone(QNetworkReply::NetworkError error, QByteArray data, QList headers)
-{
- auto requestor = qobject_cast(QObject::sender());
- requestor->deleteLater();
-
- qCDebug(authCredentials()) << data;
- if (error != QNetworkReply::NoError) {
- qWarning() << "Reply error:" << error;
- qCDebug(authCredentials()) << data;
- if (Net::isApplicationError(error)) {
- emit finished(AccountTaskState::STATE_FAILED_SOFT, tr("Failed to get Minecraft access token: %1").arg(requestor->errorString_));
+ qCDebug(authCredentials()) << *m_response;
+ if (m_task->error() != QNetworkReply::NoError) {
+ qWarning() << "Reply error:" << m_task->error();
+ if (Net::isApplicationError(m_task->error())) {
+ emit finished(AccountTaskState::STATE_FAILED_SOFT, tr("Failed to get Minecraft access token: %1").arg(m_task->errorString()));
} else {
- emit finished(AccountTaskState::STATE_OFFLINE, tr("Failed to get Minecraft access token: %1").arg(requestor->errorString_));
+ emit finished(AccountTaskState::STATE_OFFLINE, tr("Failed to get Minecraft access token: %1").arg(m_task->errorString()));
}
return;
}
- if (!Parsers::parseMojangResponse(data, m_data->yggdrasilToken)) {
+ if (!Parsers::parseMojangResponse(*m_response, m_data->yggdrasilToken)) {
qWarning() << "Could not parse login_with_xbox response...";
- qCDebug(authCredentials()) << data;
emit finished(AccountTaskState::STATE_FAILED_SOFT, tr("Failed to parse the Minecraft access token response."));
return;
}
diff --git a/launcher/minecraft/auth/steps/LauncherLoginStep.h b/launcher/minecraft/auth/steps/LauncherLoginStep.h
index 30c18e675..21a2a4920 100644
--- a/launcher/minecraft/auth/steps/LauncherLoginStep.h
+++ b/launcher/minecraft/auth/steps/LauncherLoginStep.h
@@ -1,21 +1,25 @@
#pragma once
#include
+#include
-#include "QObjectPtr.h"
#include "minecraft/auth/AuthStep.h"
+#include "net/Upload.h"
class LauncherLoginStep : public AuthStep {
Q_OBJECT
public:
explicit LauncherLoginStep(AccountData* data);
- virtual ~LauncherLoginStep() noexcept;
+ virtual ~LauncherLoginStep() noexcept = default;
void perform() override;
- void rehydrate() override;
QString describe() override;
private slots:
- void onRequestDone(QNetworkReply::NetworkError, QByteArray, QList);
+ void onRequestDone();
+
+ private:
+ std::shared_ptr m_response;
+ Net::Upload::Ptr m_task;
};
diff --git a/launcher/minecraft/auth/steps/MSADeviceCodeStep.cpp b/launcher/minecraft/auth/steps/MSADeviceCodeStep.cpp
new file mode 100644
index 000000000..22f5d4069
--- /dev/null
+++ b/launcher/minecraft/auth/steps/MSADeviceCodeStep.cpp
@@ -0,0 +1,270 @@
+// SPDX-License-Identifier: GPL-3.0-only
+/*
+ * Prism Launcher - Minecraft Launcher
+ * Copyright (c) 2024 Trial97
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see .
+ *
+ * This file incorporates work covered by the following copyright and
+ * permission notice:
+ *
+ * Copyright 2013-2021 MultiMC Contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "MSADeviceCodeStep.h"
+
+#include
+#include
+
+#include "Application.h"
+#include "Json.h"
+#include "net/StaticHeaderProxy.h"
+
+// https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-device-code
+MSADeviceCodeStep::MSADeviceCodeStep(AccountData* data) : AuthStep(data)
+{
+ m_clientId = APPLICATION->getMSAClientID();
+}
+
+QString MSADeviceCodeStep::describe()
+{
+ return tr("Logging in with Microsoft account(device code).");
+}
+
+void MSADeviceCodeStep::perform()
+{
+ QUrlQuery data;
+ data.addQueryItem("client_id", m_clientId);
+ data.addQueryItem("scope", "XboxLive.SignIn XboxLive.offline_access");
+ auto payload = data.query(QUrl::FullyEncoded).toUtf8();
+ QUrl url("https://login.microsoftonline.com/consumers/oauth2/v2.0/devicecode");
+ auto headers = QList{
+ { "Content-Type", "application/x-www-form-urlencoded" },
+ { "Accept", "application/json" },
+ };
+ m_response.reset(new QByteArray());
+ m_task = Net::Upload::makeByteArray(url, m_response, payload);
+ m_task->addHeaderProxy(new Net::StaticHeaderProxy(headers));
+
+ connect(m_task.get(), &Task::finished, this, &MSADeviceCodeStep::deviceAutorizationFinished);
+
+ m_task->setNetwork(APPLICATION->network());
+ m_task->start();
+}
+
+struct DeviceAutorizationResponse {
+ QString device_code;
+ QString user_code;
+ QString verification_uri;
+ int expires_in;
+ int interval;
+
+ QString error;
+ QString error_description;
+};
+
+DeviceAutorizationResponse parseDeviceAutorizationResponse(const QByteArray& data)
+{
+ QJsonParseError err;
+ QJsonDocument doc = QJsonDocument::fromJson(data, &err);
+ if (err.error != QJsonParseError::NoError) {
+ qWarning() << "Failed to parse device autorization response due to err:" << err.errorString();
+ return {};
+ }
+
+ if (!doc.isObject()) {
+ qWarning() << "Device autorization response is not an object";
+ return {};
+ }
+ auto obj = doc.object();
+ return {
+ Json::ensureString(obj, "device_code"), Json::ensureString(obj, "user_code"), Json::ensureString(obj, "verification_uri"),
+ Json::ensureInteger(obj, "expires_in"), Json::ensureInteger(obj, "interval"), Json::ensureString(obj, "error"),
+ Json::ensureString(obj, "error_description"),
+ };
+}
+
+void MSADeviceCodeStep::deviceAutorizationFinished()
+{
+ auto rsp = parseDeviceAutorizationResponse(*m_response);
+ if (!rsp.error.isEmpty() || !rsp.error_description.isEmpty()) {
+ qWarning() << "Device authorization failed:" << rsp.error;
+ emit finished(AccountTaskState::STATE_FAILED_HARD,
+ tr("Device authorization failed: %1").arg(rsp.error_description.isEmpty() ? rsp.error : rsp.error_description));
+ return;
+ }
+ if (!m_task->wasSuccessful() || m_task->error() != QNetworkReply::NoError) {
+ emit finished(AccountTaskState::STATE_FAILED_HARD, tr("Failed to retrieve device authorization"));
+ qDebug() << *m_response;
+ return;
+ }
+
+ if (rsp.device_code.isEmpty() || rsp.user_code.isEmpty() || rsp.verification_uri.isEmpty() || rsp.expires_in == 0) {
+ emit finished(AccountTaskState::STATE_FAILED_HARD, tr("Device authorization failed: required fields missing"));
+ return;
+ }
+ if (rsp.interval != 0) {
+ interval = rsp.interval;
+ }
+ m_device_code = rsp.device_code;
+ emit authorizeWithBrowser(rsp.verification_uri, rsp.user_code, rsp.expires_in);
+ m_expiration_timer.setTimerType(Qt::VeryCoarseTimer);
+ m_expiration_timer.setInterval(rsp.expires_in * 1000);
+ m_expiration_timer.setSingleShot(true);
+ connect(&m_expiration_timer, &QTimer::timeout, this, &MSADeviceCodeStep::abort);
+ m_expiration_timer.start();
+
+ m_pool_timer.setTimerType(Qt::VeryCoarseTimer);
+ m_pool_timer.setSingleShot(true);
+ startPoolTimer();
+}
+
+void MSADeviceCodeStep::abort()
+{
+ m_expiration_timer.stop();
+ m_pool_timer.stop();
+ if (m_task) {
+ m_task->abort();
+ }
+ m_is_aborted = true;
+ emit finished(AccountTaskState::STATE_FAILED_HARD, tr("Task aborted"));
+}
+
+void MSADeviceCodeStep::startPoolTimer()
+{
+ if (m_is_aborted) {
+ return;
+ }
+ m_pool_timer.setInterval(interval * 1000);
+ connect(&m_pool_timer, &QTimer::timeout, this, &MSADeviceCodeStep::authenticateUser);
+ m_pool_timer.start();
+}
+
+void MSADeviceCodeStep::authenticateUser()
+{
+ QUrlQuery data;
+ data.addQueryItem("client_id", m_clientId);
+ data.addQueryItem("grant_type", "urn:ietf:params:oauth:grant-type:device_code");
+ data.addQueryItem("device_code", m_device_code);
+ auto payload = data.query(QUrl::FullyEncoded).toUtf8();
+ QUrl url("https://login.microsoftonline.com/consumers/oauth2/v2.0/token");
+ auto headers = QList{
+ { "Content-Type", "application/x-www-form-urlencoded" },
+ { "Accept", "application/json" },
+ };
+ m_response.reset(new QByteArray());
+ m_task = Net::Upload::makeByteArray(url, m_response, payload);
+ m_task->addHeaderProxy(new Net::StaticHeaderProxy(headers));
+
+ connect(m_task.get(), &Task::finished, this, &MSADeviceCodeStep::authenticationFinished);
+
+ m_task->setNetwork(APPLICATION->network());
+ m_task->start();
+}
+
+struct AuthenticationResponse {
+ QString access_token;
+ QString token_type;
+ QString refresh_token;
+ int expires_in;
+
+ QString error;
+ QString error_description;
+
+ QVariantMap extra;
+};
+
+AuthenticationResponse parseAuthenticationResponse(const QByteArray& data)
+{
+ QJsonParseError err;
+ QJsonDocument doc = QJsonDocument::fromJson(data, &err);
+ if (err.error != QJsonParseError::NoError) {
+ qWarning() << "Failed to parse device autorization response due to err:" << err.errorString();
+ return {};
+ }
+
+ if (!doc.isObject()) {
+ qWarning() << "Device autorization response is not an object";
+ return {};
+ }
+ auto obj = doc.object();
+ return { Json::ensureString(obj, "access_token"),
+ Json::ensureString(obj, "token_type"),
+ Json::ensureString(obj, "refresh_token"),
+ Json::ensureInteger(obj, "expires_in"),
+ Json::ensureString(obj, "error"),
+ Json::ensureString(obj, "error_description"),
+ obj.toVariantMap() };
+}
+
+void MSADeviceCodeStep::authenticationFinished()
+{
+ if (m_task->error() == QNetworkReply::TimeoutError) {
+ // rfc8628#section-3.5
+ // "On encountering a connection timeout, clients MUST unilaterally
+ // reduce their polling frequency before retrying. The use of an
+ // exponential backoff algorithm to achieve this, such as doubling the
+ // polling interval on each such connection timeout, is RECOMMENDED."
+ interval *= 2;
+ startPoolTimer();
+ return;
+ }
+ auto rsp = parseAuthenticationResponse(*m_response);
+ if (rsp.error == "slow_down") {
+ // rfc8628#section-3.5
+ // "A variant of 'authorization_pending', the authorization request is
+ // still pending and polling should continue, but the interval MUST
+ // be increased by 5 seconds for this and all subsequent requests."
+ interval += 5;
+ startPoolTimer();
+ return;
+ }
+ if (rsp.error == "authorization_pending") {
+ // keep trying - rfc8628#section-3.5
+ // "The authorization request is still pending as the end user hasn't
+ // yet completed the user-interaction steps (Section 3.3)."
+ startPoolTimer();
+ return;
+ }
+ if (!rsp.error.isEmpty() || !rsp.error_description.isEmpty()) {
+ qWarning() << "Device Access failed:" << rsp.error;
+ emit finished(AccountTaskState::STATE_FAILED_HARD,
+ tr("Device Access failed: %1").arg(rsp.error_description.isEmpty() ? rsp.error : rsp.error_description));
+ return;
+ }
+ if (!m_task->wasSuccessful() || m_task->error() != QNetworkReply::NoError) {
+ startPoolTimer(); // it failed so just try again without increasing the interval
+ return;
+ }
+
+ m_expiration_timer.stop();
+ m_data->msaClientID = m_clientId;
+ m_data->msaToken.issueInstant = QDateTime::currentDateTimeUtc();
+ m_data->msaToken.notAfter = QDateTime::currentDateTime().addSecs(rsp.expires_in);
+ m_data->msaToken.extra = rsp.extra;
+ m_data->msaToken.refresh_token = rsp.refresh_token;
+ m_data->msaToken.token = rsp.access_token;
+ emit finished(AccountTaskState::STATE_WORKING, tr("Got"));
+}
\ No newline at end of file
diff --git a/launcher/minecraft/auth/steps/MSADeviceCodeStep.h b/launcher/minecraft/auth/steps/MSADeviceCodeStep.h
new file mode 100644
index 000000000..e53eebc62
--- /dev/null
+++ b/launcher/minecraft/auth/steps/MSADeviceCodeStep.h
@@ -0,0 +1,76 @@
+// SPDX-License-Identifier: GPL-3.0-only
+/*
+ * Prism Launcher - Minecraft Launcher
+ * Copyright (c) 2024 Trial97
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see .
+ *
+ * This file incorporates work covered by the following copyright and
+ * permission notice:
+ *
+ * Copyright 2013-2021 MultiMC Contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+#include
+#include
+
+#include "minecraft/auth/AuthStep.h"
+#include "net/Upload.h"
+
+class MSADeviceCodeStep : public AuthStep {
+ Q_OBJECT
+ public:
+ explicit MSADeviceCodeStep(AccountData* data);
+ virtual ~MSADeviceCodeStep() noexcept = default;
+
+ void perform() override;
+
+ QString describe() override;
+
+ public slots:
+ void abort();
+
+ signals:
+ void authorizeWithBrowser(QString url, QString code, int expiresIn);
+
+ private slots:
+ void deviceAutorizationFinished();
+ void startPoolTimer();
+ void authenticateUser();
+ void authenticationFinished();
+
+ private:
+ QString m_clientId;
+ QString m_device_code;
+ bool m_is_aborted = false;
+ int interval = 5;
+
+ QTimer m_pool_timer;
+ QTimer m_expiration_timer;
+
+ std::shared_ptr m_response;
+ Net::Upload::Ptr m_task;
+};
diff --git a/launcher/minecraft/auth/steps/MSAStep.cpp b/launcher/minecraft/auth/steps/MSAStep.cpp
index 1aa22765d..3f31cdc16 100644
--- a/launcher/minecraft/auth/steps/MSAStep.cpp
+++ b/launcher/minecraft/auth/steps/MSAStep.cpp
@@ -35,123 +35,74 @@
#include "MSAStep.h"
+#include
+#include
#include
-#include "BuildConfig.h"
-#include "minecraft/auth/AuthRequest.h"
-#include "minecraft/auth/Parsers.h"
-
#include "Application.h"
-#include "Logging.h"
-using OAuth2 = Katabasis::DeviceFlow;
-using Activity = Katabasis::Activity;
-
-MSAStep::MSAStep(AccountData* data, Action action) : AuthStep(data), m_action(action)
+MSAStep::MSAStep(AccountData* data, bool silent) : AuthStep(data), m_silent(silent)
{
m_clientId = APPLICATION->getMSAClientID();
- OAuth2::Options opts;
- opts.scope = "XboxLive.signin offline_access";
- opts.clientIdentifier = m_clientId;
- opts.authorizationUrl = "https://login.microsoftonline.com/consumers/oauth2/v2.0/devicecode";
- opts.accessTokenUrl = "https://login.microsoftonline.com/consumers/oauth2/v2.0/token";
- // FIXME: OAuth2 is not aware of our fancy shared pointers
- m_oauth2 = new OAuth2(opts, m_data->msaToken, this, APPLICATION->network().get());
+ auto replyHandler = new QOAuthHttpServerReplyHandler(1337, this);
+ replyHandler->setCallbackText(
+ " ");
+ oauth2.setReplyHandler(replyHandler);
+ oauth2.setAuthorizationUrl(QUrl("https://login.microsoftonline.com/consumers/oauth2/v2.0/authorize"));
+ oauth2.setAccessTokenUrl(QUrl("https://login.microsoftonline.com/consumers/oauth2/v2.0/token"));
+ oauth2.setScope("XboxLive.SignIn XboxLive.offline_access");
+ oauth2.setClientIdentifier(m_clientId);
+ oauth2.setNetworkAccessManager(APPLICATION->network().get());
- connect(m_oauth2, &OAuth2::activityChanged, this, &MSAStep::onOAuthActivityChanged);
- connect(m_oauth2, &OAuth2::showVerificationUriAndCode, this, &MSAStep::showVerificationUriAndCode);
+ connect(&oauth2, &QOAuth2AuthorizationCodeFlow::granted, this, [this] {
+ m_data->msaClientID = oauth2.clientIdentifier();
+ m_data->msaToken.issueInstant = QDateTime::currentDateTimeUtc();
+ m_data->msaToken.notAfter = oauth2.expirationAt();
+ m_data->msaToken.extra = oauth2.extraTokens();
+ m_data->msaToken.refresh_token = oauth2.refreshToken();
+ m_data->msaToken.token = oauth2.token();
+ emit finished(AccountTaskState::STATE_WORKING, tr("Got "));
+ });
+ connect(&oauth2, &QOAuth2AuthorizationCodeFlow::authorizeWithBrowser, this, &MSAStep::authorizeWithBrowser);
+ connect(&oauth2, &QOAuth2AuthorizationCodeFlow::requestFailed, this, [this](const QAbstractOAuth2::Error err) {
+ emit finished(AccountTaskState::STATE_FAILED_HARD, tr("Microsoft user authentication failed."));
+ });
+
+ connect(&oauth2, &QOAuth2AuthorizationCodeFlow::extraTokensChanged, this,
+ [this](const QVariantMap& tokens) { m_data->msaToken.extra = tokens; });
+
+ connect(&oauth2, &QOAuth2AuthorizationCodeFlow::clientIdentifierChanged, this,
+ [this](const QString& clientIdentifier) { m_data->msaClientID = clientIdentifier; });
}
-MSAStep::~MSAStep() noexcept = default;
-
QString MSAStep::describe()
{
return tr("Logging in with Microsoft account.");
}
-void MSAStep::rehydrate()
-{
- switch (m_action) {
- case Refresh: {
- // TODO: check the tokens and see if they are old (older than a day)
- return;
- }
- case Login: {
- // NOOP
- return;
- }
- }
-}
-
void MSAStep::perform()
{
- switch (m_action) {
- case Refresh: {
- if (m_data->msaClientID != m_clientId) {
- emit hideVerificationUriAndCode();
- emit finished(AccountTaskState::STATE_DISABLED,
- tr("Microsoft user authentication failed - client identification has changed."));
- }
- m_oauth2->refresh();
- return;
+ if (m_silent) {
+ if (m_data->msaClientID != m_clientId) {
+ emit finished(AccountTaskState::STATE_DISABLED,
+ tr("Microsoft user authentication failed - client identification has changed."));
}
- case Login: {
- QVariantMap extraOpts;
- extraOpts["prompt"] = "select_account";
- m_oauth2->setExtraRequestParams(extraOpts);
+ oauth2.setRefreshToken(m_data->msaToken.refresh_token);
+ oauth2.refreshAccessToken();
+ } else {
+#if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) // QMultiMap param changed in 6.0
+ oauth2.setModifyParametersFunction([](QAbstractOAuth::Stage stage, QMultiMap* map) {
+#else
+ oauth2.setModifyParametersFunction([](QAbstractOAuth::Stage stage, QMap* map) {
+#endif
+ map->insert("prompt", "select_account");
+ });
- *m_data = AccountData();
- m_data->msaClientID = m_clientId;
- m_oauth2->login();
- return;
- }
- }
-}
-
-void MSAStep::onOAuthActivityChanged(Katabasis::Activity activity)
-{
- switch (activity) {
- case Katabasis::Activity::Idle:
- case Katabasis::Activity::LoggingIn:
- case Katabasis::Activity::Refreshing:
- case Katabasis::Activity::LoggingOut: {
- // We asked it to do something, it's doing it. Nothing to act upon.
- return;
- }
- case Katabasis::Activity::Succeeded: {
- // Succeeded or did not invalidate tokens
- emit hideVerificationUriAndCode();
- QVariantMap extraTokens = m_oauth2->extraTokens();
- if (!extraTokens.isEmpty()) {
- qCDebug(authCredentials()) << "Extra tokens in response:";
- foreach (QString key, extraTokens.keys()) {
- qCDebug(authCredentials()) << "\t" << key << ":" << extraTokens.value(key);
- }
- }
- emit finished(AccountTaskState::STATE_WORKING, tr("Got "));
- return;
- }
- case Katabasis::Activity::FailedSoft: {
- // NOTE: soft error in the first step means 'offline'
- emit hideVerificationUriAndCode();
- emit finished(AccountTaskState::STATE_OFFLINE, tr("Microsoft user authentication ended with a network error."));
- return;
- }
- case Katabasis::Activity::FailedGone: {
- emit hideVerificationUriAndCode();
- emit finished(AccountTaskState::STATE_FAILED_GONE, tr("Microsoft user authentication failed - user no longer exists."));
- return;
- }
- case Katabasis::Activity::FailedHard: {
- emit hideVerificationUriAndCode();
- emit finished(AccountTaskState::STATE_FAILED_HARD, tr("Microsoft user authentication failed."));
- return;
- }
- default: {
- emit hideVerificationUriAndCode();
- emit finished(AccountTaskState::STATE_FAILED_HARD, tr("Microsoft user authentication completed with an unrecognized result."));
- return;
- }
+ *m_data = AccountData();
+ m_data->msaClientID = m_clientId;
+ oauth2.grant();
}
}
diff --git a/launcher/minecraft/auth/steps/MSAStep.h b/launcher/minecraft/auth/steps/MSAStep.h
index b6635d4a5..675cfb2ca 100644
--- a/launcher/minecraft/auth/steps/MSAStep.h
+++ b/launcher/minecraft/auth/steps/MSAStep.h
@@ -36,30 +36,24 @@
#pragma once
#include
-#include "QObjectPtr.h"
#include "minecraft/auth/AuthStep.h"
-#include
-
+#include
class MSAStep : public AuthStep {
Q_OBJECT
public:
- enum Action { Refresh, Login };
-
- public:
- explicit MSAStep(AccountData* data, Action action);
- virtual ~MSAStep() noexcept;
+ explicit MSAStep(AccountData* data, bool silent = false);
+ virtual ~MSAStep() noexcept = default;
void perform() override;
- void rehydrate() override;
QString describe() override;
- private slots:
- void onOAuthActivityChanged(Katabasis::Activity activity);
+ signals:
+ void authorizeWithBrowser(const QUrl& url);
private:
- Katabasis::DeviceFlow* m_oauth2 = nullptr;
- Action m_action;
+ bool m_silent;
QString m_clientId;
+ QOAuth2AuthorizationCodeFlow oauth2;
};
diff --git a/launcher/minecraft/auth/steps/MinecraftProfileStep.cpp b/launcher/minecraft/auth/steps/MinecraftProfileStep.cpp
index a854342bc..305f44320 100644
--- a/launcher/minecraft/auth/steps/MinecraftProfileStep.cpp
+++ b/launcher/minecraft/auth/steps/MinecraftProfileStep.cpp
@@ -2,15 +2,13 @@
#include
-#include "Logging.h"
-#include "minecraft/auth/AuthRequest.h"
+#include "Application.h"
#include "minecraft/auth/Parsers.h"
#include "net/NetUtils.h"
+#include "net/StaticHeaderProxy.h"
MinecraftProfileStep::MinecraftProfileStep(AccountData* data) : AuthStep(data) {}
-MinecraftProfileStep::~MinecraftProfileStep() noexcept = default;
-
QString MinecraftProfileStep::describe()
{
return tr("Fetching the Minecraft profile.");
@@ -18,52 +16,47 @@ QString MinecraftProfileStep::describe()
void MinecraftProfileStep::perform()
{
- auto url = QUrl("https://api.minecraftservices.com/minecraft/profile");
- QNetworkRequest request = QNetworkRequest(url);
- request.setHeader(QNetworkRequest::ContentTypeHeader, "application/json");
- request.setRawHeader("Authorization", QString("Bearer %1").arg(m_data->yggdrasilToken.token).toUtf8());
+ QUrl url("https://api.minecraftservices.com/minecraft/profile");
+ auto headers = QList{ { "Content-Type", "application/json" },
+ { "Accept", "application/json" },
+ { "Authorization", QString("Bearer %1").arg(m_data->yggdrasilToken.token).toUtf8() } };
- AuthRequest* requestor = new AuthRequest(this);
- connect(requestor, &AuthRequest::finished, this, &MinecraftProfileStep::onRequestDone);
- requestor->get(request);
+ m_response.reset(new QByteArray());
+ m_task = Net::Download::makeByteArray(url, m_response);
+ m_task->addHeaderProxy(new Net::StaticHeaderProxy(headers));
+
+ connect(m_task.get(), &Task::finished, this, &MinecraftProfileStep::onRequestDone);
+
+ m_task->setNetwork(APPLICATION->network());
+ m_task->start();
}
-void MinecraftProfileStep::rehydrate()
+void MinecraftProfileStep::onRequestDone()
{
- // NOOP, for now. We only save bools and there's nothing to check.
-}
-
-void MinecraftProfileStep::onRequestDone(QNetworkReply::NetworkError error, QByteArray data, QList headers)
-{
- auto requestor = qobject_cast(QObject::sender());
- requestor->deleteLater();
-
- qCDebug(authCredentials()) << data;
- if (error == QNetworkReply::ContentNotFoundError) {
+ if (m_task->error() == QNetworkReply::ContentNotFoundError) {
// NOTE: Succeed even if we do not have a profile. This is a valid account state.
m_data->minecraftProfile = MinecraftProfile();
emit finished(AccountTaskState::STATE_SUCCEEDED, tr("Account has no Minecraft profile."));
return;
}
- if (error != QNetworkReply::NoError) {
+ if (m_task->error() != QNetworkReply::NoError) {
qWarning() << "Error getting profile:";
- qWarning() << " HTTP Status: " << requestor->httpStatus_;
- qWarning() << " Internal error no.: " << error;
- qWarning() << " Error string: " << requestor->errorString_;
+ qWarning() << " HTTP Status: " << m_task->replyStatusCode();
+ qWarning() << " Internal error no.: " << m_task->error();
+ qWarning() << " Error string: " << m_task->errorString();
qWarning() << " Response:";
- qWarning() << QString::fromUtf8(data);
+ qWarning() << QString::fromUtf8(*m_response);
- if (Net::isApplicationError(error)) {
+ if (Net::isApplicationError(m_task->error())) {
emit finished(AccountTaskState::STATE_FAILED_SOFT,
- tr("Minecraft Java profile acquisition failed: %1").arg(requestor->errorString_));
+ tr("Minecraft Java profile acquisition failed: %1").arg(m_task->errorString()));
} else {
- emit finished(AccountTaskState::STATE_OFFLINE,
- tr("Minecraft Java profile acquisition failed: %1").arg(requestor->errorString_));
+ emit finished(AccountTaskState::STATE_OFFLINE, tr("Minecraft Java profile acquisition failed: %1").arg(m_task->errorString()));
}
return;
}
- if (!Parsers::parseMinecraftProfile(data, m_data->minecraftProfile)) {
+ if (!Parsers::parseMinecraftProfile(*m_response, m_data->minecraftProfile)) {
m_data->minecraftProfile = MinecraftProfile();
emit finished(AccountTaskState::STATE_FAILED_SOFT, tr("Minecraft Java profile response could not be parsed"));
return;
diff --git a/launcher/minecraft/auth/steps/MinecraftProfileStep.h b/launcher/minecraft/auth/steps/MinecraftProfileStep.h
index cb30dab21..831cd52f7 100644
--- a/launcher/minecraft/auth/steps/MinecraftProfileStep.h
+++ b/launcher/minecraft/auth/steps/MinecraftProfileStep.h
@@ -1,21 +1,25 @@
#pragma once
#include
+#include
-#include "QObjectPtr.h"
#include "minecraft/auth/AuthStep.h"
+#include "net/Download.h"
class MinecraftProfileStep : public AuthStep {
Q_OBJECT
public:
explicit MinecraftProfileStep(AccountData* data);
- virtual ~MinecraftProfileStep() noexcept;
+ virtual ~MinecraftProfileStep() noexcept = default;
void perform() override;
- void rehydrate() override;
QString describe() override;
private slots:
- void onRequestDone(QNetworkReply::NetworkError, QByteArray, QList);
+ void onRequestDone();
+
+ private:
+ std::shared_ptr m_response;
+ Net::Download::Ptr m_task;
};
diff --git a/launcher/minecraft/auth/steps/OfflineStep.cpp b/launcher/minecraft/auth/steps/OfflineStep.cpp
deleted file mode 100644
index bf111abe8..000000000
--- a/launcher/minecraft/auth/steps/OfflineStep.cpp
+++ /dev/null
@@ -1,21 +0,0 @@
-#include "OfflineStep.h"
-
-#include "Application.h"
-
-OfflineStep::OfflineStep(AccountData* data) : AuthStep(data) {}
-OfflineStep::~OfflineStep() noexcept = default;
-
-QString OfflineStep::describe()
-{
- return tr("Creating offline account.");
-}
-
-void OfflineStep::rehydrate()
-{
- // NOOP
-}
-
-void OfflineStep::perform()
-{
- emit finished(AccountTaskState::STATE_WORKING, tr("Created offline account."));
-}
diff --git a/launcher/minecraft/auth/steps/OfflineStep.h b/launcher/minecraft/auth/steps/OfflineStep.h
deleted file mode 100644
index 3bf123d6a..000000000
--- a/launcher/minecraft/auth/steps/OfflineStep.h
+++ /dev/null
@@ -1,19 +0,0 @@
-#pragma once
-#include
-
-#include "QObjectPtr.h"
-#include "minecraft/auth/AuthStep.h"
-
-#include
-
-class OfflineStep : public AuthStep {
- Q_OBJECT
- public:
- explicit OfflineStep(AccountData* data);
- virtual ~OfflineStep() noexcept;
-
- void perform() override;
- void rehydrate() override;
-
- QString describe() override;
-};
diff --git a/launcher/minecraft/auth/steps/XboxAuthorizationStep.cpp b/launcher/minecraft/auth/steps/XboxAuthorizationStep.cpp
index 84c52c386..f07220986 100644
--- a/launcher/minecraft/auth/steps/XboxAuthorizationStep.cpp
+++ b/launcher/minecraft/auth/steps/XboxAuthorizationStep.cpp
@@ -4,27 +4,22 @@
#include
#include
+#include "Application.h"
#include "Logging.h"
-#include "minecraft/auth/AuthRequest.h"
#include "minecraft/auth/Parsers.h"
#include "net/NetUtils.h"
+#include "net/StaticHeaderProxy.h"
+#include "net/Upload.h"
-XboxAuthorizationStep::XboxAuthorizationStep(AccountData* data, Katabasis::Token* token, QString relyingParty, QString authorizationKind)
+XboxAuthorizationStep::XboxAuthorizationStep(AccountData* data, Token* token, QString relyingParty, QString authorizationKind)
: AuthStep(data), m_token(token), m_relyingParty(relyingParty), m_authorizationKind(authorizationKind)
{}
-XboxAuthorizationStep::~XboxAuthorizationStep() noexcept = default;
-
QString XboxAuthorizationStep::describe()
{
return tr("Getting authorization to access %1 services.").arg(m_authorizationKind);
}
-void XboxAuthorizationStep::rehydrate()
-{
- // FIXME: check if the tokens are good?
-}
-
void XboxAuthorizationStep::perform()
{
QString xbox_auth_template = R"XXX(
@@ -41,40 +36,44 @@ void XboxAuthorizationStep::perform()
)XXX";
auto xbox_auth_data = xbox_auth_template.arg(m_data->userToken.token, m_relyingParty);
// http://xboxlive.com
- QNetworkRequest request = QNetworkRequest(QUrl("https://xsts.auth.xboxlive.com/xsts/authorize"));
- request.setHeader(QNetworkRequest::ContentTypeHeader, "application/json");
- request.setRawHeader("Accept", "application/json");
- AuthRequest* requestor = new AuthRequest(this);
- connect(requestor, &AuthRequest::finished, this, &XboxAuthorizationStep::onRequestDone);
- requestor->post(request, xbox_auth_data.toUtf8());
+ QUrl url("https://xsts.auth.xboxlive.com/xsts/authorize");
+ auto headers = QList{
+ { "Content-Type", "application/json" },
+ { "Accept", "application/json" },
+ };
+ m_response.reset(new QByteArray());
+ m_task = Net::Upload::makeByteArray(url, m_response, xbox_auth_data.toUtf8());
+ m_task->addHeaderProxy(new Net::StaticHeaderProxy(headers));
+
+ connect(m_task.get(), &Task::finished, this, &XboxAuthorizationStep::onRequestDone);
+
+ m_task->setNetwork(APPLICATION->network());
+ m_task->start();
qDebug() << "Getting authorization token for " << m_relyingParty;
}
-void XboxAuthorizationStep::onRequestDone(QNetworkReply::NetworkError error, QByteArray data, QList headers)
+void XboxAuthorizationStep::onRequestDone()
{
- auto requestor = qobject_cast(QObject::sender());
- requestor->deleteLater();
-
- qCDebug(authCredentials()) << data;
- if (error != QNetworkReply::NoError) {
- qWarning() << "Reply error:" << error;
- if (Net::isApplicationError(error)) {
- if (!processSTSError(error, data, headers)) {
+ qCDebug(authCredentials()) << *m_response;
+ if (m_task->error() != QNetworkReply::NoError) {
+ qWarning() << "Reply error:" << m_task->error();
+ if (Net::isApplicationError(m_task->error())) {
+ if (!processSTSError()) {
emit finished(AccountTaskState::STATE_FAILED_SOFT,
- tr("Failed to get authorization for %1 services. Error %2.").arg(m_authorizationKind, error));
+ tr("Failed to get authorization for %1 services. Error %2.").arg(m_authorizationKind, m_task->error()));
} else {
emit finished(AccountTaskState::STATE_FAILED_SOFT,
- tr("Unknown STS error for %1 services: %2").arg(m_authorizationKind, requestor->errorString_));
+ tr("Unknown STS error for %1 services: %2").arg(m_authorizationKind, m_task->errorString()));
}
} else {
emit finished(AccountTaskState::STATE_OFFLINE,
- tr("Failed to get authorization for %1 services: %2").arg(m_authorizationKind, requestor->errorString_));
+ tr("Failed to get authorization for %1 services: %2").arg(m_authorizationKind, m_task->errorString()));
}
return;
}
- Katabasis::Token temp;
- if (!Parsers::parseXTokenResponse(data, temp, m_authorizationKind)) {
+ Token temp;
+ if (!Parsers::parseXTokenResponse(*m_response, temp, m_authorizationKind)) {
emit finished(AccountTaskState::STATE_FAILED_SOFT,
tr("Could not parse authorization response for access to %1 services.").arg(m_authorizationKind));
return;
@@ -91,11 +90,11 @@ void XboxAuthorizationStep::onRequestDone(QNetworkReply::NetworkError error, QBy
emit finished(AccountTaskState::STATE_WORKING, tr("Got authorization to access %1").arg(m_relyingParty));
}
-bool XboxAuthorizationStep::processSTSError(QNetworkReply::NetworkError error, QByteArray data, QList headers)
+bool XboxAuthorizationStep::processSTSError()
{
- if (error == QNetworkReply::AuthenticationRequiredError) {
+ if (m_task->error() == QNetworkReply::AuthenticationRequiredError) {
QJsonParseError jsonError;
- QJsonDocument doc = QJsonDocument::fromJson(data, &jsonError);
+ QJsonDocument doc = QJsonDocument::fromJson(*m_response, &jsonError);
if (jsonError.error) {
qWarning() << "Cannot parse error XSTS response as JSON: " << jsonError.errorString();
emit finished(AccountTaskState::STATE_FAILED_SOFT,
diff --git a/launcher/minecraft/auth/steps/XboxAuthorizationStep.h b/launcher/minecraft/auth/steps/XboxAuthorizationStep.h
index dee24c954..f6329b7f0 100644
--- a/launcher/minecraft/auth/steps/XboxAuthorizationStep.h
+++ b/launcher/minecraft/auth/steps/XboxAuthorizationStep.h
@@ -1,29 +1,32 @@
#pragma once
#include
+#include
-#include "QObjectPtr.h"
#include "minecraft/auth/AuthStep.h"
+#include "net/Upload.h"
class XboxAuthorizationStep : public AuthStep {
Q_OBJECT
public:
- explicit XboxAuthorizationStep(AccountData* data, Katabasis::Token* token, QString relyingParty, QString authorizationKind);
- virtual ~XboxAuthorizationStep() noexcept;
+ explicit XboxAuthorizationStep(AccountData* data, Token* token, QString relyingParty, QString authorizationKind);
+ virtual ~XboxAuthorizationStep() noexcept = default;
void perform() override;
- void rehydrate() override;
QString describe() override;
private:
- bool processSTSError(QNetworkReply::NetworkError error, QByteArray data, QList headers);
+ bool processSTSError();
private slots:
- void onRequestDone(QNetworkReply::NetworkError, QByteArray, QList);
+ void onRequestDone();
private:
- Katabasis::Token* m_token;
+ Token* m_token;
QString m_relyingParty;
QString m_authorizationKind;
+
+ std::shared_ptr m_response;
+ Net::Upload::Ptr m_task;
};
diff --git a/launcher/minecraft/auth/steps/XboxProfileStep.cpp b/launcher/minecraft/auth/steps/XboxProfileStep.cpp
index fd2b32cce..440a4657c 100644
--- a/launcher/minecraft/auth/steps/XboxProfileStep.cpp
+++ b/launcher/minecraft/auth/steps/XboxProfileStep.cpp
@@ -3,28 +3,21 @@
#include
#include
+#include "Application.h"
#include "Logging.h"
-#include "minecraft/auth/AuthRequest.h"
-#include "minecraft/auth/Parsers.h"
#include "net/NetUtils.h"
+#include "net/StaticHeaderProxy.h"
XboxProfileStep::XboxProfileStep(AccountData* data) : AuthStep(data) {}
-XboxProfileStep::~XboxProfileStep() noexcept = default;
-
QString XboxProfileStep::describe()
{
return tr("Fetching Xbox profile.");
}
-void XboxProfileStep::rehydrate()
-{
- // NOOP, for now. We only save bools and there's nothing to check.
-}
-
void XboxProfileStep::perform()
{
- auto url = QUrl("https://profile.xboxlive.com/users/me/profile/settings");
+ QUrl url("https://profile.xboxlive.com/users/me/profile/settings");
QUrlQuery q;
q.addQueryItem("settings",
"GameDisplayName,AppDisplayName,AppDisplayPicRaw,GameDisplayPicRaw,"
@@ -33,36 +26,38 @@ void XboxProfileStep::perform()
"PreferredColor,Location,Bio,Watermarks,"
"RealName,RealNameOverride,IsQuarantined");
url.setQuery(q);
+ auto headers = QList{
+ { "Content-Type", "application/json" },
+ { "Accept", "application/json" },
+ { "x-xbl-contract-version", "3" },
+ { "Authorization", QString("XBL3.0 x=%1;%2").arg(m_data->userToken.extra["uhs"].toString(), m_data->xboxApiToken.token).toUtf8() }
+ };
- QNetworkRequest request = QNetworkRequest(url);
- request.setHeader(QNetworkRequest::ContentTypeHeader, "application/json");
- request.setRawHeader("Accept", "application/json");
- request.setRawHeader("x-xbl-contract-version", "3");
- request.setRawHeader("Authorization",
- QString("XBL3.0 x=%1;%2").arg(m_data->userToken.extra["uhs"].toString(), m_data->xboxApiToken.token).toUtf8());
- AuthRequest* requestor = new AuthRequest(this);
- connect(requestor, &AuthRequest::finished, this, &XboxProfileStep::onRequestDone);
- requestor->get(request);
+ m_response.reset(new QByteArray());
+ m_task = Net::Download::makeByteArray(url, m_response);
+ m_task->addHeaderProxy(new Net::StaticHeaderProxy(headers));
+
+ connect(m_task.get(), &Task::finished, this, &XboxProfileStep::onRequestDone);
+
+ m_task->setNetwork(APPLICATION->network());
+ m_task->start();
qDebug() << "Getting Xbox profile...";
}
-void XboxProfileStep::onRequestDone(QNetworkReply::NetworkError error, QByteArray data, QList headers)
+void XboxProfileStep::onRequestDone()
{
- auto requestor = qobject_cast(QObject::sender());
- requestor->deleteLater();
-
- if (error != QNetworkReply::NoError) {
- qWarning() << "Reply error:" << error;
- qCDebug(authCredentials()) << data;
- if (Net::isApplicationError(error)) {
- emit finished(AccountTaskState::STATE_FAILED_SOFT, tr("Failed to retrieve the Xbox profile: %1").arg(requestor->errorString_));
+ if (m_task->error() != QNetworkReply::NoError) {
+ qWarning() << "Reply error:" << m_task->error();
+ qCDebug(authCredentials()) << *m_response;
+ if (Net::isApplicationError(m_task->error())) {
+ emit finished(AccountTaskState::STATE_FAILED_SOFT, tr("Failed to retrieve the Xbox profile: %1").arg(m_task->errorString()));
} else {
- emit finished(AccountTaskState::STATE_OFFLINE, tr("Failed to retrieve the Xbox profile: %1").arg(requestor->errorString_));
+ emit finished(AccountTaskState::STATE_OFFLINE, tr("Failed to retrieve the Xbox profile: %1").arg(m_task->errorString()));
}
return;
}
- qCDebug(authCredentials()) << "XBox profile: " << data;
+ qCDebug(authCredentials()) << "XBox profile: " << *m_response;
emit finished(AccountTaskState::STATE_WORKING, tr("Got Xbox profile"));
}
diff --git a/launcher/minecraft/auth/steps/XboxProfileStep.h b/launcher/minecraft/auth/steps/XboxProfileStep.h
index b8494b6e5..dfa273d9c 100644
--- a/launcher/minecraft/auth/steps/XboxProfileStep.h
+++ b/launcher/minecraft/auth/steps/XboxProfileStep.h
@@ -1,21 +1,25 @@
#pragma once
#include
+#include
-#include "QObjectPtr.h"
#include "minecraft/auth/AuthStep.h"
+#include "net/Download.h"
class XboxProfileStep : public AuthStep {
Q_OBJECT
public:
explicit XboxProfileStep(AccountData* data);
- virtual ~XboxProfileStep() noexcept;
+ virtual ~XboxProfileStep() noexcept = default;
void perform() override;
- void rehydrate() override;
QString describe() override;
private slots:
- void onRequestDone(QNetworkReply::NetworkError, QByteArray, QList);
+ void onRequestDone();
+
+ private:
+ std::shared_ptr m_response;
+ Net::Download::Ptr m_task;
};
diff --git a/launcher/minecraft/auth/steps/XboxUserStep.cpp b/launcher/minecraft/auth/steps/XboxUserStep.cpp
index 856036d23..c9453dba1 100644
--- a/launcher/minecraft/auth/steps/XboxUserStep.cpp
+++ b/launcher/minecraft/auth/steps/XboxUserStep.cpp
@@ -2,24 +2,18 @@
#include
-#include "minecraft/auth/AuthRequest.h"
+#include "Application.h"
#include "minecraft/auth/Parsers.h"
#include "net/NetUtils.h"
+#include "net/StaticHeaderProxy.h"
XboxUserStep::XboxUserStep(AccountData* data) : AuthStep(data) {}
-XboxUserStep::~XboxUserStep() noexcept = default;
-
QString XboxUserStep::describe()
{
return tr("Logging in as an Xbox user.");
}
-void XboxUserStep::rehydrate()
-{
- // NOOP, for now. We only save bools and there's nothing to check.
-}
-
void XboxUserStep::perform()
{
QString xbox_auth_template = R"XXX(
@@ -35,36 +29,39 @@ void XboxUserStep::perform()
)XXX";
auto xbox_auth_data = xbox_auth_template.arg(m_data->msaToken.token);
- QNetworkRequest request = QNetworkRequest(QUrl("https://user.auth.xboxlive.com/user/authenticate"));
- request.setHeader(QNetworkRequest::ContentTypeHeader, "application/json");
- request.setRawHeader("Accept", "application/json");
- // set contract-version header (prevent err 400 bad-request?)
- // https://learn.microsoft.com/en-us/gaming/gdk/_content/gc/reference/live/rest/additional/httpstandardheaders
- request.setRawHeader("x-xbl-contract-version", "1");
+ QUrl url("https://user.auth.xboxlive.com/user/authenticate");
+ auto headers = QList{
+ { "Content-Type", "application/json" },
+ { "Accept", "application/json" },
+ // set contract-version header (prevent err 400 bad-request?)
+ // https://learn.microsoft.com/en-us/gaming/gdk/_content/gc/reference/live/rest/additional/httpstandardheaders
+ { "x-xbl-contract-version", "1" }
+ };
+ m_response.reset(new QByteArray());
+ m_task = Net::Upload::makeByteArray(url, m_response, xbox_auth_data.toUtf8());
+ m_task->addHeaderProxy(new Net::StaticHeaderProxy(headers));
- auto* requestor = new AuthRequest(this);
- connect(requestor, &AuthRequest::finished, this, &XboxUserStep::onRequestDone);
- requestor->post(request, xbox_auth_data.toUtf8());
+ connect(m_task.get(), &Task::finished, this, &XboxUserStep::onRequestDone);
+
+ m_task->setNetwork(APPLICATION->network());
+ m_task->start();
qDebug() << "First layer of XBox auth ... commencing.";
}
-void XboxUserStep::onRequestDone(QNetworkReply::NetworkError error, QByteArray data, QList headers)
+void XboxUserStep::onRequestDone()
{
- auto requestor = qobject_cast(QObject::sender());
- requestor->deleteLater();
-
- if (error != QNetworkReply::NoError) {
- qWarning() << "Reply error:" << error;
- if (Net::isApplicationError(error)) {
- emit finished(AccountTaskState::STATE_FAILED_SOFT, tr("XBox user authentication failed: %1").arg(requestor->errorString_));
+ if (m_task->error() != QNetworkReply::NoError) {
+ qWarning() << "Reply error:" << m_task->error();
+ if (Net::isApplicationError(m_task->error())) {
+ emit finished(AccountTaskState::STATE_FAILED_SOFT, tr("XBox user authentication failed: %1").arg(m_task->errorString()));
} else {
- emit finished(AccountTaskState::STATE_OFFLINE, tr("XBox user authentication failed: %1").arg(requestor->errorString_));
+ emit finished(AccountTaskState::STATE_OFFLINE, tr("XBox user authentication failed: %1").arg(m_task->errorString()));
}
return;
}
- Katabasis::Token temp;
- if (!Parsers::parseXTokenResponse(data, temp, "UToken")) {
+ Token temp;
+ if (!Parsers::parseXTokenResponse(*m_response, temp, "UToken")) {
qWarning() << "Could not parse user authentication response...";
emit finished(AccountTaskState::STATE_FAILED_SOFT, tr("XBox user authentication response could not be understood."));
return;
diff --git a/launcher/minecraft/auth/steps/XboxUserStep.h b/launcher/minecraft/auth/steps/XboxUserStep.h
index e92727a4d..934a00c52 100644
--- a/launcher/minecraft/auth/steps/XboxUserStep.h
+++ b/launcher/minecraft/auth/steps/XboxUserStep.h
@@ -1,21 +1,25 @@
#pragma once
#include
+#include
-#include "QObjectPtr.h"
#include "minecraft/auth/AuthStep.h"
+#include "net/Upload.h"
class XboxUserStep : public AuthStep {
Q_OBJECT
public:
explicit XboxUserStep(AccountData* data);
- virtual ~XboxUserStep() noexcept;
+ virtual ~XboxUserStep() noexcept = default;
void perform() override;
- void rehydrate() override;
QString describe() override;
private slots:
- void onRequestDone(QNetworkReply::NetworkError, QByteArray, QList);
+ void onRequestDone();
+
+ private:
+ std::shared_ptr m_response;
+ Net::Upload::Ptr m_task;
};
diff --git a/launcher/minecraft/mod/Mod.cpp b/launcher/minecraft/mod/Mod.cpp
index e89131034..75ad8cfa3 100644
--- a/launcher/minecraft/mod/Mod.cpp
+++ b/launcher/minecraft/mod/Mod.cpp
@@ -334,7 +334,7 @@ QPixmap Mod::icon(QSize size, Qt::AspectRatioMode mode) const
return {};
if (m_pack_image_cache_key.was_ever_used) {
- qDebug() << "Mod" << name() << "Had it's icon evicted form the cache. reloading...";
+ qDebug() << "Mod" << name() << "Had it's icon evicted from the cache. reloading...";
PixmapCache::markCacheMissByEviciton();
}
// Image got evicted from the cache or an attempt to load it has not been made. load it and retry.
diff --git a/launcher/minecraft/mod/ResourceFolderModel.cpp b/launcher/minecraft/mod/ResourceFolderModel.cpp
index 61d5c24e0..35fce6ade 100644
--- a/launcher/minecraft/mod/ResourceFolderModel.cpp
+++ b/launcher/minecraft/mod/ResourceFolderModel.cpp
@@ -284,7 +284,12 @@ void ResourceFolderModel::resolveResource(Resource* res)
connect(
task.get(), &Task::failed, this, [=] { onParseFailed(ticket, res->internal_id()); }, Qt::ConnectionType::QueuedConnection);
connect(
- task.get(), &Task::finished, this, [=] { m_active_parse_tasks.remove(ticket); }, Qt::ConnectionType::QueuedConnection);
+ task.get(), &Task::finished, this,
+ [=] {
+ m_active_parse_tasks.remove(ticket);
+ emit parseFinished();
+ },
+ Qt::ConnectionType::QueuedConnection);
m_helper_thread_task.addTask(task);
@@ -621,3 +626,26 @@ QString ResourceFolderModel::instDirPath() const
{
return QFileInfo(m_instance->instanceRoot()).absoluteFilePath();
}
+
+void ResourceFolderModel::onParseFailed(int ticket, QString resource_id)
+{
+ auto iter = m_active_parse_tasks.constFind(ticket);
+ if (iter == m_active_parse_tasks.constEnd())
+ return;
+
+ auto removed_index = m_resources_index[resource_id];
+ auto removed_it = m_resources.begin() + removed_index;
+ Q_ASSERT(removed_it != m_resources.end());
+
+ beginRemoveRows(QModelIndex(), removed_index, removed_index);
+ m_resources.erase(removed_it);
+
+ // update index
+ m_resources_index.clear();
+ int idx = 0;
+ for (auto const& mod : qAsConst(m_resources)) {
+ m_resources_index[mod->internal_id()] = idx;
+ idx++;
+ }
+ endRemoveRows();
+}
diff --git a/launcher/minecraft/mod/ResourceFolderModel.h b/launcher/minecraft/mod/ResourceFolderModel.h
index fd27596f1..5ed698c67 100644
--- a/launcher/minecraft/mod/ResourceFolderModel.h
+++ b/launcher/minecraft/mod/ResourceFolderModel.h
@@ -143,6 +143,7 @@ class ResourceFolderModel : public QAbstractListModel {
signals:
void updateFinished();
+ void parseFinished();
protected:
/** This creates a new update task to be executed by update().
@@ -189,11 +190,7 @@ class ResourceFolderModel : public QAbstractListModel {
* if the resource is complex and has more stuff to parse.
*/
virtual void onParseSucceeded(int ticket, QString resource_id);
- virtual void onParseFailed(int ticket, QString resource_id)
- {
- Q_UNUSED(ticket);
- Q_UNUSED(resource_id);
- }
+ virtual void onParseFailed(int ticket, QString resource_id);
protected:
// Represents the relationship between a column's index (represented by the list index), and it's sorting key.
diff --git a/launcher/minecraft/mod/ShaderPack.cpp b/launcher/minecraft/mod/ShaderPack.cpp
index 2c094f26a..ccb344cb5 100644
--- a/launcher/minecraft/mod/ShaderPack.cpp
+++ b/launcher/minecraft/mod/ShaderPack.cpp
@@ -35,8 +35,3 @@ bool ShaderPack::valid() const
{
return m_pack_format != ShaderPackFormat::INVALID;
}
-
-bool ShaderPack::applyFilter(QRegularExpression filter) const
-{
- return valid() && Resource::applyFilter(filter);
-}
diff --git a/launcher/minecraft/mod/ShaderPack.h b/launcher/minecraft/mod/ShaderPack.h
index d07c124be..ec0f9404e 100644
--- a/launcher/minecraft/mod/ShaderPack.h
+++ b/launcher/minecraft/mod/ShaderPack.h
@@ -54,7 +54,6 @@ class ShaderPack : public Resource {
void setPackFormat(ShaderPackFormat new_format);
bool valid() const override;
- [[nodiscard]] bool applyFilter(QRegularExpression filter) const override;
protected:
mutable QMutex m_data_lock;
diff --git a/launcher/minecraft/mod/tasks/LocalModParseTask.cpp b/launcher/minecraft/mod/tasks/LocalModParseTask.cpp
index 3982f3338..60257ce0c 100644
--- a/launcher/minecraft/mod/tasks/LocalModParseTask.cpp
+++ b/launcher/minecraft/mod/tasks/LocalModParseTask.cpp
@@ -746,7 +746,7 @@ void LocalModParseTask::executeTask()
m_result->details = mod.details();
if (m_aborted)
- emit finished();
+ emitAborted();
else
emitSucceeded();
}
diff --git a/launcher/minecraft/mod/tasks/LocalResourcePackParseTask.cpp b/launcher/minecraft/mod/tasks/LocalResourcePackParseTask.cpp
index 26bc07637..f495c9b8d 100644
--- a/launcher/minecraft/mod/tasks/LocalResourcePackParseTask.cpp
+++ b/launcher/minecraft/mod/tasks/LocalResourcePackParseTask.cpp
@@ -286,8 +286,10 @@ bool LocalResourcePackParseTask::abort()
void LocalResourcePackParseTask::executeTask()
{
- if (!ResourcePackUtils::process(m_resource_pack))
+ if (!ResourcePackUtils::process(m_resource_pack)) {
+ emitFailed("this is not a resource pack");
return;
+ }
if (m_aborted)
emitAborted();
diff --git a/launcher/minecraft/mod/tasks/LocalShaderPackParseTask.cpp b/launcher/minecraft/mod/tasks/LocalShaderPackParseTask.cpp
index a9949735b..4deebcd1d 100644
--- a/launcher/minecraft/mod/tasks/LocalShaderPackParseTask.cpp
+++ b/launcher/minecraft/mod/tasks/LocalShaderPackParseTask.cpp
@@ -103,8 +103,10 @@ bool LocalShaderPackParseTask::abort()
void LocalShaderPackParseTask::executeTask()
{
- if (!ShaderPackUtils::process(m_shader_pack))
+ if (!ShaderPackUtils::process(m_shader_pack)) {
+ emitFailed("this is not a shader pack");
return;
+ }
if (m_aborted)
emitAborted();
diff --git a/launcher/minecraft/mod/tasks/LocalTexturePackParseTask.cpp b/launcher/minecraft/mod/tasks/LocalTexturePackParseTask.cpp
index d7e61ca90..00cc2def2 100644
--- a/launcher/minecraft/mod/tasks/LocalTexturePackParseTask.cpp
+++ b/launcher/minecraft/mod/tasks/LocalTexturePackParseTask.cpp
@@ -241,8 +241,10 @@ bool LocalTexturePackParseTask::abort()
void LocalTexturePackParseTask::executeTask()
{
- if (!TexturePackUtils::process(m_texture_pack))
+ if (!TexturePackUtils::process(m_texture_pack)) {
+ emitFailed("this is not a texture pack");
return;
+ }
if (m_aborted)
emitAborted();
diff --git a/launcher/modplatform/atlauncher/ATLPackInstallTask.cpp b/launcher/modplatform/atlauncher/ATLPackInstallTask.cpp
index 8ae8145de..01de88b04 100644
--- a/launcher/modplatform/atlauncher/ATLPackInstallTask.cpp
+++ b/launcher/modplatform/atlauncher/ATLPackInstallTask.cpp
@@ -1031,6 +1031,12 @@ void PackInstallTask::install()
return;
components->setComponentVersion("net.minecraftforge", version);
+ } else if (m_version.loader.type == QString("neoforge")) {
+ auto version = getVersionForLoader("net.neoforged");
+ if (version == Q_NULLPTR)
+ return;
+
+ components->setComponentVersion("net.neoforged", version);
} else if (m_version.loader.type == QString("fabric")) {
auto version = getVersionForLoader("net.fabricmc.fabric-loader");
if (version == Q_NULLPTR)
diff --git a/launcher/modplatform/flame/FlameInstanceCreationTask.cpp b/launcher/modplatform/flame/FlameInstanceCreationTask.cpp
index ef552c3c2..a1f10c156 100644
--- a/launcher/modplatform/flame/FlameInstanceCreationTask.cpp
+++ b/launcher/modplatform/flame/FlameInstanceCreationTask.cpp
@@ -537,7 +537,12 @@ void FlameCreationTask::setupDownloadJob(QEventLoop& loop)
selectedOptionalMods = optionalModDialog.getResult();
}
for (const auto& result : results) {
- auto relpath = FS::PathCombine(result.targetFolder, result.fileName);
+ auto fileName = result.fileName;
+#ifdef Q_OS_WIN
+ fileName = FS::RemoveInvalidPathChars(fileName);
+#endif
+ auto relpath = FS::PathCombine(result.targetFolder, fileName);
+
if (!result.required && !selectedOptionalMods.contains(relpath)) {
relpath += ".disabled";
}
diff --git a/launcher/modplatform/flame/FlameModIndex.cpp b/launcher/modplatform/flame/FlameModIndex.cpp
index f95b17683..3ed12266c 100644
--- a/launcher/modplatform/flame/FlameModIndex.cpp
+++ b/launcher/modplatform/flame/FlameModIndex.cpp
@@ -1,5 +1,6 @@
#include "FlameModIndex.h"
+#include "FileSystem.h"
#include "Json.h"
#include "minecraft/MinecraftInstance.h"
#include "minecraft/PackProfile.h"
@@ -139,6 +140,9 @@ auto FlameMod::loadIndexedPackVersion(QJsonObject& obj, bool load_changelog) ->
file.version = Json::requireString(obj, "displayName");
file.downloadUrl = Json::ensureString(obj, "downloadUrl");
file.fileName = Json::requireString(obj, "fileName");
+#ifdef Q_OS_WIN
+ file.fileName = FS::RemoveInvalidPathChars(file.fileName);
+#endif
ModPlatform::IndexedVersionType::VersionType ver_type;
switch (Json::requireInteger(obj, "releaseType")) {
diff --git a/launcher/modplatform/flame/FlamePackExportTask.cpp b/launcher/modplatform/flame/FlamePackExportTask.cpp
index 3a2028fd1..569181732 100644
--- a/launcher/modplatform/flame/FlamePackExportTask.cpp
+++ b/launcher/modplatform/flame/FlamePackExportTask.cpp
@@ -201,7 +201,7 @@ void FlamePackExportTask::makeApiRequest()
<< " reason: " << parseError.errorString();
qWarning() << *response;
- failed(parseError.errorString());
+ emitFailed(parseError.errorString());
return;
}
@@ -213,6 +213,7 @@ void FlamePackExportTask::makeApiRequest()
if (dataArr.isEmpty()) {
qWarning() << "No matches found for fingerprint search!";
+ getProjectsInfo();
return;
}
for (auto match : dataArr) {
@@ -243,9 +244,9 @@ void FlamePackExportTask::makeApiRequest()
qDebug() << doc;
}
pendingHashes.clear();
+ getProjectsInfo();
});
- connect(task.get(), &Task::finished, this, &FlamePackExportTask::getProjectsInfo);
- connect(task.get(), &NetJob::failed, this, &FlamePackExportTask::emitFailed);
+ connect(task.get(), &NetJob::failed, this, &FlamePackExportTask::getProjectsInfo);
task->start();
}
@@ -279,7 +280,7 @@ void FlamePackExportTask::getProjectsInfo()
qWarning() << "Error while parsing JSON response from CurseForge projects task at " << parseError.offset
<< " reason: " << parseError.errorString();
qWarning() << *response;
- failed(parseError.errorString());
+ emitFailed(parseError.errorString());
return;
}
@@ -333,7 +334,7 @@ void FlamePackExportTask::buildZip()
setStatus(tr("Adding files..."));
setProgress(4, 5);
- auto zipTask = makeShared(output, gameRoot, files, "overrides/", true);
+ auto zipTask = makeShared(output, gameRoot, files, "overrides/", true, false);
zipTask->addExtraFile("manifest.json", generateIndex());
zipTask->addExtraFile("modlist.html", generateHTML());
diff --git a/launcher/modplatform/helpers/NetworkResourceAPI.cpp b/launcher/modplatform/helpers/NetworkResourceAPI.cpp
index 225583764..974e732a7 100644
--- a/launcher/modplatform/helpers/NetworkResourceAPI.cpp
+++ b/launcher/modplatform/helpers/NetworkResourceAPI.cpp
@@ -45,8 +45,8 @@ Task::Ptr NetworkResourceAPI::searchProjects(SearchArgs&& args, SearchCallbacks&
QObject::connect(netJob.get(), &NetJob::failed, [netJob, callbacks](const QString& reason) {
int network_error_code = -1;
- if (auto* failed_action = netJob->getFailedActions().at(0); failed_action && failed_action->m_reply)
- network_error_code = failed_action->m_reply->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt();
+ if (auto* failed_action = netJob->getFailedActions().at(0); failed_action)
+ network_error_code = failed_action->replyStatusCode();
callbacks.on_fail(reason, network_error_code);
});
@@ -104,8 +104,8 @@ Task::Ptr NetworkResourceAPI::getProjectVersions(VersionSearchArgs&& args, Versi
});
QObject::connect(netJob.get(), &NetJob::failed, [netJob, callbacks](const QString& reason) {
int network_error_code = -1;
- if (auto* failed_action = netJob->getFailedActions().at(0); failed_action && failed_action->m_reply)
- network_error_code = failed_action->m_reply->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt();
+ if (auto* failed_action = netJob->getFailedActions().at(0); failed_action)
+ network_error_code = failed_action->replyStatusCode();
callbacks.on_fail(reason, network_error_code);
});
@@ -155,8 +155,8 @@ Task::Ptr NetworkResourceAPI::getDependencyVersion(DependencySearchArgs&& args,
});
QObject::connect(netJob.get(), &NetJob::failed, [netJob, callbacks](const QString& reason) {
int network_error_code = -1;
- if (auto* failed_action = netJob->getFailedActions().at(0); failed_action && failed_action->m_reply)
- network_error_code = failed_action->m_reply->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt();
+ if (auto* failed_action = netJob->getFailedActions().at(0); failed_action)
+ network_error_code = failed_action->replyStatusCode();
callbacks.on_fail(reason, network_error_code);
});
diff --git a/launcher/modplatform/modrinth/ModrinthInstanceCreationTask.cpp b/launcher/modplatform/modrinth/ModrinthInstanceCreationTask.cpp
index a688cea87..e92489999 100644
--- a/launcher/modplatform/modrinth/ModrinthInstanceCreationTask.cpp
+++ b/launcher/modplatform/modrinth/ModrinthInstanceCreationTask.cpp
@@ -240,11 +240,15 @@ bool ModrinthCreationTask::createInstance()
auto root_modpack_url = QUrl::fromLocalFile(root_modpack_path);
for (auto file : m_files) {
- auto file_path = FS::PathCombine(root_modpack_path, file.path);
+ auto fileName = file.path;
+#ifdef Q_OS_WIN
+ fileName = FS::RemoveInvalidPathChars(fileName);
+#endif
+ auto file_path = FS::PathCombine(root_modpack_path, fileName);
if (!root_modpack_url.isParentOf(QUrl::fromLocalFile(file_path))) {
// This means we somehow got out of the root folder, so abort here to prevent exploits
setError(tr("One of the files has a path that leads to an arbitrary location (%1). This is a security risk and isn't allowed.")
- .arg(file.path));
+ .arg(fileName));
return false;
}
@@ -257,7 +261,7 @@ bool ModrinthCreationTask::createInstance()
// FIXME: This really needs to be put into a ConcurrentTask of
// MultipleOptionsTask's , once those exist :)
auto param = dl.toWeakRef();
- connect(dl.get(), &NetAction::failed, [this, &file, file_path, param] {
+ connect(dl.get(), &Task::failed, [this, &file, file_path, param] {
auto ndl = Net::ApiDownload::makeFile(file.downloads.dequeue(), file_path);
ndl->addValidator(new Net::ChecksumValidator(file.hashAlgorithm, file.hash));
m_files_job->addNetAction(ndl);
diff --git a/launcher/modplatform/modrinth/ModrinthPackExportTask.cpp b/launcher/modplatform/modrinth/ModrinthPackExportTask.cpp
index c704708ad..7e52153b9 100644
--- a/launcher/modplatform/modrinth/ModrinthPackExportTask.cpp
+++ b/launcher/modplatform/modrinth/ModrinthPackExportTask.cpp
@@ -200,7 +200,7 @@ void ModrinthPackExportTask::buildZip()
{
setStatus(tr("Adding files..."));
- auto zipTask = makeShared(output, gameRoot, files, "overrides/", true);
+ auto zipTask = makeShared(output, gameRoot, files, "overrides/", true, true);
zipTask->addExtraFile("modrinth.index.json", generateIndex());
zipTask->setExcludeFiles(resolvedFiles.keys());
diff --git a/launcher/modplatform/modrinth/ModrinthPackIndex.cpp b/launcher/modplatform/modrinth/ModrinthPackIndex.cpp
index 555100eaf..ba8f5f83e 100644
--- a/launcher/modplatform/modrinth/ModrinthPackIndex.cpp
+++ b/launcher/modplatform/modrinth/ModrinthPackIndex.cpp
@@ -18,6 +18,7 @@
*/
#include "ModrinthPackIndex.h"
+#include "FileSystem.h"
#include "ModrinthAPI.h"
#include "Json.h"
@@ -222,6 +223,9 @@ auto Modrinth::loadIndexedPackVersion(QJsonObject& obj, QString preferred_hash_t
if (parent.contains("url")) {
file.downloadUrl = Json::requireString(parent, "url");
file.fileName = Json::requireString(parent, "filename");
+#ifdef Q_OS_WIN
+ file.fileName = FS::RemoveInvalidPathChars(file.fileName);
+#endif
file.is_preferred = Json::requireBoolean(parent, "primary") || (files.count() == 1);
auto hash_list = Json::requireObject(parent, "hashes");
diff --git a/launcher/modplatform/technic/TechnicPackProcessor.cpp b/launcher/modplatform/technic/TechnicPackProcessor.cpp
index 90f59ce54..a47a4811f 100644
--- a/launcher/modplatform/technic/TechnicPackProcessor.cpp
+++ b/launcher/modplatform/technic/TechnicPackProcessor.cpp
@@ -155,8 +155,26 @@ void Technic::TechnicPackProcessor::run(SettingsObjectPtr globalSettings,
auto libraryObject = Json::ensureObject(library, {}, "");
auto libraryName = Json::ensureString(libraryObject, "name", "", "");
- if ((libraryName.startsWith("net.minecraftforge:forge:") || libraryName.startsWith("net.minecraftforge:fmlloader:")) &&
- libraryName.contains('-')) {
+ if (libraryName.startsWith("net.neoforged.fancymodloader:")) { // it is neoforge
+ // no easy way to get the version from the libs so use the arguments
+ auto arguments = Json::ensureObject(root, "arguments", {});
+ bool isVersionArg = false;
+ QString neoforgeVersion;
+ for (auto arg : Json::ensureArray(arguments, "game", {})) {
+ auto argument = Json::ensureString(arg, "");
+ if (isVersionArg) {
+ neoforgeVersion = argument;
+ break;
+ } else {
+ isVersionArg = "--fml.neoForgeVersion" == argument || "--fml.forgeVersion" == argument;
+ }
+ }
+ if (!neoforgeVersion.isEmpty()) {
+ components->setComponentVersion("net.neoforged", neoforgeVersion);
+ }
+ break;
+ } else if ((libraryName.startsWith("net.minecraftforge:forge:") || libraryName.startsWith("net.minecraftforge:fmlloader:")) &&
+ libraryName.contains('-')) {
QString libraryVersion = libraryName.section(':', 2);
if (!libraryVersion.startsWith("1.7.10-")) {
components->setComponentVersion("net.minecraftforge", libraryName.section('-', 1));
@@ -164,6 +182,7 @@ void Technic::TechnicPackProcessor::run(SettingsObjectPtr globalSettings,
// 1.7.10 versions sometimes look like 1.7.10-10.13.4.1614-1.7.10, this filters out the 10.13.4.1614 part
components->setComponentVersion("net.minecraftforge", libraryName.section('-', 1, 1));
}
+ break;
} else {
// ->
static QMap loaderMap{ { "net.minecraftforge:minecraftforge:", "net.minecraftforge" },
diff --git a/launcher/net/ApiDownload.cpp b/launcher/net/ApiDownload.cpp
index aaa8ff650..8768b63f8 100644
--- a/launcher/net/ApiDownload.cpp
+++ b/launcher/net/ApiDownload.cpp
@@ -21,7 +21,6 @@
#include "ByteArraySink.h"
#include "ChecksumValidator.h"
#include "MetaCacheSink.h"
-#include "net/NetAction.h"
namespace Net {
diff --git a/launcher/net/ApiUpload.cpp b/launcher/net/ApiUpload.cpp
index c1221b764..505cbd9f9 100644
--- a/launcher/net/ApiUpload.cpp
+++ b/launcher/net/ApiUpload.cpp
@@ -19,9 +19,6 @@
#include "net/ApiUpload.h"
#include "ByteArraySink.h"
-#include "ChecksumValidator.h"
-#include "MetaCacheSink.h"
-#include "net/NetAction.h"
namespace Net {
diff --git a/launcher/net/ByteArraySink.h b/launcher/net/ByteArraySink.h
index 7b8f0f8aa..d636f6634 100644
--- a/launcher/net/ByteArraySink.h
+++ b/launcher/net/ByteArraySink.h
@@ -74,10 +74,6 @@ class ByteArraySink : public Sink {
auto abort() -> Task::State override
{
- if (m_output)
- m_output->clear();
- else
- qWarning() << "ByteArraySink did not clear the buffer because it's not addressable";
failAllValidators();
return Task::State::Failed;
}
diff --git a/launcher/net/Download.cpp b/launcher/net/Download.cpp
index bae364f12..49686db98 100644
--- a/launcher/net/Download.cpp
+++ b/launcher/net/Download.cpp
@@ -47,8 +47,6 @@
#include "ChecksumValidator.h"
#include "MetaCacheSink.h"
-#include "net/NetAction.h"
-
namespace Net {
#if defined(LAUNCHER_APPLICATION)
diff --git a/launcher/net/HttpMetaCache.cpp b/launcher/net/HttpMetaCache.cpp
index f37bc0bf8..648155412 100644
--- a/launcher/net/HttpMetaCache.cpp
+++ b/launcher/net/HttpMetaCache.cpp
@@ -84,6 +84,9 @@ auto HttpMetaCache::getEntry(QString base, QString resource_path) -> MetaEntryPt
auto HttpMetaCache::resolveEntry(QString base, QString resource_path, QString expected_etag) -> MetaEntryPtr
{
+#ifdef Q_OS_WIN
+ resource_path = FS::RemoveInvalidPathChars(resource_path);
+#endif
auto entry = getEntry(base, resource_path);
// it's not present? generate a default stale entry
if (!entry) {
diff --git a/launcher/net/NetAction.h b/launcher/net/NetAction.h
deleted file mode 100644
index b66b91941..000000000
--- a/launcher/net/NetAction.h
+++ /dev/null
@@ -1,100 +0,0 @@
-// SPDX-License-Identifier: GPL-3.0-only
-/*
- * Prism Launcher - Minecraft Launcher
- * Copyright (c) 2022 flowln
- * Copyright (C) 2023 Rachel Powers <508861+Ryex@users.noreply.github.com>
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, version 3.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program. If not, see .
- *
- * This file incorporates work covered by the following copyright and
- * permission notice:
- *
- * Copyright 2013-2021 MultiMC Contributors
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-#pragma once
-
-#include
-#include
-
-#include "QObjectPtr.h"
-#include "tasks/Task.h"
-
-#include "HeaderProxy.h"
-
-class NetAction : public Task {
- Q_OBJECT
- protected:
- explicit NetAction() : Task() {}
-
- public:
- using Ptr = shared_qobject_ptr;
-
- virtual ~NetAction() = default;
-
- QUrl url() { return m_url; }
-
- void setNetwork(shared_qobject_ptr network) { m_network = network; }
-
- void addHeaderProxy(Net::HeaderProxy* proxy) { m_headerProxies.push_back(std::shared_ptr(proxy)); }
- virtual void init() = 0;
-
- protected slots:
- virtual void downloadProgress(qint64 bytesReceived, qint64 bytesTotal) = 0;
- virtual void downloadError(QNetworkReply::NetworkError error) = 0;
- virtual void downloadFinished() = 0;
- virtual void downloadReadyRead() = 0;
-
- virtual void sslErrors(const QList& errors)
- {
- int i = 1;
- for (auto error : errors) {
- qCritical() << "Network SSL Error #" << i << " : " << error.errorString();
- auto cert = error.certificate();
- qCritical() << "Certificate in question:\n" << cert.toText();
- i++;
- }
- }
-
- public slots:
- void startAction(shared_qobject_ptr network)
- {
- m_network = network;
- executeTask();
- }
-
- protected:
- void executeTask() override {}
-
- public:
- shared_qobject_ptr