From 5bd5627a9646361ccee2d96bb555de58072bc7ab Mon Sep 17 00:00:00 2001
From: Trial97 <alexandru.tripon97@gmail.com>
Date: Tue, 8 Oct 2024 15:06:50 +0300
Subject: [PATCH] extended the modrinth search and applied the suggested change

Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
---
 .../modplatform/modrinth/ModrinthPage.cpp     |  2 +-
 launcher/ui/widgets/ModFilterWidget.cpp       | 24 ++++++++++++-------
 2 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/launcher/ui/pages/modplatform/modrinth/ModrinthPage.cpp b/launcher/ui/pages/modplatform/modrinth/ModrinthPage.cpp
index 2c19d54ad..8803c6dd9 100644
--- a/launcher/ui/pages/modplatform/modrinth/ModrinthPage.cpp
+++ b/launcher/ui/pages/modplatform/modrinth/ModrinthPage.cpp
@@ -391,7 +391,7 @@ QString ModrinthPage::getSerachTerm() const
 
 void ModrinthPage::createFilterWidget()
 {
-    auto widget = ModFilterWidget::create(nullptr, false, this);
+    auto widget = ModFilterWidget::create(nullptr, true, this);
     m_filterWidget.swap(widget);
     auto old = ui->splitter->replaceWidget(0, m_filterWidget.get());
     // because we replaced the widget we also need to delete it
diff --git a/launcher/ui/widgets/ModFilterWidget.cpp b/launcher/ui/widgets/ModFilterWidget.cpp
index a048dbe10..68adcdb71 100644
--- a/launcher/ui/widgets/ModFilterWidget.cpp
+++ b/launcher/ui/widgets/ModFilterWidget.cpp
@@ -64,6 +64,8 @@ class VersionBasicModel : public QIdentityProxyModel {
     {
         if (role == Qt::DisplayRole)
             return QIdentityProxyModel::data(index, BaseVersionList::VersionIdRole);
+        if (role == Qt::UserRole)
+            return QIdentityProxyModel::data(index, BaseVersionList::VersionIdRole);
         return {};
     }
 };
@@ -86,6 +88,9 @@ class AllVersionProxyModel : public QSortFilterProxyModel {
             if (role == Qt::DisplayRole) {
                 return tr("All Versions");
             }
+            if (role == Qt::UserRole) {
+                return "all";
+            }
             return {};
         }
 
@@ -113,17 +118,18 @@ ModFilterWidget::ModFilterWidget(MinecraftInstance* instance, bool extended, QWi
     QAbstractProxyModel* proxy = new VersionBasicModel(this);
     proxy->setSourceModel(m_versions_proxy);
 
-    if (!m_instance && !extended) {
+    if (extended) {
+        if (!m_instance) {
+            ui->environmentGroup->hide();
+        }
+        ui->versions->setSourceModel(proxy);
+        ui->versions->setSeparator(", ");
+        ui->versions->setDefaultText(tr("All Versions"));
+        ui->version->hide();
+    } else {
         auto allVersions = new AllVersionProxyModel(this);
         allVersions->setSourceModel(proxy);
         proxy = allVersions;
-    }
-
-    if (extended) {
-        ui->versions->setSourceModel(proxy);
-        ui->versions->setSeparator(", ");
-        ui->version->hide();
-    } else {
         ui->version->setModel(proxy);
         ui->versions->hide();
         ui->showAllVersions->hide();
@@ -293,7 +299,7 @@ void ModFilterWidget::onHideInstalledFilterChanged()
 void ModFilterWidget::onVersionFilterTextChanged(const QString& version)
 {
     m_filter->versions.clear();
-    if (version != tr("All Versions")) {
+    if (ui->version->currentData(Qt::UserRole) != "all") {
         m_filter->versions.emplace_back(version);
     }
     m_filter_changed = true;