Merge pull request #1852 from Trial97/war_ning

launcher/minecraft/mod/ResourceFolderModel.cpp

@@ -461,9 +461,9 @@ bool ResourceFolderModel::setData(const QModelIndex& index, [[maybe_unused]] con
     if (role == Qt::CheckStateRole) {
         if (m_instance != nullptr && m_instance->isRunning()) {
             auto response =
-                CustomMessageBox::selectable(nullptr, "Confirm toggle",
+                CustomMessageBox::selectable(nullptr, tr("Confirm toggle"),
-                                             "If you enable/disable this resource while the game is running it may crash your game.\n"
+                                             tr("If you enable/disable this resource while the game is running it may crash your game.\n"
-                                             "Are you sure you want to do this?",
+                                                "Are you sure you want to do this?"),
                                              QMessageBox::Warning, QMessageBox::Yes | QMessageBox::No, QMessageBox::No)
                     ->exec();
 

launcher/ui/pages/instance/ExternalResourcesPage.cpp

@@ -254,9 +254,9 @@ void ExternalResourcesPage::removeItem()
 void ExternalResourcesPage::removeItems(const QItemSelection& selection)
 {
     if (m_instance != nullptr && m_instance->isRunning()) {
-        auto response = CustomMessageBox::selectable(this, "Confirm Delete",
+        auto response = CustomMessageBox::selectable(this, tr("Confirm Delete"),
-                                                     "If you remove this resource while the game is running it may crash your game.\n"
+                                                     tr("If you remove this resource while the game is running it may crash your game.\n"
-                                                     "Are you sure you want to do this?",
+                                                        "Are you sure you want to do this?"),
                                                      QMessageBox::Warning, QMessageBox::Yes | QMessageBox::No, QMessageBox::No)
                             ->exec();
 
@@ -275,9 +275,9 @@ void ExternalResourcesPage::enableItem()
 void ExternalResourcesPage::disableItem()
 {
     if (m_instance != nullptr && m_instance->isRunning()) {
-        auto response = CustomMessageBox::selectable(this, "Confirm disable",
+        auto response = CustomMessageBox::selectable(this, tr("Confirm disable"),
-                                                     "If you disable this resource while the game is running it may crash your game.\n"
+                                                     tr("If you disable this resource while the game is running it may crash your game.\n"
-                                                     "Are you sure you want to do this?",
+                                                        "Are you sure you want to do this?"),
                                                      QMessageBox::Warning, QMessageBox::Yes | QMessageBox::No, QMessageBox::No)
                             ->exec();
 

launcher/ui/pages/instance/ModFolderPage.cpp

@@ -171,9 +171,9 @@ bool ModFolderPage::onSelectionChanged(const QModelIndex& current, [[maybe_unuse
 void ModFolderPage::removeItems(const QItemSelection& selection)
 {
     if (m_instance != nullptr && m_instance->isRunning()) {
-        auto response = CustomMessageBox::selectable(this, "Confirm Delete",
+        auto response = CustomMessageBox::selectable(this, tr("Confirm Delete"),
-                                                     "If you remove mods while the game is running it may crash your game.\n"
+                                                     tr("If you remove mods while the game is running it may crash your game.\n"
-                                                     "Are you sure you want to do this?",
+                                                        "Are you sure you want to do this?"),
                                                      QMessageBox::Warning, QMessageBox::Yes | QMessageBox::No, QMessageBox::No)
                             ->exec();
 
@@ -239,6 +239,18 @@ void ModFolderPage::updateMods(bool includeDeps)
         QMessageBox::critical(this, tr("Error"), tr("Mod updates are unavailable when metadata is disabled!"));
         return;
     }
+    if (m_instance != nullptr && m_instance->isRunning()) {
+        auto response =
+            CustomMessageBox::selectable(this, tr("Confirm Update"),
+                                         tr("If you update mods while the game is running may cause mod duplication and game crashes.\n"
+                                            "The old files may not be deleted as they are in use.\n"
+                                            "Are you sure you want to do this?"),
+                                         QMessageBox::Warning, QMessageBox::Yes | QMessageBox::No, QMessageBox::No)
+                ->exec();
+
+        if (response != QMessageBox::Yes)
+            return;
+    }
     auto selection = m_filterModel->mapSelectionToSource(ui->treeView->selectionModel()->selection()).indexes();
 
     auto mods_list = m_model->selectedMods(selection);