ONIMAI-SMP/ShatteredPrism
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix heap-use-after-free in modrinth creation task

Browse Source 
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com>
This commit is contained in:
Trial97 2024-10-14 11:10:54 +03:00
parent f239f4c17c
commit ac13579b99
No known key found for this signature in database
GPG Key ID: 55EF5DA53DB36318
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
launcher/modplatform/modrinth/ModrinthInstanceCreationTask.cpp
View File

@ -301,6 +301,13 @@ bool ModrinthCreationTask::createInstance()
loop.exec(); loop.exec();
if (!ended_well) {
for (auto m : mods) {
delete m;
}
return ended_well;
}
QEventLoop ensureMetaLoop; QEventLoop ensureMetaLoop;
QDir folder = FS::PathCombine(instance.modsRoot(), ".index"); QDir folder = FS::PathCombine(instance.modsRoot(), ".index");
auto ensureMetadataTask = makeShared<EnsureMetadataTask>(mods, folder, ModPlatform::ResourceProvider::MODRINTH); auto ensureMetadataTask = makeShared<EnsureMetadataTask>(mods, folder, ModPlatform::ResourceProvider::MODRINTH);