ONIMAI-SMP/ShatteredPrism
3
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 1 Wiki Activity

fix: remove qWarning for unknown state

Browse Source 
Co-authored-by: TheKodeToad <TheKodeToad@proton.me>
Signed-off-by: Sticks <sticks@teamhydra.dev>
(cherry picked from commit d4e1851e6779d99e3ffde79c7e4e8edb568415ce)
This commit is contained in:
Sticks 2025-03-04 22:20:40 -06:00 committed by github-actions[bot]
parent 25ce20a877
commit b0ee4f6e58
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
launcher/ui/pages/instance/ManagedPackPage.cpp
View File

@ -343,14 +343,15 @@ void ModrinthManagedPackPage::suggestVersion()
void ManagedPackPage::onUpdateTaskCompleted(bool did_succeed) const void ManagedPackPage::onUpdateTaskCompleted(bool did_succeed) const
{ {
// Close the window if the update was successful // Close the window if the update was successful
if (m_instance_window && did_succeed) { if (did_succeed) {
m_instance_window->close(); if (m_instance_window != nullptr)
m_instance_window->close();
CustomMessageBox::selectable(nullptr, tr("Update Successful"), tr("The instance updated to pack version %1 successfully.").arg(m_inst->getManagedPackVersionName()), QMessageBox::Information) CustomMessageBox::selectable(nullptr, tr("Update Successful"), tr("The instance updated to pack version %1 successfully.").arg(m_inst->getManagedPackVersionName()), QMessageBox::Information)
->show(); ->show();
} else if (!did_succeed) { } else {
CustomMessageBox::selectable(nullptr, tr("Update Failed"), tr("The instance failed to update to pack version %1. Please check launcher logs for more information.").arg(m_inst->getManagedPackVersionName()), QMessageBox::Critical) CustomMessageBox::selectable(nullptr, tr("Update Failed"), tr("The instance failed to update to pack version %1. Please check launcher logs for more information.").arg(m_inst->getManagedPackVersionName()), QMessageBox::Critical)
->show(); ->show();
qWarning() << "onUpdateTaskCompleted: unknown state encountered: did_succeed=" << did_succeed << " m_instance_window=" << m_instance_window;
} }
} }