ONIMAI-SMP/ShatteredPrism
3
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases 1 Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: seth <getchoo@tuta.io>
Signed-off-by: Alexandru Ionut Tripon <alexandru.tripon97@gmail.com>
This commit is contained in:
Alexandru Ionut Tripon 2024-09-13 21:13:21 +03:00 committed by GitHub
parent 973b43ca7a
commit d20f24d96f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
launcher/Application.cpp
View File

@ -777,8 +777,8 @@ Application::Application(int& argc, char** argv) : QApplication(argc, argv)
// FTBApp instances // FTBApp instances
m_settings->registerSetting("FTBAppInstancesPath", ""); m_settings->registerSetting("FTBAppInstancesPath", "");
// Custom Techinc Client ID // Custom Technic Client ID
m_settings->registerSetting("TechincClientID", ""); m_settings->registerSetting("TechnicClientID", "");
// Init page provider // Init page provider
{ {

4
launcher/ui/pages/global/APIPage.cpp
View File

@ -143,7 +143,7 @@ void APIPage::loadSettings()
ui->modrinthToken->setText(modrinthToken); ui->modrinthToken->setText(modrinthToken);
QString customUserAgent = s->get("UserAgentOverride").toString(); QString customUserAgent = s->get("UserAgentOverride").toString();
ui->userAgentLineEdit->setText(customUserAgent); ui->userAgentLineEdit->setText(customUserAgent);
ui->techicClientID->setText(s->get("TechincClientID").toString()); ui->techicClientID->setText(s->get("TechnicClientID").toString());
} }
void APIPage::applySettings() void APIPage::applySettings()
@ -173,7 +173,7 @@ void APIPage::applySettings()
QString modrinthToken = ui->modrinthToken->text(); QString modrinthToken = ui->modrinthToken->text();
s->set("ModrinthToken", modrinthToken); s->set("ModrinthToken", modrinthToken);
s->set("UserAgentOverride", ui->userAgentLineEdit->text()); s->set("UserAgentOverride", ui->userAgentLineEdit->text());
s->set("TechincClientID", ui->techicClientID->text()); s->set("TechincClientID", ui->technicClientID->text());
} }
bool APIPage::apply() bool APIPage::apply()

6
launcher/ui/pages/global/APIPage.ui
View File

@ -291,7 +291,7 @@
<item> <item>
<widget class="QGroupBox" name="groupBox"> <widget class="QGroupBox" name="groupBox">
<property name="title"> <property name="title">
<string>Techinc Client ID</string> <string>Technic Client ID</string>
</property> </property>
<layout class="QVBoxLayout" name="verticalLayout_9"> <layout class="QVBoxLayout" name="verticalLayout_9">
<item> <item>
@ -302,7 +302,7 @@
</widget> </widget>
</item> </item>
<item> <item>
<widget class="QLineEdit" name="techicClientID"> <widget class="QLineEdit" name="technicClientID">
<property name="placeholderText"> <property name="placeholderText">
<string>(None)</string> <string>(None)</string>
</property> </property>
@ -311,7 +311,7 @@
<item> <item>
<widget class="QLabel" name="label_12"> <widget class="QLabel" name="label_12">
<property name="text"> <property name="text">
<string>Enter a custom GUID client ID for Techinc here.</string> <string>Enter a custom GUID client ID for Technic here.</string>
</property> </property>
</widget> </widget>
</item> </item>

2
launcher/ui/pages/modplatform/technic/TechnicModel.cpp
View File

@ -154,7 +154,7 @@ void Technic::ListModel::performSearch()
QString("%1search?build=%2&q=%3").arg(BuildConfig.TECHNIC_API_BASE_URL, BuildConfig.TECHNIC_API_BUILD, currentSearchTerm); QString("%1search?build=%2&q=%3").arg(BuildConfig.TECHNIC_API_BASE_URL, BuildConfig.TECHNIC_API_BUILD, currentSearchTerm);
searchMode = List; searchMode = List;
} }
auto clientId = APPLICATION->settings()->get("TechincClientID").toString(); auto clientId = APPLICATION->settings()->get("TechnicClientID").toString();
if (!clientId.isEmpty()) { if (!clientId.isEmpty()) {
searchUrl += "?cid=" + clientId; searchUrl += "?cid=" + clientId;
} }