From cb65f6dfb582847d1dc9284379b1b45ac8c53b6e Mon Sep 17 00:00:00 2001 From: Rachel Powers <508861+Ryex@users.noreply.github.com> Date: Wed, 17 Jul 2024 23:05:45 -0700 Subject: [PATCH] fix(net/validators): ensure buffers are cleared and reset; Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com> --- launcher/meta/BaseEntity.cpp | 12 ++++++++++-- launcher/net/ChecksumValidator.h | 6 +++++- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/launcher/meta/BaseEntity.cpp b/launcher/meta/BaseEntity.cpp index 8a99e3303..cbde3b49d 100644 --- a/launcher/meta/BaseEntity.cpp +++ b/launcher/meta/BaseEntity.cpp @@ -30,13 +30,21 @@ class ParsingValidator : public Net::Validator { virtual ~ParsingValidator(){}; public: /* methods */ - bool init(QNetworkRequest&) override { return true; } + bool init(QNetworkRequest&) override + { + m_data.clear(); + return true; + } bool write(QByteArray& data) override { this->m_data.append(data); return true; } - bool abort() override { return true; } + bool abort() override + { + m_data.clear(); + return true; + } bool validate(QNetworkReply&) override { auto fname = m_entity->localFilename(); diff --git a/launcher/net/ChecksumValidator.h b/launcher/net/ChecksumValidator.h index dfee0aee5..ab2457202 100644 --- a/launcher/net/ChecksumValidator.h +++ b/launcher/net/ChecksumValidator.h @@ -60,7 +60,11 @@ class ChecksumValidator : public Validator { return true; } - auto abort() -> bool override { return true; } + auto abort() -> bool override + { + m_checksum.reset(); + return true; + } auto validate(QNetworkReply&) -> bool override {