From fa2c2a7c8562b902b12bfea503977607daefb66f Mon Sep 17 00:00:00 2001
From: SabrePenguin <lknofczynski@gmail.com>
Date: Wed, 1 May 2024 13:00:55 -0400
Subject: [PATCH] Made Regex static and const, removed dist

Signed-off-by: SabrePenguin <lknofczynski@gmail.com>
---
 launcher/StringUtils.cpp | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/launcher/StringUtils.cpp b/launcher/StringUtils.cpp
index 82147c16a..edda9f247 100644
--- a/launcher/StringUtils.cpp
+++ b/launcher/StringUtils.cpp
@@ -213,14 +213,14 @@ QPair<QString, QString> StringUtils::splitFirst(const QString& s, const QRegular
     return qMakePair(left, right);
 }
 
+static const QRegularExpression ulMatcher("<\\s*/\\s*ul\\s*>");
+
 QString StringUtils::htmlListPatch(QString htmlStr)
 {
-    QRegularExpression match("<\\s/\\s*ul\\s*>");
-    int pos = htmlStr.indexOf(match);
-    int imgPos, dist;
+    int pos = htmlStr.indexOf(ulMatcher);
+    int imgPos;
     while (pos != -1) {
-        dist = htmlStr.indexOf(">", pos) - pos + 1;  // Get the size of the </ul> tag. Add one for zeroeth index
-        pos = pos + dist;
+        pos = htmlStr.indexOf(">", pos) + 1;  // Get the size of the </ul> tag. Add one for zeroeth index
         imgPos = htmlStr.indexOf("<img ", pos);
         if (imgPos == -1)
             break;  // no image after the tag
@@ -230,7 +230,7 @@ QString StringUtils::htmlListPatch(QString htmlStr)
         if (textBetween.isEmpty())
             htmlStr.insert(pos, "<br>");
 
-        pos = htmlStr.indexOf(match, pos);
+        pos = htmlStr.indexOf(ulMatcher, pos);
     }
     return htmlStr;
 }
\ No newline at end of file