As part of packaging Prism Launcher for Debian, I have run a package linter
called lintian which found a few spelling errors throughout the source.
I am not a fan of contributions that only fix cosmetics like spelling errors,
but Debian encourages forwarding this stuff upstream instead of letting it get
fixed naturally over time.
Signed-off-by: Ben Westover <me@benthetechguy.net>
Upstream changelog: https://github.com/PrismLauncher/PrismLauncher/releases/tag/8.0
(Imcomplete) list of changes in 8.0 relevant to PollyMC:
- Prism has dropped support for Mojang accounts
- https://github.com/PrismLauncher/PrismLauncher/pull/1656
- Added it back to PollyMC primarily since the Mojang authentication
code is also used for authlib-injector accounts. Some users may also
still want to be able to log in to Mojang accounts for some reason:
https://github.com/fn2006/PollyMC/issues/115#issuecomment-1805384658,
even if they do not provide authentication to multiplayer servers.
- To my surprise, I could still log in to a Mojang account, get its
skin, and launch the game. Authentication to servers, of course, did
not work.
- Tested: logging into authlib-injector, Mojang, and MSA accounts and
launching the game.
- Prism has added a built-in updater for Windows and Linux that I assume
provides similar functionality to Sparkle on macOS:
https://github.com/PrismLauncher/PrismLauncher/pull/1268. There is a
Launcher_UPDATER_GITHUB_REPO variable in CMakeLists.txt that specifies
the repo checked by the updater. I have changed this to the PollyMC
repository, and since PollyMC follows almost the same CI/release
patterns as Prism Launcher, it might work with PollyMC, too, but I
have not tested it yet.
- Add macOS support to Nix
- https://github.com/PrismLauncher/PrismLauncher/pull/1485
- Untested
- The "PollyMC-Linux-8.0.tar.gz" and similar build artifacts were
renamed to "PollyMC-Linux-8.0-Qt5.tar.gz" to match their
"PollyMC-Linux-8.0-Qt6.tar.gz" counterparts.
- Removed Windows MSVC Legacy builds
- Removed Quilt Beacon toggle, the beacon is now always disabled:
https://github.com/PrismLauncher/PrismLauncher/pull/1547,
https://github.com/PrismLauncher/meta/pull/23
- Prism removed FTB support in 7.0, but I tested creating an FTB
instance to make sure it still works in 8.0
Signed-off-by: Evan Goode <mail@evangoo.de>
- convert qt connect calls to use function pointers instead of the signal/slot macros wherever practical (UI classes were mostly left alone, target was tasks and processes)
- give signals an explicit receivers to use the static method over the instance method wherever practical
- ensure networks tasks are using the `errorOccured` signal added in Qt5.15 over the deprecated `error` signal
- ensure all networks tasks have an sslErrors signal connected
- add seemingly missing `MinecraftAccount::authSucceeded` connection for `MSAInteractive` login flow
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
