Reputable projects such as prismarine-auth and azalea-auth hardcode the
Nintendo Switch client ID instead of their own custom Azure application,
so we should be fine to go ahead and do the same.
Unfortunately, client IDs created for custom Azure applications, such as
Prism Launcher's client ID, will no longer work with Fjord Launcher, so
users who manually supplied a client ID will need to clear theirs.
Resolves https://github.com/fn2006/PollyMC/issues/150
If the game is launched in offline mode, pass invalid API servers via
the -Dminecraft.api.* system properties. This workaround is mentioned
here:
https://github.com/FabricMC/fabric-loom/issues/915#issuecomment-1609154390
I think this change is appropriate to make here in PollyMC even though
the Fabric developers decided against using it there. If a user wants to
override the API servers back to the vanilla values (in order to use
Auth Me or something), they can do so by setting the following custom
JVM args on the instance:
-Dminecraft.api.env=PROD
-Dminecraft.api.auth.host=https://authserver.mojang.com
-Dminecraft.api.account.host=https://api.mojang.com
-Dminecraft.api.session.host=https://sessionserver.mojang.com
-Dminecraft.api.services.host=https://api.minecraftservices.com
Previously, auth args would override any user-specified args, but this
patch also changes that behavior so user-specified args are now passed
last.
Upstream changelog: https://github.com/PrismLauncher/PrismLauncher/releases/tag/8.0
(Imcomplete) list of changes in 8.0 relevant to PollyMC:
- Prism has dropped support for Mojang accounts
- https://github.com/PrismLauncher/PrismLauncher/pull/1656
- Added it back to PollyMC primarily since the Mojang authentication
code is also used for authlib-injector accounts. Some users may also
still want to be able to log in to Mojang accounts for some reason:
https://github.com/fn2006/PollyMC/issues/115#issuecomment-1805384658,
even if they do not provide authentication to multiplayer servers.
- To my surprise, I could still log in to a Mojang account, get its
skin, and launch the game. Authentication to servers, of course, did
not work.
- Tested: logging into authlib-injector, Mojang, and MSA accounts and
launching the game.
- Prism has added a built-in updater for Windows and Linux that I assume
provides similar functionality to Sparkle on macOS:
https://github.com/PrismLauncher/PrismLauncher/pull/1268. There is a
Launcher_UPDATER_GITHUB_REPO variable in CMakeLists.txt that specifies
the repo checked by the updater. I have changed this to the PollyMC
repository, and since PollyMC follows almost the same CI/release
patterns as Prism Launcher, it might work with PollyMC, too, but I
have not tested it yet.
- Add macOS support to Nix
- https://github.com/PrismLauncher/PrismLauncher/pull/1485
- Untested
- The "PollyMC-Linux-8.0.tar.gz" and similar build artifacts were
renamed to "PollyMC-Linux-8.0-Qt5.tar.gz" to match their
"PollyMC-Linux-8.0-Qt6.tar.gz" counterparts.
- Removed Windows MSVC Legacy builds
- Removed Quilt Beacon toggle, the beacon is now always disabled:
https://github.com/PrismLauncher/PrismLauncher/pull/1547,
https://github.com/PrismLauncher/meta/pull/23
- Prism removed FTB support in 7.0, but I tested creating an FTB
instance to make sure it still works in 8.0
Signed-off-by: Evan Goode <mail@evangoo.de>
Fixes a bug where the wrong account could be marked as "in use" when the
game is launched if there are multiple accounts that share the same
profile ID. This can lead to the launcher trying to refresh an account
that's currently in use by the game, leading to "Invalid session" errors
in-game.
Signed-off-by: Evan Goode <mail@evangoo.de>
Double-click to toggle profile components.
Restore double-click to toggle resources.
Fix clicking on checkbox to select account.
Double-click to select account.
Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
QPainter has a bug where drawing transparency to a freshly initialized, empty QPixmap causes garbage data to be drawn. This broke the rendering of the skin icon. The fix is simply to fill the QPixmap with empty transparent pixels beforehand.
Signed-off-by: maple! <averyrudelphe@gmail.com>
