fix client-version fallback not handling channel errors (#4378)

This commit is contained in:
Matt 2025-01-23 22:55:37 +00:00 committed by GitHub
parent 5d1aa50753
commit 4785464332
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -176,7 +176,15 @@
App.Logger.WriteLine(LOG_IDENT, "Failed to contact clientsettingscdn! Falling back to clientsettings...");
App.Logger.WriteException(LOG_IDENT, ex);
clientVersion = await Http.GetJson<ClientVersion>("https://clientsettings.roblox.com" + path);
try
{
clientVersion = await Http.GetJson<ClientVersion>("https://clientsettings.roblox.com" + path);
}
catch (HttpRequestException httpEx)
when (!isDefaultChannel && BadChannelCodes.Contains(httpEx.StatusCode))
{
throw new InvalidChannelException(httpEx.StatusCode);
}
}
// check if channel is behind LIVE