mirror of
https://github.com/bloxstraplabs/bloxstrap.git
synced 2025-04-10 15:25:42 -07:00
kill roblox players on upgrade no matter what
This commit is contained in:
parent
534e3bbc0e
commit
a55a0be6bb
@ -691,21 +691,19 @@ namespace Bloxstrap
|
||||
}
|
||||
}
|
||||
|
||||
private void KillRunningRobloxInDirectory(string path)
|
||||
private static void KillRobloxPlayers()
|
||||
{
|
||||
const string LOG_IDENT = "Bootstrapper::KillRunningRobloxInDirectory";
|
||||
const string LOG_IDENT = "Bootstrapper::KillRobloxPlayers";
|
||||
|
||||
List<Process> processes = new List<Process>();
|
||||
processes.AddRange(Process.GetProcessesByName(IsStudioLaunch ? "RobloxStudioBeta" : "RobloxPlayerBeta"));
|
||||
processes.AddRange(Process.GetProcessesByName("RobloxCrashHandler"));
|
||||
processes.AddRange(Process.GetProcessesByName("RobloxPlayerBeta"));
|
||||
processes.AddRange(Process.GetProcessesByName("RobloxCrashHandler")); // roblox studio doesnt depend on crash handler being open, so this should be fine
|
||||
|
||||
foreach (Process process in processes)
|
||||
{
|
||||
try
|
||||
{
|
||||
string? processPath = process.MainModule?.FileName;
|
||||
if (processPath != null && processPath.StartsWith(path))
|
||||
process.Kill();
|
||||
process.Kill();
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
@ -730,9 +728,11 @@ namespace Bloxstrap
|
||||
|
||||
_isInstalling = true;
|
||||
|
||||
// make sure nothing is running from the latest version directory before deleting the whole directory
|
||||
KillRunningRobloxInDirectory(_latestVersionDirectory);
|
||||
// make sure nothing is running before continuing upgrade
|
||||
if (!IsStudioLaunch) // TODO: wait for studio processes to close before updating to prevent data loss
|
||||
KillRobloxPlayers();
|
||||
|
||||
// get a fully clean install
|
||||
if (Directory.Exists(_latestVersionDirectory))
|
||||
{
|
||||
try
|
||||
|
Loading…
Reference in New Issue
Block a user