SPAWNRYS/bloxstrap
1
0
Fork 0
mirror of https://github.com/bloxstraplabs/bloxstrap.git synced 2025-04-21 10:01:27 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

Make channel selection error info more accurate

Browse Source
This commit is contained in:
pizzaboxer 2023-07-20 12:39:03 +01:00
parent dc70720ff7
commit b677ce5aea
No known key found for this signature in database
GPG Key ID: 59D4A1DBAD0F2BA8
4 changed files with 46 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Bloxstrap/Exceptions/HttpResponseUnsuccessfulException.cs Normal file
View File

@ -0,0 +1,18 @@
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
namespace Bloxstrap.Exceptions
{
internal class HttpResponseUnsuccessfulException : Exception
{
public HttpResponseMessage ResponseMessage { get; }
public HttpResponseUnsuccessfulException(HttpResponseMessage responseMessage) : base()
{
ResponseMessage = responseMessage;
}
}
}

6
Bloxstrap/RobloxDeployment.cs
View File

@ -1,4 +1,6 @@
namespace Bloxstrap using Bloxstrap.Exceptions;
namespace Bloxstrap
{ {
public static class RobloxDeployment public static class RobloxDeployment
{ {
@ -109,7 +111,7 @@
$"\tResponse: {rawResponse}" $"\tResponse: {rawResponse}"
); );
throw new Exception($"Could not get latest deploy for channel {channel}! (HTTP {deployInfoResponse.StatusCode})"); throw new HttpResponseUnsuccessfulException(deployInfoResponse);
} }
clientVersion = JsonSerializer.Deserialize<ClientVersion>(rawResponse)!; clientVersion = JsonSerializer.Deserialize<ClientVersion>(rawResponse)!;

2
Bloxstrap/UI/Elements/Menu/Pages/BehaviourPage.xaml
View File

@ -100,7 +100,7 @@
<ui:ProgressRing Grid.Column="0" Margin="6" IsIndeterminate="True" Visibility="{Binding LoadingSpinnerVisibility, Mode=OneWay}" /> <ui:ProgressRing Grid.Column="0" Margin="6" IsIndeterminate="True" Visibility="{Binding LoadingSpinnerVisibility, Mode=OneWay}" />
<Image Grid.Column="0" Margin="6" Width="60" Height="60" Visibility="{Binding LoadingErrorVisibility, Mode=OneWay}" RenderOptions.BitmapScalingMode="HighQuality" Source="pack://application:,,,/Resources/MessageBox/Error.png" /> <Image Grid.Column="0" Margin="6" Width="60" Height="60" Visibility="{Binding LoadingErrorVisibility, Mode=OneWay}" RenderOptions.BitmapScalingMode="HighQuality" Source="pack://application:,,,/Resources/MessageBox/Error.png" />
<TextBlock Grid.Column="1" Margin="16" VerticalAlignment="Center" Text="{Binding ChannelInfoLoadingText, Mode=OneWay}" /> <TextBlock Grid.Column="1" Margin="16" VerticalAlignment="Center" Text="{Binding ChannelInfoLoadingText, Mode=OneWay}" TextWrapping="Wrap" />
</Grid> </Grid>
</StackPanel> </StackPanel>
</ui:CardExpander> </ui:CardExpander>

25
Bloxstrap/UI/ViewModels/Menu/BehaviourViewModel.cs
View File

@ -1,5 +1,7 @@
using System.Windows; using System.Windows;
using Bloxstrap.Exceptions;
namespace Bloxstrap.UI.ViewModels.Menu namespace Bloxstrap.UI.ViewModels.Menu
{ {
public class BehaviourViewModel : NotifyPropertyChangedViewModel public class BehaviourViewModel : NotifyPropertyChangedViewModel
@ -39,11 +41,30 @@ namespace Bloxstrap.UI.ViewModels.Menu
OnPropertyChanged(nameof(ChannelWarningVisibility)); OnPropertyChanged(nameof(ChannelWarningVisibility));
OnPropertyChanged(nameof(ChannelDeployInfo)); OnPropertyChanged(nameof(ChannelDeployInfo));
} }
catch (Exception) catch (HttpResponseUnsuccessfulException ex)
{ {
LoadingSpinnerVisibility = Visibility.Collapsed; LoadingSpinnerVisibility = Visibility.Collapsed;
LoadingErrorVisibility = Visibility.Visible; LoadingErrorVisibility = Visibility.Visible;
ChannelInfoLoadingText = "Could not get deployment information! Is the channel name valid?";
ChannelInfoLoadingText = ex.ResponseMessage.StatusCode switch
{
HttpStatusCode.NotFound => "The specified channel name does not exist.",
_ => $"Failed to fetch information! (HTTP {ex.ResponseMessage.StatusCode})",
};
OnPropertyChanged(nameof(LoadingSpinnerVisibility));
OnPropertyChanged(nameof(LoadingErrorVisibility));
OnPropertyChanged(nameof(ChannelInfoLoadingText));
}
catch (Exception ex)
{
LoadingSpinnerVisibility = Visibility.Collapsed;
LoadingErrorVisibility = Visibility.Visible;
App.Logger.WriteLine("[BehaviourViewModel::LoadChannelDeployInfo] An exception occurred while fetching channel information");
App.Logger.WriteLine($"[BehaviourViewModel::LoadChannelDeployInfo] {ex}");
ChannelInfoLoadingText = $"Failed to fetch information! ({ex.Message})";
OnPropertyChanged(nameof(LoadingSpinnerVisibility)); OnPropertyChanged(nameof(LoadingSpinnerVisibility));
OnPropertyChanged(nameof(LoadingErrorVisibility)); OnPropertyChanged(nameof(LoadingErrorVisibility));