From b68d43f8f5b061cf28fadc10ee24b87594e13d33 Mon Sep 17 00:00:00 2001 From: bluepilledgreat <97983689+bluepilledgreat@users.noreply.github.com> Date: Sun, 8 Dec 2024 11:49:43 +0000 Subject: [PATCH] fix CompareVersions crash --- Bloxstrap/Utilities.cs | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/Bloxstrap/Utilities.cs b/Bloxstrap/Utilities.cs index 35c11ac..eeea1d6 100644 --- a/Bloxstrap/Utilities.cs +++ b/Bloxstrap/Utilities.cs @@ -30,6 +30,18 @@ namespace Bloxstrap } } + public static Version GetVersionFromString(string version) + { + if (version.StartsWith('v')) + version = version[1..]; + + int idx = version.IndexOf('+'); // commit info + if (idx != -1) + version = version[..idx]; + + return new Version(version); + } + /// /// /// @@ -45,8 +57,8 @@ namespace Bloxstrap { try { - var version1 = new Version(versionStr1.Replace("v", "")); - var version2 = new Version(versionStr2.Replace("v", "")); + var version1 = GetVersionFromString(versionStr1); + var version2 = GetVersionFromString(versionStr2); return (VersionComparison)version1.CompareTo(version2); }