SPAWNRYS/bloxstrap
1
0
Fork 0
mirror of https://github.com/bloxstraplabs/bloxstrap.git synced 2025-04-21 10:01:27 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add diagnostic log for version comparison

Browse Source
This commit is contained in:
pizzaboxer 2024-10-25 21:47:59 +01:00
parent 5bdac105c2
commit c7ab37edf1
No known key found for this signature in database
GPG Key ID: 59D4A1DBAD0F2BA8
1 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Bloxstrap/Utilities.cs
View File

@ -41,12 +41,26 @@ namespace Bloxstrap
/// 1: version1 > version2 /// 1: version1 > version2
/// </returns> /// </returns>
public static VersionComparison CompareVersions(string versionStr1, string versionStr2) public static VersionComparison CompareVersions(string versionStr1, string versionStr2)
{
try
{ {
var version1 = new Version(versionStr1.Replace("v", "")); var version1 = new Version(versionStr1.Replace("v", ""));
var version2 = new Version(versionStr2.Replace("v", "")); var version2 = new Version(versionStr2.Replace("v", ""));
return (VersionComparison)version1.CompareTo(version2); return (VersionComparison)version1.CompareTo(version2);
} }
catch (Exception)
{
// temporary diagnostic log for the issue described here:
// https://github.com/bloxstraplabs/bloxstrap/issues/3193
// the problem is that this happens only on upgrade, so my only hope of catching this is bug reports following the next release
App.Logger.WriteLine("Utilities::CompareVersions", "An exception occurred when comparing versions");
App.Logger.WriteLine("Utilities::CompareVersions", $"versionStr1={versionStr1} versionStr2={versionStr2}");
throw;
}
}
public static string GetRobloxVersion(bool studio) public static string GetRobloxVersion(bool studio)
{ {