Add mutexes for settings, installer and uninstaller

Bloxstrap/LaunchHandler.cs

@@ -1,12 +1,6 @@
-using System;
+using System.Windows;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
-using System.Windows;
 
 using Bloxstrap.UI.Elements.Dialogs;
-using Bloxstrap.Resources;
 
 using Microsoft.Win32;
 using Windows.Win32;
@@ -50,7 +44,13 @@ namespace Bloxstrap
 
         public static void LaunchInstaller()
         {
-            // TODO: detect duplicate launch, mutex maybe?
+            using var interlock = new InterProcessLock("Installer");
+
+            if (!interlock.IsAcquired)
+            {
+                Frontend.ShowMessageBox(Strings.Dialog_AlreadyRunning_Installer, MessageBoxImage.Stop);
+                return;
+            }
 
             if (App.LaunchSettings.IsUninstall)
             {
@@ -68,6 +68,8 @@ namespace Bloxstrap
 
                 installer.DoInstall();
 
+                interlock.Dispose();
+
                 ProcessLaunchArgs();
             }
             else
@@ -77,6 +79,8 @@ namespace Bloxstrap
                 var installer = new UI.Elements.Installer.MainWindow();
                 installer.ShowDialog();
 
+                interlock.Dispose();
+
                 ProcessNextAction(installer.CloseAction, !installer.Finished);
             }
             
@@ -84,6 +88,15 @@ namespace Bloxstrap
 
         public static void LaunchUninstaller()
         {
+            using var interlock = new InterProcessLock("Uninstaller");
+
+            if (!interlock.IsAcquired)
+            {
+                Frontend.ShowMessageBox(Strings.Dialog_AlreadyRunning_Uninstaller, MessageBoxImage.Stop);
+                return;
+            }
+
+
             bool confirmed = false;
             bool keepData = true;
 
@@ -112,20 +125,21 @@ namespace Bloxstrap
         {
             const string LOG_IDENT = "LaunchHandler::LaunchSettings";
 
-            // TODO: move to mutex (especially because multi language whatever)
+            using var interlock = new InterProcessLock("Settings");
 
-            Process? menuProcess = Utilities.GetProcessesSafe().Where(x => x.MainWindowTitle == Strings.Menu_Title).FirstOrDefault();
+            if (interlock.IsAcquired)
-
-            if (menuProcess is not null)
             {
-                var handle = menuProcess.MainWindowHandle;
+                bool showAlreadyRunningWarning = Process.GetProcessesByName(App.ProjectName).Length > 1;
-                App.Logger.WriteLine(LOG_IDENT, $"Found an already existing menu window with handle {handle}");
+                new UI.Elements.Settings.MainWindow(showAlreadyRunningWarning).ShowDialog();
-                PInvoke.SetForegroundWindow((HWND)handle);
             }
             else
             {
-                bool showAlreadyRunningWarning = Process.GetProcessesByName(App.ProjectName).Length > 1 && !App.LaunchSettings.IsQuiet;
+                App.Logger.WriteLine(LOG_IDENT, $"Found an already existing menu window");
-                new UI.Elements.Settings.MainWindow(showAlreadyRunningWarning).ShowDialog();
+             
+                var process = Utilities.GetProcessesSafe().Where(x => x.MainWindowTitle == Strings.Menu_Title).FirstOrDefault();
+
+                if (process is not null)
+                    PInvoke.SetForegroundWindow((HWND)process.MainWindowHandle);
             }
         }
 

Bloxstrap/Resources/Strings.Designer.cs

@@ -729,6 +729,24 @@ namespace Bloxstrap.Resources {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to Please wait for installation to finish..
+        /// </summary>
+        public static string Dialog_AlreadyRunning_Installer {
+            get {
+                return ResourceManager.GetString("Dialog.AlreadyRunning.Installer", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Please wait for uninstallation to finish..
+        /// </summary>
+        public static string Dialog_AlreadyRunning_Uninstaller {
+            get {
+                return ResourceManager.GetString("Dialog.AlreadyRunning.Uninstaller", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Bloxstrap was unable to create shortcuts for the Desktop and Start menu. Try creating them later through the settings..
         /// </summary>

Bloxstrap/Resources/Strings.resx

@@ -1124,4 +1124,10 @@ If not, then please report this exception to the maintainers of this fork. Do NO
 
 {0}</value>
   </data>
+  <data name="Dialog.AlreadyRunning.Installer" xml:space="preserve">
+    <value>Please wait for installation to finish.</value>
+  </data>
+  <data name="Dialog.AlreadyRunning.Uninstaller" xml:space="preserve">
+    <value>Please wait for uninstallation to finish.</value>
+  </data>
 </root>

Bloxstrap/Utility/InterProcessLock.cs

@@ -12,6 +12,8 @@ namespace Bloxstrap.Utility
 
         public bool IsAcquired { get; private set; }
 
+        public InterProcessLock(string name) : this(name, TimeSpan.Zero) { }
+
         public InterProcessLock(string name, TimeSpan timeout)
         {
             Mutex = new Mutex(false, "Bloxstrap-" + name);
@@ -25,6 +27,8 @@ namespace Bloxstrap.Utility
                 Mutex.ReleaseMutex();
                 IsAcquired = false;
             }
+
+            GC.SuppressFinalize(this);
         }
     }
 }